Skip to content

Tree-Shake Repo #4489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 23, 2021
Merged

Tree-Shake Repo #4489

merged 11 commits into from
Feb 23, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: e36deaa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 18, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/database

    Type Base (483567a) Head (d3ac9e9) Diff
    browser 277 kB 276 kB -962 B (-0.3%)
    esm2017 245 kB 246 kB +303 B (+0.1%)
    main 280 kB 279 kB -962 B (-0.3%)
    module 277 kB 276 kB -962 B (-0.3%)

  • @firebase/database-exp

    Type Base (483567a) Head (d3ac9e9) Diff
    browser 278 kB 276 kB -1.74 kB (-0.6%)
    esm2017 243 kB 243 kB -426 B (-0.2%)
    main 279 kB 278 kB -1.74 kB (-0.6%)
    module 278 kB 276 kB -1.74 kB (-0.6%)

  • @firebase/firestore-exp

    Type Base (483567a) Head (d3ac9e9) Diff
    main 505 kB 505 kB -3 B (-0.0%)

  • firebase

    Type Base (483567a) Head (d3ac9e9) Diff
    firebase-database.js 189 kB 186 kB -3.50 kB (-1.8%)
    firebase.js 851 kB 847 kB -3.52 kB (-0.4%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 18, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (483567a) and head commit (d3ac9e9).

Feiyang1
Feiyang1 suggested changes Feb 19, 2021
View reviewed changes
packages/database/src/core/Repo.ts Outdated

get database(): Database {
return this.__database || (this.__database = new Database(this));
repoSendReadyTransactions(repo, this.transactionQueueTree_);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repoSendReadyTransactions(repo, this.transactionQueueTree_);
repoSendReadyTransactions(repo, repo.transactionQueueTree_);

packages/database/src/core/Repo.ts Outdated
repo.transactionQueueTree_.subTree(path)
);
// There may be pending transactions that we can now send.
repoSendReadyTransactions(repo, this.transactionQueueTree_);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repoSendReadyTransactions(repo, this.transactionQueueTree_);
repoSendReadyTransactions(repo, repo.transactionQueueTree_);

schmidt-sebastian
schmidt-sebastian commented Feb 19, 2021
View reviewed changes
Copy link
Contributor Author

@schmidt-sebastian schmidt-sebastian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied your fixes, and fixed a bunch more instances of the same problem.

FYI: The tests should pass now. I am not able to run them locally right now ('app-exp' is not assignable ...). I will look into this next week. I think it only affects my setup.

@schmidt-sebastian schmidt-sebastian merged commit 6a86a1b into master Feb 23, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/repo branch February 23, 2021 18:17
@firebase firebase locked and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@jsdt jsdt Awaiting requested review from jsdt

Assignees

@Feiyang1 Feiyang1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmidt-sebastian @google-oss-bot @Feiyang1 @hsubox76