Skip to content

Remove downlevelIteration from firebaseApp #4471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Feb 12, 2021

This shaves off a little bit of size. It was meant to fix #4207, but is no longer needed for it. It sill saves some bytes though.

@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2021

⚠️ No Changeset found

Latest commit: 6a75603

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/app

    Type Base (9ac2093) Head (b730f2d) Diff
    browser 11.2 kB 10.8 kB -353 B (-3.2%)
    esm2017 9.58 kB 9.57 kB -12 B (-0.1%)
    lite 9.25 kB 8.88 kB -372 B (-4.0%)
    lite-esm2017 7.88 kB 7.87 kB -12 B (-0.2%)
    main 10.9 kB 10.6 kB -360 B (-3.3%)
    module 11.2 kB 10.8 kB -353 B (-3.2%)
    react-native 10.6 kB 10.3 kB -360 B (-3.4%)
  • firebase

    Type Base (9ac2093) Head (b730f2d) Diff
    firebase-app.js 20.2 kB 19.9 kB -276 B (-1.4%)
    firebase-performance-standalone.es2017.js 71.9 kB 71.9 kB -10 B (-0.0%)
    firebase-performance-standalone.js 48.3 kB 48.0 kB -271 B (-0.6%)
    firebase.js 854 kB 854 kB -273 B (-0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (9ac2093) and head commit (b730f2d).

@schmidt-sebastian schmidt-sebastian merged commit 5538349 into master Feb 17, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/removedownleveliteration branch February 17, 2021 01:32
@firebase firebase locked and limited conversation to collaborators Mar 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants