Skip to content

Add externs annotation to firebase-externs #4455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Add externs annotation to firebase-externs #4455

merged 1 commit into from
Mar 12, 2021

Conversation

hsubox76
Copy link
Contributor

An internal change was requested (see cl/356656077), this makes it permanent and prevents that change from being overwritten next time the firebase library is imported to google3.

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2021

⚠️ No Changeset found

Latest commit: 6587d12

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (318af54) and head commit (b0d8210).

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (318af54) and head commit (b0d8210).

Test Logs

@hsubox76 hsubox76 merged commit 2ed3291 into master Mar 12, 2021
@hsubox76 hsubox76 deleted the ch-externs branch March 12, 2021 00:33
@firebase firebase locked and limited conversation to collaborators Apr 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants