Skip to content

Remove Closure types #4435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Remove Closure types #4435

merged 1 commit into from
Feb 8, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

Find & Replace to fix one of my gripes with the RTDB SDK.

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2021

⚠️ No Changeset found

Latest commit: f542ac4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/database

    Type Base (3da2039) Head (d84d63a) Diff
    browser 276 kB 276 kB -24 B (-0.0%)
    esm2017 243 kB 243 kB -24 B (-0.0%)
    main 279 kB 279 kB -24 B (-0.0%)
    module 276 kB 276 kB -24 B (-0.0%)
  • @firebase/database-exp

    Type Base (3da2039) Head (d84d63a) Diff
    browser 277 kB 277 kB -24 B (-0.0%)
    esm2017 241 kB 241 kB -24 B (-0.0%)
    main 279 kB 279 kB -24 B (-0.0%)
    module 277 kB 277 kB -24 B (-0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (3da2039) and head commit (d84d63a).

@schmidt-sebastian schmidt-sebastian merged commit 40a702e into master Feb 8, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/closuretypes branch February 8, 2021 23:48
@firebase firebase locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants