Skip to content

Throw an error when the Auth (exp) internal instance is used by another SDK before Auth initialization #4428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Feb 5, 2021

Fixes #4425

"Fixes" is a loose sense. There's not a good fix for this. The error will at least make it clear what the remedy is.

@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2021

⚠️ No Changeset found

Latest commit: 9ee881c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (e3c55b2) and head commit (5193f30).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

  • @firebase/auth-exp

    • ActionCodeURL

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.5 kB
      28.9 kB
      +444 B (+1.6%)
      size-with-ext-deps
      39.0 kB
      39.4 kB
      +445 B (+1.1%)
    • AuthCredential

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      27.7 kB
      28.2 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.2 kB
      38.7 kB
      +445 B (+1.2%)
    • EmailAuthCredential

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      29.5 kB
      29.9 kB
      +444 B (+1.5%)
      size-with-ext-deps
      40.0 kB
      40.4 kB
      +445 B (+1.1%)
    • EmailAuthProvider

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      30.9 kB
      31.3 kB
      +444 B (+1.4%)
      size-with-ext-deps
      41.4 kB
      41.8 kB
      +445 B (+1.1%)
    • FacebookAuthProvider

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      31.3 kB
      31.8 kB
      +444 B (+1.4%)
      size-with-ext-deps
      41.8 kB
      42.3 kB
      +445 B (+1.1%)
    • GithubAuthProvider

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      31.3 kB
      31.7 kB
      +444 B (+1.4%)
      size-with-ext-deps
      41.8 kB
      42.2 kB
      +445 B (+1.1%)
    • GoogleAuthProvider

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      31.3 kB
      31.8 kB
      +444 B (+1.4%)
      size-with-ext-deps
      41.8 kB
      42.3 kB
      +445 B (+1.1%)
    • OAuthCredential

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      29.5 kB
      30.0 kB
      +444 B (+1.5%)
      size-with-ext-deps
      40.0 kB
      40.5 kB
      +445 B (+1.1%)
    • OAuthProvider

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      30.7 kB
      31.1 kB
      +444 B (+1.4%)
      size-with-ext-deps
      41.2 kB
      41.6 kB
      +445 B (+1.1%)
    • PhoneAuthCredential

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      29.5 kB
      30.0 kB
      +444 B (+1.5%)
      size-with-ext-deps
      40.0 kB
      40.5 kB
      +445 B (+1.1%)
    • PhoneAuthProvider

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      31.1 kB
      31.6 kB
      +444 B (+1.4%)
      size-with-ext-deps
      41.7 kB
      42.1 kB
      +445 B (+1.1%)
    • PhoneMultiFactorGenerator

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.4 kB
      28.8 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.9 kB
      39.3 kB
      +445 B (+1.1%)
    • RecaptchaVerifier

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      33.7 kB
      34.2 kB
      +444 B (+1.3%)
      size-with-ext-deps
      44.3 kB
      44.7 kB
      +445 B (+1.0%)
    • TwitterAuthProvider

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      31.3 kB
      31.8 kB
      +444 B (+1.4%)
      size-with-ext-deps
      41.8 kB
      42.3 kB
      +445 B (+1.1%)
    • applyActionCode

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      27.6 kB
      28.0 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.1 kB
      38.5 kB
      +445 B (+1.2%)
    • checkActionCode

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.5 kB
      29.0 kB
      +444 B (+1.6%)
      size-with-ext-deps
      39.0 kB
      39.5 kB
      +445 B (+1.1%)
    • confirmPasswordReset

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      27.6 kB
      28.1 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.1 kB
      38.6 kB
      +445 B (+1.2%)
    • createUserWithEmailAndPassword

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.5 kB
      28.9 kB
      +444 B (+1.6%)
      size-with-ext-deps
      39.0 kB
      39.4 kB
      +445 B (+1.1%)
    • deleteUser

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      27.5 kB
      27.9 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.0 kB
      38.4 kB
      +445 B (+1.2%)
    • fetchSignInMethodsForEmail

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      27.8 kB
      28.3 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.3 kB
      38.8 kB
      +445 B (+1.2%)
    • getAdditionalUserInfo

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.8 kB
      29.3 kB
      +444 B (+1.5%)
      size-with-ext-deps
      39.3 kB
      39.8 kB
      +445 B (+1.1%)
    • getAuth

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      55.0 kB
      55.4 kB
      +444 B (+0.8%)
      size-with-ext-deps
      65.7 kB
      66.1 kB
      +445 B (+0.7%)
    • getIdToken

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      27.5 kB
      28.0 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.0 kB
      38.5 kB
      +445 B (+1.2%)
    • getIdTokenResult

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      27.5 kB
      27.9 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.0 kB
      38.4 kB
      +445 B (+1.2%)
    • getMultiFactorResolver

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      30.2 kB
      30.7 kB
      +444 B (+1.5%)
      size-with-ext-deps
      40.7 kB
      41.2 kB
      +445 B (+1.1%)
    • getRedirectResult

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      33.1 kB
      33.6 kB
      +444 B (+1.3%)
      size-with-ext-deps
      43.6 kB
      44.1 kB
      +445 B (+1.0%)
    • initializeAuth

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      27.8 kB
      28.3 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.4 kB
      38.8 kB
      +445 B (+1.2%)
    • isSignInWithEmailLink

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.6 kB
      29.0 kB
      +444 B (+1.6%)
      size-with-ext-deps
      39.1 kB
      39.5 kB
      +445 B (+1.1%)
    • linkWithCredential

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.5 kB
      28.9 kB
      +444 B (+1.6%)
      size-with-ext-deps
      39.0 kB
      39.4 kB
      +445 B (+1.1%)
    • linkWithPhoneNumber

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      32.0 kB
      32.5 kB
      +444 B (+1.4%)
      size-with-ext-deps
      42.5 kB
      43.0 kB
      +445 B (+1.0%)
    • linkWithPopup

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      36.4 kB
      36.9 kB
      +444 B (+1.2%)
      size-with-ext-deps
      47.0 kB
      47.4 kB
      +445 B (+0.9%)
    • linkWithRedirect

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      31.5 kB
      31.9 kB
      +444 B (+1.4%)
      size-with-ext-deps
      42.0 kB
      42.4 kB
      +445 B (+1.1%)
    • multiFactor

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      29.6 kB
      30.0 kB
      +444 B (+1.5%)
      size-with-ext-deps
      40.1 kB
      40.5 kB
      +445 B (+1.1%)
    • onAuthStateChanged

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      27.5 kB
      28.0 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.0 kB
      38.5 kB
      +445 B (+1.2%)
    • onIdTokenChanged

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      27.5 kB
      28.0 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.0 kB
      38.5 kB
      +445 B (+1.2%)
    • parseActionCodeURL

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.5 kB
      29.0 kB
      +444 B (+1.6%)
      size-with-ext-deps
      39.0 kB
      39.5 kB
      +445 B (+1.1%)
    • reauthenticateWithCredential

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      29.1 kB
      29.5 kB
      +444 B (+1.5%)
      size-with-ext-deps
      39.6 kB
      40.0 kB
      +445 B (+1.1%)
    • reauthenticateWithPhoneNumber

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      32.6 kB
      33.0 kB
      +444 B (+1.4%)
      size-with-ext-deps
      43.1 kB
      43.5 kB
      +445 B (+1.0%)
    • reauthenticateWithPopup

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      36.4 kB
      36.9 kB
      +444 B (+1.2%)
      size-with-ext-deps
      47.0 kB
      47.4 kB
      +445 B (+0.9%)
    • reauthenticateWithRedirect

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      31.2 kB
      31.6 kB
      +444 B (+1.4%)
      size-with-ext-deps
      41.7 kB
      42.2 kB
      +445 B (+1.1%)
    • reload

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      27.5 kB
      27.9 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.0 kB
      38.4 kB
      +445 B (+1.2%)
    • sendEmailVerification

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.4 kB
      28.8 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.9 kB
      39.3 kB
      +445 B (+1.1%)
    • sendPasswordResetEmail

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.3 kB
      28.7 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.8 kB
      39.2 kB
      +445 B (+1.1%)
    • sendSignInLinkToEmail

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.4 kB
      28.8 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.9 kB
      39.3 kB
      +445 B (+1.1%)
    • setPersistence

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      27.5 kB
      28.0 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.0 kB
      38.5 kB
      +445 B (+1.2%)
    • signInAnonymously

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.6 kB
      29.1 kB
      +444 B (+1.6%)
      size-with-ext-deps
      39.1 kB
      39.5 kB
      +445 B (+1.1%)
    • signInWithCredential

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.9 kB
      29.3 kB
      +444 B (+1.5%)
      size-with-ext-deps
      39.4 kB
      39.8 kB
      +445 B (+1.1%)
    • signInWithCustomToken

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.5 kB
      28.9 kB
      +444 B (+1.6%)
      size-with-ext-deps
      39.0 kB
      39.4 kB
      +445 B (+1.1%)
    • signInWithEmailAndPassword

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      32.3 kB
      32.8 kB
      +444 B (+1.4%)
      size-with-ext-deps
      42.8 kB
      43.3 kB
      +445 B (+1.0%)
    • signInWithEmailLink

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      32.5 kB
      33.0 kB
      +444 B (+1.4%)
      size-with-ext-deps
      43.0 kB
      43.5 kB
      +445 B (+1.0%)
    • signInWithPhoneNumber

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      32.4 kB
      32.8 kB
      +444 B (+1.4%)
      size-with-ext-deps
      42.9 kB
      43.3 kB
      +445 B (+1.0%)
    • signInWithPopup

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      36.4 kB
      36.9 kB
      +444 B (+1.2%)
      size-with-ext-deps
      46.9 kB
      47.4 kB
      +445 B (+0.9%)
    • signInWithRedirect

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      30.9 kB
      31.4 kB
      +444 B (+1.4%)
      size-with-ext-deps
      41.4 kB
      41.9 kB
      +445 B (+1.1%)
    • signOut

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      27.5 kB
      27.9 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.0 kB
      38.4 kB
      +445 B (+1.2%)
    • unlink

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.1 kB
      28.5 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.6 kB
      39.0 kB
      +445 B (+1.2%)
    • updateCurrentUser

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      27.5 kB
      28.0 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.0 kB
      38.5 kB
      +445 B (+1.2%)
    • updateEmail

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      27.8 kB
      28.2 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.3 kB
      38.7 kB
      +445 B (+1.2%)
    • updatePassword

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      27.8 kB
      28.2 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.3 kB
      38.7 kB
      +445 B (+1.2%)
    • updatePhoneNumber

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.2 kB
      28.7 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.7 kB
      39.2 kB
      +445 B (+1.1%)
    • updateProfile

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.0 kB
      28.4 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.5 kB
      38.9 kB
      +445 B (+1.2%)
    • useAuthEmulator

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.5 kB
      29.0 kB
      +444 B (+1.6%)
      size-with-ext-deps
      39.0 kB
      39.5 kB
      +445 B (+1.1%)
    • useDeviceLanguage

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      27.5 kB
      28.0 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.0 kB
      38.5 kB
      +445 B (+1.2%)
    • verifyBeforeUpdateEmail

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.4 kB
      28.9 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.9 kB
      39.4 kB
      +445 B (+1.1%)
    • verifyPasswordResetCode

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.6 kB
      29.0 kB
      +444 B (+1.6%)
      size-with-ext-deps
      39.1 kB
      39.6 kB
      +445 B (+1.1%)
    • browserLocalPersistence

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      30.5 kB
      30.9 kB
      +444 B (+1.5%)
      size-with-ext-deps
      41.0 kB
      41.5 kB
      +445 B (+1.1%)
    • browserPopupRedirectResolver

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      44.8 kB
      45.2 kB
      +444 B (+1.0%)
      size-with-ext-deps
      55.4 kB
      55.9 kB
      +445 B (+0.8%)
    • browserSessionPersistence

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      28.1 kB
      28.6 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.6 kB
      39.1 kB
      +445 B (+1.2%)
    • debugErrorMap

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      38.0 kB
      38.7 kB
      +678 B (+1.8%)
      size-with-ext-deps
      48.5 kB
      49.2 kB
      +679 B (+1.4%)
    • inMemoryPersistence

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      27.5 kB
      27.9 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.0 kB
      38.4 kB
      +445 B (+1.2%)
    • indexedDBLocalPersistence

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      34.9 kB
      35.3 kB
      +444 B (+1.3%)
      size-with-ext-deps
      45.3 kB
      45.8 kB
      +445 B (+1.0%)
    • prodErrorMap

      Size Table

      TypeBase (e3c55b2)Head (5193f30)Diff
      size
      27.5 kB
      27.9 kB
      +444 B (+1.6%)
      size-with-ext-deps
      38.0 kB
      38.4 kB
      +445 B (+1.2%)

@sam-gc sam-gc merged commit 3da2039 into master Feb 8, 2021
@sam-gc sam-gc deleted the samgho/auth-internal-error branch February 8, 2021 20:55
@firebase firebase locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth throws when using Database before calling initializeAuth or getAuth
4 participants