-
Notifications
You must be signed in to change notification settings - Fork 927
Add startAfter() and endBefore() to database types #4427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 318538e The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs |
Size Analysis ReportAffected Products
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, thanks!
* The ending point is exclusive. If only a value is provided, children | ||
* with a value less than the specified value will be included in the query. | ||
* If a key is specified, then children must have a value lesss than or equal | ||
* to the specified value and a a key name less than the specified key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
* allows you to choose arbitrary starting and ending points for your queries. | ||
* | ||
* The starting point is exclusive. If only a value is provided, children | ||
* with a value greater than the specified value will be included in the query. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above; "are included"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review! Feedback addressed.
* The ending point is exclusive. If only a value is provided, children | ||
* with a value less than the specified value will be included in the query. | ||
* If a key is specified, then children must have a value lesss than or equal | ||
* to the specified value and a a key name less than the specified key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
* allows you to choose arbitrary starting and ending points for your queries. | ||
* | ||
* The starting point is exclusive. If only a value is provided, children | ||
* with a value greater than the specified value will be included in the query. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Changeset File Check
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Add missing public types for startAfter/endBefore.