Skip to content

Fix database exp exports #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Fix database exp exports #4418

merged 2 commits into from
Feb 5, 2021

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Feb 5, 2021

  1. Export ServerValue as a value. Fixes Unclear how to use ServerValue.TIMESTAMP in RTDB SDK #4406
  2. Remove implementation exports where only types should be exported.

@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2021

⚠️ No Changeset found

Latest commit: c331a22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/database-exp

    Type Base (5d7575b) Head (61f1412) Diff
    browser 277 kB 277 kB -59 B (-0.0%)
    esm2017 241 kB 241 kB -59 B (-0.0%)
    main 279 kB 279 kB -158 B (-0.1%)
    module 277 kB 277 kB -59 B (-0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (5d7575b) and head commit (61f1412).

@Feiyang1 Feiyang1 merged commit e3c55b2 into master Feb 5, 2021
@Feiyang1 Feiyang1 deleted the fei-database-exp-exports branch February 5, 2021 19:23
@firebase firebase locked and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear how to use ServerValue.TIMESTAMP in RTDB SDK
3 participants