Add the outward-bound part of the Cordova redirect flow to auth@exp #4413
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| /** | ||
| * @license | ||
| * Copyright 2020 Google LLC | ||
sam-gc marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { SDK_VERSION } from '@firebase/app-exp'; | ||
| import * as externs from '@firebase/auth-types-exp'; | ||
| import { ApiKey, AppName, Auth } from '../../model/auth'; | ||
| import { AuthEventType } from '../../model/popup_redirect'; | ||
| import { AuthErrorCode } from '../errors'; | ||
| import { OAuthProvider } from '../providers/oauth'; | ||
| import { _assert } from './assert'; | ||
| import { isEmpty, querystring } from '@firebase/util'; | ||
| import { _emulatorUrl } from './emulator'; | ||
|
|
||
| /** | ||
| * URL for Authentication widget which will initiate the OAuth handshake | ||
| * | ||
| * @internal | ||
| */ | ||
| const WIDGET_PATH = '__/auth/handler'; | ||
|
|
||
| /** | ||
| * URL for emulated environment | ||
| * | ||
| * @internal | ||
| */ | ||
| const EMULATOR_WIDGET_PATH = 'emulator/auth/handler'; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/consistent-type-definitions | ||
| type WidgetParams = { | ||
| apiKey: ApiKey; | ||
| appName: AppName; | ||
| authType: AuthEventType; | ||
| redirectUrl?: string; | ||
| v: string; | ||
| providerId?: string; | ||
| scopes?: string; | ||
| customParameters?: string; | ||
| eventId?: string; | ||
| tid?: string; | ||
| } & { [key: string]: string | undefined }; | ||
|
|
||
| export function _getRedirectUrl( | ||
|
There was a problem hiding this comment. This is moved from |
||
| auth: Auth, | ||
| provider: externs.AuthProvider, | ||
| authType: AuthEventType, | ||
| redirectUrl?: string, | ||
| eventId?: string, | ||
| additionalParams?: Record<string, string> | ||
| ): string { | ||
| _assert(auth.config.authDomain, auth, AuthErrorCode.MISSING_AUTH_DOMAIN); | ||
| _assert(auth.config.apiKey, auth, AuthErrorCode.INVALID_API_KEY); | ||
|
|
||
| const params: WidgetParams = { | ||
| apiKey: auth.config.apiKey, | ||
| appName: auth.name, | ||
| authType, | ||
| redirectUrl, | ||
| v: SDK_VERSION, | ||
| eventId | ||
| }; | ||
|
|
||
| if (provider instanceof OAuthProvider) { | ||
| provider.setDefaultLanguage(auth.languageCode); | ||
| params.providerId = provider.providerId || ''; | ||
| if (!isEmpty(provider.getCustomParameters())) { | ||
| params.customParameters = JSON.stringify(provider.getCustomParameters()); | ||
| } | ||
| const scopes = provider.getScopes().filter(scope => scope !== ''); | ||
| if (scopes.length > 0) { | ||
| params.scopes = scopes.join(','); | ||
| } | ||
| // TODO set additionalParams? | ||
sam-gc marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| for (const [key, value] of Object.entries(additionalParams || {})) { | ||
| params[key] = value; | ||
| } | ||
| } | ||
|
|
||
| if (auth.tenantId) { | ||
| params.tid = auth.tenantId; | ||
| } | ||
|
|
||
| for (const key of Object.keys(params)) { | ||
| if ((params as Record<string, unknown>)[key] === undefined) { | ||
| delete (params as Record<string, unknown>)[key]; | ||
| } | ||
| } | ||
|
|
||
| // TODO: maybe set eid as endipointId | ||
| // TODO: maybe set fw as Frameworks.join(",") | ||
|
|
||
| const url = new URL( | ||
| `${getHandlerBase(auth)}?${querystring( | ||
| params as Record<string, string | number> | ||
| ).slice(1)}` | ||
| ); | ||
|
|
||
| return url.toString(); | ||
| } | ||
|
|
||
| function getHandlerBase({ config }: Auth): string { | ||
| if (!config.emulator) { | ||
| return `https://${config.authDomain}/${WIDGET_PATH}`; | ||
| } | ||
|
|
||
| return _emulatorUrl(config, EMULATOR_WIDGET_PATH); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: shall we add the other tests too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which other tests?