-
Notifications
You must be signed in to change notification settings - Fork 928
Fill out storage bucket url param #4410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Analysis Report |
@hsubox76 to be clear this is what I see in my types today: /**
* Gets a Firebase StorageService instance for the given Firebase app.
* @public
* @param app - Firebase app to get Storage instance for.
* @returns A Firebase StorageService instance.
*/
export declare function getStorage(app: FirebaseApp): StorageService; So in #4407 I wasn't saying that the Edit: this changed between /**
* Gets a Firebase StorageService instance for the given Firebase app.
* @public
* @param app - Firebase app to get Storage instance for.
* @returns A Firebase StorageService instance.
*/
export declare function getStorage(app: FirebaseApp, url?: string): StorageService; This change LGTM anyway! Definitely clearer. |
export function getStorage(app: FirebaseApp, url?: string): StorageService { | ||
export function getStorage( | ||
app: FirebaseApp, | ||
bucketUrl?: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gsUrl?
Feel free to keep as is.
Add jsdoc description and change name from
url
tobucketUrl
to make it more clear. (FYI the param name in the original API isurl
).Fixes #4407