Apply range-filters in get when probing active-listener cache #4408

jmwski · 2021-02-03T19:02:45Z

No description provided.

changeset-bot · 2021-02-03T19:02:47Z

🦋 Changeset detected

Latest commit: 4e8e453

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@firebase/database	Patch
firebase	Patch
@firebase/rules-unit-testing	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2021-02-03T19:22:04Z

Binary Size Report

Affected SDKs

`@firebase/database`

Type	Base (`40a702e`)	Head (`daca20a`)	Diff
browser	276 kB	277 kB	+1.18 kB (+0.4%)
esm2017	243 kB	244 kB	+1.44 kB (+0.6%)
main	279 kB	280 kB	+1.18 kB (+0.4%)
module	276 kB	277 kB	+1.18 kB (+0.4%)

`@firebase/database-exp`

Type	Base (`40a702e`)	Head (`daca20a`)	Diff
browser	277 kB	278 kB	+1.18 kB (+0.4%)
esm2017	241 kB	242 kB	+1.44 kB (+0.6%)
main	279 kB	280 kB	+1.18 kB (+0.4%)
module	277 kB	278 kB	+1.18 kB (+0.4%)

firebase

Type Base (40a702e) Head (daca20a) Diff

firebase-database.js 195 kB 194 kB -644 B (-0.3%)

firebase.js 856 kB 855 kB -644 B (-0.1%)

Test Logs

Base (40a702eb): https://github.com/firebase/firebase-js-sdk/actions/runs/549677278
Head (daca20ad): https://github.com/firebase/firebase-js-sdk/actions/runs/553083441

jmwski · 2021-02-03T19:28:15Z

packages/database/src/core/SyncTree.ts

+        query.path
+      );
+      let view: View = syncPoint.getView(query, writesCache, serverCache, true);
+      return view.getCompleteServerCache(query.path);


@schmidt-sebastian This seems to apply the filters for startAfter/endBefore, but it erroneously returns null for this test: https://github.com/firebase/firebase-js-sdk/blob/master/packages/database/test/query.test.ts#L3159-L3179.

Can you have a look at this? I'm trying to figure out why this is happening but not making much progress.

google-oss-bot · 2021-02-03T19:30:19Z

Size Analysis Report

Affected Products

No changes between base commit (40a702e) and head commit (daca20a).

Test Logs

packages/database/src/core/SyncPoint.ts

packages/database/src/core/SyncTree.ts

schmidt-sebastian · 2021-02-05T20:35:27Z

packages/database/test/query.test.ts

+    const childOne = node.push();
+    const childTwo = node.push();
+    await childOne.set(1);
+    await childTwo.set(2);


Do the tests still pass if you don't await here? I would like to confirm that we correctly apply local writes.

They do still pass.

schmidt-sebastian

This needs a changelog entry in response to https://firebase.google.com/support/release-notes/js#realtime-database_5

schmidt-sebastian · 2021-02-08T22:21:47Z

packages/database/src/core/SyncTree.ts

+  getServerValue(query: Query): Node | null {
+    const path = query.path;
+    let serverCache: Node | null = null;
+    let foundAncestorDefaultView = false;


foundAncestorDefaultView is not used and can be removed.

packages/database/test/query.test.ts

Co-authored-by: Sebastian Schmidt <[email protected]>

jmwski · 2021-02-09T01:38:39Z

@Feiyang1 for code-owner review.

…se-js-sdk into jw/fix-get-again

schmidt-sebastian

Additional tests LGTM. Thanks for all the extra effort!

.changeset/small-icons-allow.md

packages/database/src/core/SyncPoint.ts

packages/database/src/core/view/View.ts

Co-authored-by: Sebastian Schmidt <[email protected]>

…se-js-sdk into jw/fix-get-again

Apply range-filters in get when probing active-listener cache

6aeb07b

jmwski requested review from jsdt and schmidt-sebastian as code owners February 3, 2021 19:02

jmwski assigned schmidt-sebastian Feb 3, 2021

jmwski commented Feb 3, 2021

View reviewed changes

jmwski added 2 commits February 3, 2021 12:57

Fix get() _again_

16670a9

cleanup

fa3e3eb

schmidt-sebastian reviewed Feb 5, 2021

View reviewed changes

schmidt-sebastian assigned jmwski and unassigned schmidt-sebastian Feb 5, 2021

lint error and test feedback

41e85b1

jmwski assigned schmidt-sebastian and unassigned jmwski Feb 8, 2021

increase test coverage

1df2eaf

schmidt-sebastian reviewed Feb 8, 2021

View reviewed changes

jmwski added 5 commits February 8, 2021 14:44

Remove unused var

5f5c4ce

chnageset

da3b897

Merge branch 'master' into jw/fix-get-again

4637c09

fix changeset

3d3b895

Fix misunderstanding of suggested fix.

c3b1688

schmidt-sebastian reviewed Feb 8, 2021

View reviewed changes

packages/database/test/query.test.ts Show resolved Hide resolved

packages/database/test/query.test.ts Show resolved Hide resolved

schmidt-sebastian assigned jmwski and unassigned schmidt-sebastian Feb 8, 2021

jmwski and others added 3 commits February 8, 2021 15:07

Update packages/database/test/query.test.ts

56a8f81

Co-authored-by: Sebastian Schmidt <[email protected]>

Update packages/database/test/query.test.ts

b00a15f

Co-authored-by: Sebastian Schmidt <[email protected]>

Merge branch 'master' into jw/fix-get-again

4de2801

jmwski assigned Feiyang1 Feb 9, 2021

jmwski removed their assignment Feb 9, 2021

jmwski assigned schmidt-sebastian and unassigned Feiyang1 Feb 9, 2021

jmwski added 2 commits February 9, 2021 12:18

add more tests for get

2976110

Merge branch 'jw/fix-get-again' of https://github.com/firebase/fireba…

31a2803

…se-js-sdk into jw/fix-get-again

schmidt-sebastian approved these changes Feb 9, 2021

View reviewed changes

.changeset/small-icons-allow.md Outdated Show resolved Hide resolved

packages/database/src/core/SyncPoint.ts Outdated Show resolved Hide resolved

packages/database/src/core/view/View.ts Outdated Show resolved Hide resolved

schmidt-sebastian assigned jmwski and unassigned schmidt-sebastian Feb 9, 2021

jmwski and others added 5 commits February 9, 2021 14:45

Update .changeset/small-icons-allow.md

2b14499

Co-authored-by: Sebastian Schmidt <[email protected]>

Update packages/database/src/core/view/View.ts

c4ba14a

Co-authored-by: Sebastian Schmidt <[email protected]>

Update packages/database/src/core/SyncPoint.ts

6c2d17e

Co-authored-by: Sebastian Schmidt <[email protected]>

Fix get with pending writes case

f8a8369

Merge branch 'jw/fix-get-again' of https://github.com/firebase/fireba…

4e8e453

…se-js-sdk into jw/fix-get-again

jmwski merged commit 318af54 into master Feb 10, 2021

jmwski deleted the jw/fix-get-again branch February 10, 2021 02:15

google-oss-bot mentioned this pull request Feb 10, 2021

Version Packages #4448

Merged

firebase locked and limited conversation to collaborators Mar 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apply range-filters in get when probing active-listener cache #4408

Apply range-filters in get when probing active-listener cache #4408

jmwski commented Feb 3, 2021

changeset-bot bot commented Feb 3, 2021 •

edited

Loading

google-oss-bot commented Feb 3, 2021 •

edited

Loading

`@firebase/database`

`@firebase/database-exp`

`firebase`

jmwski Feb 3, 2021

google-oss-bot commented Feb 3, 2021 •

edited

Loading

Affected Products

Test Logs

schmidt-sebastian Feb 5, 2021

jmwski Feb 8, 2021

schmidt-sebastian left a comment

schmidt-sebastian Feb 8, 2021

jmwski commented Feb 9, 2021

schmidt-sebastian left a comment

Apply range-filters in get when probing active-listener cache #4408

Apply range-filters in get when probing active-listener cache #4408

Conversation

jmwski commented Feb 3, 2021

changeset-bot bot commented Feb 3, 2021 • edited Loading

🦋 Changeset detected

google-oss-bot commented Feb 3, 2021 • edited Loading

Binary Size Report

Affected SDKs

@firebase/database

@firebase/database-exp

firebase

Test Logs

jmwski Feb 3, 2021

Choose a reason for hiding this comment

google-oss-bot commented Feb 3, 2021 • edited Loading

Size Analysis Report

Affected Products

Test Logs

schmidt-sebastian Feb 5, 2021

Choose a reason for hiding this comment

jmwski Feb 8, 2021

Choose a reason for hiding this comment

schmidt-sebastian left a comment

Choose a reason for hiding this comment

schmidt-sebastian Feb 8, 2021

Choose a reason for hiding this comment

jmwski commented Feb 9, 2021

schmidt-sebastian left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Feb 3, 2021 •

edited

Loading

google-oss-bot commented Feb 3, 2021 •

edited

Loading

`@firebase/database`

`@firebase/database-exp`

`firebase`

google-oss-bot commented Feb 3, 2021 •

edited

Loading