Skip to content

Expose only public types from Auth exp #4398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Expose only public types from Auth exp #4398

merged 2 commits into from
Feb 3, 2021

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Feb 3, 2021

  1. Create a rollup d.ts file that only contains public types. Fixes alpha: Cannot find namespace 'gapi'. #4392
  2. Remove unnecessary @internal annotations. @internal is only needed to hide members of public API, e.g. to hide internal methods of a public class. If something is not part of the API, there is no need to annotate it.

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2021

⚠️ No Changeset found

Latest commit: 36219c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Feiyang1 Feiyang1 merged commit 78e26b3 into master Feb 3, 2021
@Feiyang1 Feiyang1 deleted the fei-auth-exp-types branch February 3, 2021 19:20
@firebase firebase locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alpha: Cannot find namespace 'gapi'.
2 participants