Skip to content

Export public types from auth-exp #4362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Export public types from auth-exp #4362

merged 2 commits into from
Jan 29, 2021

Conversation

hsubox76
Copy link
Contributor

Export public types from auth-exp main package entry point.

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2021

⚠️ No Changeset found

Latest commit: 38d269e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines 28 to 34
// Classes
ActionCodeURL,
AuthCredential,
EmailAuthProvider,
MultiFactorResolver,
OAuthCredential,
PhoneAuthCredential,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't export classes as types because it allows people to new them. Should they be interface instead? If we want to export the actual classes, the implementation should be exported instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like MultiFactorResolver can be an interface. The other ones are real classes that are already exported, so I am removing those type exports. They could maybe be removed from auth-types-exp/index.d.ts entirely but that's where the documentation comments are and the code class is linking to them using @inheritDoc.

@hsubox76 hsubox76 merged commit b574873 into master Jan 29, 2021
@hsubox76 hsubox76 deleted the ch-auth-exp-types branch January 29, 2021 17:33
@firebase firebase locked and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants