Skip to content

Decode UTF-8 in ID Token. Fix #4174. #4357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Decode UTF-8 in ID Token. Fix #4174. #4357

merged 2 commits into from
Jan 28, 2021

Conversation

yuchenshi
Copy link
Member

Fix #4174.

Changes to the SDK is already reviewed internally so feel free to rubber stamp. I fixed the tests while I'm at it (port conflict with Emulator UI).

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2021

🦋 Changeset detected

Latest commit: 2fb812f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@firebase/auth Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 28, 2021

Size Analysis Report

Affected Products

No changes between base commit (5380e00) and head commit (dec5303).

@yuchenshi yuchenshi merged commit 73bb561 into master Jan 28, 2021
@yuchenshi yuchenshi deleted the ys/auth-jwt-utf-8 branch January 28, 2021 19:32
@google-oss-bot google-oss-bot mentioned this pull request Feb 2, 2021
@firebase firebase locked and limited conversation to collaborators Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getIdTokenResult is not handling properly utf-8 claims due base64 encoding compatibility issue with browsers
3 participants