Skip to content

Add installations import to analytics-exp #4341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Add installations import to analytics-exp #4341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11edad8
Add installations import
hsubox76 Jan 25, 2021
b4a5667
Fix build configs
hsubox76 Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions packages-exp/analytics-exp/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,8 @@
import json from '@rollup/plugin-json';
import typescriptPlugin from 'rollup-plugin-typescript2';
import typescript from 'typescript';
import pkg from './package.json';
import { es2017BuildsNoPlugin, es5BuildsNoPlugin } from './rollup.shared';

const deps = Object.keys(
Object.assign({}, pkg.peerDependencies, pkg.dependencies)
);

/**
* ES5 Builds
*/
Expand All @@ -37,10 +32,7 @@ const es5BuildPlugins = [

const es5Builds = es5BuildsNoPlugin.map(build => ({
...build,
plugins: es5BuildPlugins,
treeshake: {
moduleSideEffects: false
}
plugins: es5BuildPlugins
}));

/**
Expand All @@ -60,10 +52,7 @@ const es2017BuildPlugins = [

const es2017Builds = es2017BuildsNoPlugin.map(build => ({
...build,
plugins: es2017BuildPlugins,
treeshake: {
moduleSideEffects: false
}
plugins: es2017BuildPlugins
}));

export default [...es5Builds, ...es2017Builds];
4 changes: 2 additions & 2 deletions packages-exp/analytics-exp/rollup.config.release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const es5Builds = es5BuildsNoPlugin.map(build => ({
...build,
plugins: es5BuildPlugins,
treeshake: {
moduleSideEffects: false
moduleSideEffects: id => id === '@firebase/installations'
}
}));

Expand Down Expand Up @@ -66,7 +66,7 @@ const es2017Builds = es2017BuildsNoPlugin.map(build => ({
...build,
plugins: es2017BuildPlugins,
treeshake: {
moduleSideEffects: false
moduleSideEffects: id => id === '@firebase/installations'
}
}));

Expand Down
1 change: 1 addition & 0 deletions packages-exp/analytics-exp/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import {
Item,
Promotion
} from '@firebase/analytics-types-exp';
import '@firebase/installations-exp';

declare global {
interface Window {
Expand Down