-
Notifications
You must be signed in to change notification settings - Fork 927
Add url param to getStorage and update public Metadata types #4340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Analysis Report |
*/ | ||
updated: string; | ||
bucket?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is not used for metadata that is returned from the backed, it should no longer be optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this guaranteed to always be returned from the backend? Is there a list of metadata properties that always come back from the backend?
Oh I guess I could just always go off the previous documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is a list here: https://cloud.google.com/storage/docs/json_api/v1/objects#resource
Add url option to
getStorage()
(should have been there, existed in previous API, factory is set up to accommodate it).Split public
Metadata
type into 3, as it was in the previous APISettableMetadata
- can be set usingupdateMetadata()
UploadMetadata
- can be set as part of an upload of a storage object (seems to be same asSettableMetadata
but with additionalmd5Hash
).FullMetadata
- metadata returned from server after various operations