Skip to content

Add url param to getStorage and update public Metadata types #4340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 26, 2021

Conversation

hsubox76
Copy link
Contributor

Add url option to getStorage() (should have been there, existed in previous API, factory is set up to accommodate it).

Split public Metadata type into 3, as it was in the previous API

  • SettableMetadata - can be set using updateMetadata()
  • UploadMetadata - can be set as part of an upload of a storage object (seems to be same as SettableMetadata but with additional md5Hash).
  • FullMetadata - metadata returned from server after various operations

@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2021

⚠️ No Changeset found

Latest commit: 6801043

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 25, 2021

Size Analysis Report

Affected Products

No changes between base commit (4190745) and head commit (dfffabc).

*/
updated: string;
bucket?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is not used for metadata that is returned from the backed, it should no longer be optional.

Copy link
Contributor Author

@hsubox76 hsubox76 Jan 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this guaranteed to always be returned from the backend? Is there a list of metadata properties that always come back from the backend?

Oh I guess I could just always go off the previous documentation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsubox76 hsubox76 merged commit b28aff2 into master Jan 26, 2021
@hsubox76 hsubox76 deleted the ch-storage-exp-fix-3 branch January 26, 2021 00:26
@firebase firebase locked and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants