-
Notifications
You must be signed in to change notification settings - Fork 926
Adjust to new size analysis implementation. #4300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Analysis Report |
@Feiyang1 The original size report are missing. It looks like the that job (Health Metrics / Binary Size (pull_request)) actually failed with:
But it is still marked as success on CI. I recalled that you once had some fix for a similar issue. Is that in? |
Yes, #4010. Is it a case this PR doesn't cover? @yifanyang |
@@ -77,7 +77,7 @@ export function upload( | |||
console.log(`Response status code: ${response.statusCode}`); | |||
response.on('data', console.log); | |||
response.on('end', () => { | |||
if (response.statusCode !== 202) { | |||
if (response.statusCode !== 200 && response.statusCode !== 202) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we still accept 202?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for now. The api for the old size report still returns 202. I'm planning to migrate it to 200 as well. I'll remove the 202 here (and a few other places in android repo) when that happens.
Got it. We can probably investigate on that unhandled reject later. I'm merging this one now to unblock other developers. |
The metrics backend for size analysis is revamped. We should be able to see some UI improvements (a demo report) in the size analysis report.
The new implementation returns 200 (OK) instead of 202 (ACCEPTED). Therefor the script should also treat 200 as success.