Fix issues in the exp release script #4293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang1
requested review from
avolkovi,
hiranya911,
hsubox76,
sam-gc and
yuchenshi
as code owners
|
Size Analysis Report |
hsubox76
reviewed
Jan 15, 2021
| "dev": "rollup -c -w", | ||
| "test": "run-p test:karma type-check lint ", | ||
| "test:integration": "run-p test:karma type-check lint && cd ../../integration/messaging && npm run-script test", | ||
| "test:ci": "node ../../scripts/run_tests_in_ci.js", | ||
| "test:karma": "karma start --single-run", | ||
| "test:debug": "karma start --browsers=Chrome --auto-watch", | ||
| "prepare": "yarn build", | ||
| "prepare": "yarn build:release", |
There was a problem hiding this comment.
Does this conflict with removing all prepares in the other PR?
There was a problem hiding this comment.
yeah, I will resolve the conflict in the other PR. It is an appropriate fix in the context of this PR.
hsubox76
approved these changes
Jan 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publishing to npm still hangs occasionally. I'm going to make a followup PR to remove the prepare script from all projects.