Skip to content

Remove analytics prefix from settings() #4286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 15, 2021
Merged

Remove analytics prefix from settings() #4286

merged 4 commits into from
Jan 15, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Jan 13, 2021 •
edited
Loading

(This PR was originally "add initializeAnalytics()")

Remove analytics prefix from settings() method.

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: fb20dae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Feiyang1
Feiyang1 reviewed Jan 13, 2021
View reviewed changes
packages-exp/analytics-exp/src/api.ts Outdated
@@ -57,15 +58,38 @@ declare module '@firebase/component' {
}
}

/**
* Firebase Analytics initialization function that allows custom
* settings. Can be called at most once. If no custom settings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it throw if it's called more than once, or after getAnalytics() is called for the same app instance?

Also, settings() manages a global state that should not change from instance to instance. Does it even make sense to call it as part of initializeAnalytics() which is creating an instance. It seems to make more sense to let people call settings() manually once before calling any getAnalytics(). So perhaps we don't need initializeAnalytics() ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed PR to just remove analytics prefix from analyticsSettings.

@Feiyang1 Feiyang1 assigned hsubox76 and unassigned Feiyang1 Jan 13, 2021
@hsubox76 hsubox76 changed the title Add initializeAnalytics() Remove analytics prefix from settings() Jan 14, 2021
@hsubox76 hsubox76 assigned Feiyang1 and unassigned hsubox76 Jan 14, 2021
@Feiyang1 Feiyang1 assigned hsubox76 and unassigned Feiyang1 Jan 15, 2021
@hsubox76 hsubox76 merged commit 941467e into ch-analytics-exp Jan 15, 2021
@hsubox76 hsubox76 deleted the ch-analytics-init branch January 21, 2021 20:27
@firebase firebase locked and limited conversation to collaborators Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsubox76 @Feiyang1