Skip to content

Allow storage processes to exit before timeout in node #4266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theprojectsomething
Copy link

Currently the storage API is unsupported for node (see #18). This means storage rules are unavailable from a node environment (even using the admin interface). This can be resolved with some very minor updates to the storage package (for later versions of node at least):

  • Resolve any ongoing processes (in this case uncleared timeouts) to allow node to exit as expected once a script is complete
  • Include an XHR polyfill (via dynamic import or node-specific build) ... successfully tested with xmlhttprequest-ssl

This PR does half the work. It clears a timeout that keeps a storage process running for a minimum 10mins in node (waiting on the 600,000ms function timeout to complete). This fix should also be useful in other environments as it clears up resources.

This PR doesn't include the XHR polyfill as that seems like a fairly opinionated piece of work. The firebase/app package actually already includes an XHR polyfill (incompatible here), but gives some direction for implementation.

That said, given the current changes in place, users needing storage functionality in node can easily install the XHR module in their project directly and patch the compiled storage script @firebase/storage/dist/index.cjs.js for a workable (if not full) level of functionality.

clearing timeouts frees resources (and allows for node processes to exit)
@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2021

⚠️ No Changeset found

Latest commit: c917387

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remorses
Copy link

Hey @schmidt-sebastian can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants