Skip to content

Update outdated error message to include '!=' #4262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 5, 2021
Merged

Update outdated error message to include '!=' #4262

merged 3 commits into from
Jan 5, 2021

Conversation

thebrianchen
Copy link

Fixes #4253.

@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 48d1fc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@firebase/firestore Minor
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

schmidt-sebastian
schmidt-sebastian reviewed Jan 5, 2021
View reviewed changes
packages/firestore/src/lite/query.ts Outdated
@@ -795,7 +795,7 @@ function validateNewFilter(query: InternalQuery, filter: Filter): void {
throw new FirestoreError(
Code.INVALID_ARGUMENT,
'Invalid query. All where filters with an inequality' +
' (<, <=, >, or >=) must be on the same field. But you have' +
' (<, <=, !=, >, or >=) must be on the same field. But you have' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this also needs to include in and not-in, which is rejected by the backend as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Added.

@schmidt-sebastian schmidt-sebastian removed their assignment Jan 5, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 5, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (487f8e1) and head commit (e424316).

Test Logs

@thebrianchen thebrianchen merged commit 6069b1d into master Jan 5, 2021
@thebrianchen thebrianchen deleted the bc/update-inequality-error branch January 5, 2021 21:17
@google-oss-bot google-oss-bot mentioned this pull request Jan 5, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outdated Error Message
3 participants
@thebrianchen @google-oss-bot @schmidt-sebastian