Fix multiple database instances when using emulator #4247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 30e6996 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
schmidt-sebastian
approved these changes
Dec 29, 2020
Comment on lines
+175
to
+177
| expect(() => { | ||
| defaultApp.database('http://foo.bar.com/'); | ||
| }).to.throw(/Database initialized multiple times/i); |
There was a problem hiding this comment.
:( That this is banned makes me sad. But obviously unrelated to the PR.
|
@samtstern thanks for adding this in - any ideas when it'll be released with regards to the |
|
@rhodgkins since this is just a patch release once the JS SDK ships (which happens about once a week) the Admin SDK should pick it up automatically as a dependency on a fresh npm install. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Fixes #3681
Testing
Added new unit test
API Changes
None