Backport Android updateTransform changes #4225

thebrianchen · 2020-12-18T01:33:50Z

After porting update transforms to Android, I found some changes that needed to be ported back. I also replaced usages of TransformMutation.

changeset-bot · 2020-12-18T01:33:53Z

⚠️ No Changeset found

Latest commit: 8321655

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2020-12-18T01:35:38Z

Changeset File Check ⚠️

Changeset formatting error in following file:

Package "@firebase/messaging-exp" must depend on the current version of "@firebase/util": "0.3.4" vs "0.3.2"
{ ValidationError: Some errors occurred when validating the changesets config:
The package "@firebase/messaging-exp" depends on the ignored package "@firebase/app-exp", but "@firebase/messaging-exp" is not being ignored. Please add "@firebase/messaging-exp" to the `ignore` option.
The package "@firebase/messaging-exp" depends on the ignored package "@firebase/app-types-exp", but "@firebase/messaging-exp" is not being ignored. Please add "@firebase/messaging-exp" to the `ignore` option.
The package "@firebase/messaging-exp" depends on the ignored package "@firebase/installations-exp", but "@firebase/messaging-exp" is not being ignored. Please add "@firebase/messaging-exp" to the `ignore` option.
  name: 'ValidationError',
  _error:
   Error
       at new ExtendableError (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/extendable-error/bld/index.js:23:24)
       at new ValidationError (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/errors/dist/errors.cjs.dev.js:16:1)
       at parse (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/node_modules/@changesets/config/dist/config.cjs.dev.js:196:11)
       at Object.read (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/node_modules/@changesets/config/dist/config.cjs.dev.js:84:10) }

google-oss-bot · 2020-12-18T01:55:05Z

Size Analysis Report

Affected Products

`@firebase/messaging-exp`

`deleteToken`

Size

Type	Base (`1a8cb40`)	Head (`d1917c2`)	Diff
size	?	7.52 kB	? (?)
size_with_ext_deps	?	24.9 kB	? (?)

Dependencies

Type	Base (`1a8cb40`)	Head (`d1917c2`)	Diff
functions	?	Click to show 20 deps `arrayToBase64` `checkTokenDetails` `dbGet` `dbRemove` `dbSet` `deleteToken` `deleteTokenInternal` `extractAppConfig` `getDbPromise` `getEndpoint` `getHeaders` `getKey` `getMissingValueError` `isSWControllerSupported` `isSupported` `isWindowControllerSupported` `migrateOldDatabase` `registerDefaultSw` `registerMessaging` `requestDeleteToken`	?
classes	?	`MessagingService`	?
variables	?	Click to show 14 deps `DATABASE_NAME` `DATABASE_VERSION` `DEFAULT_SW_PATH` `DEFAULT_SW_SCOPE` `ENDPOINT` `ERROR_FACTORY` `ERROR_MAP` `MessageType` `OBJECT_STORE_NAME` `OLD_DB_NAME` `OLD_DB_VERSION` `OLD_OBJECT_STORE_NAME` `dbPromise` `messagingFactory`	?

External Dependencies

Module	Base (`1a8cb40`)	Head (`d1917c2`)	Diff
`@firebase/util`	?	`ErrorFactory`	?
`idb`	?	`deleteDb` `openDb`	?
`@firebase/installations-exp`	?	`getToken`	?
`@firebase/app-exp`	?	`_registerComponent`	?
`@firebase/component`	?	`Component`	?

`getMessaging`

Size

Type	Base (`1a8cb40`)	Head (`d1917c2`)	Diff
size	?	3.67 kB	? (?)
size_with_ext_deps	?	21.0 kB	? (?)

Dependencies

Type	Base (`1a8cb40`)	Head (`d1917c2`)	Diff
functions	?	Click to show 7 deps `extractAppConfig` `getMessaging` `getMissingValueError` `isSWControllerSupported` `isSupported` `isWindowControllerSupported` `registerMessaging`	?
classes	?	`MessagingService`	?
variables	?	`ERROR_FACTORY` `ERROR_MAP` `MessageType` `messagingFactory`	?

External Dependencies

Module	Base (`1a8cb40`)	Head (`d1917c2`)	Diff
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/app-exp`	?	`_getProvider` `_registerComponent`	?
`@firebase/component`	?	`Component`	?

`getToken`

Size

Type	Base (`1a8cb40`)	Head (`d1917c2`)	Diff
size	?	12.0 kB	? (?)
size_with_ext_deps	?	29.5 kB	? (?)

Dependencies

Type	Base (`1a8cb40`)	Head (`d1917c2`)	Diff
functions	?	Click to show 39 deps `arrayToBase64` `base64ToArray` `checkTokenDetails` `dbGet` `dbRemove` `dbSet` `deleteTokenInternal` `externalizePayload` `extractAppConfig` `getBody` `getDbPromise` `getEndpoint` `getEventType` `getHeaders` `getKey` `getMissingValueError` `getNewToken` `getPushSubscription` `getToken` `getTokenInternal` `isConsoleMessage` `isSWControllerSupported` `isSupported` `isTokenValid` `isWindowControllerSupported` `logToScion` `messageEventListener` `migrateOldDatabase` `propagateDataPayload` `propagateFcmOptions` `propagateNotificationPayload` `registerDefaultSw` `registerMessaging` `requestDeleteToken` `requestGetToken` `requestUpdateToken` `updateSwReg` `updateToken` `updateVapidKey`	?
classes	?	`MessagingService`	?
variables	?	Click to show 20 deps `CONSOLE_CAMPAIGN_ANALYTICS_ENABLED` `CONSOLE_CAMPAIGN_ID` `CONSOLE_CAMPAIGN_NAME` `CONSOLE_CAMPAIGN_TIME` `DATABASE_NAME` `DATABASE_VERSION` `DEFAULT_SW_PATH` `DEFAULT_SW_SCOPE` `DEFAULT_VAPID_KEY` `ENDPOINT` `ERROR_FACTORY` `ERROR_MAP` `MessageType` `OBJECT_STORE_NAME` `OLD_DB_NAME` `OLD_DB_VERSION` `OLD_OBJECT_STORE_NAME` `TOKEN_EXPIRATION_MS` `dbPromise` `messagingFactory`	?

External Dependencies

Module	Base (`1a8cb40`)	Head (`d1917c2`)	Diff
`@firebase/util`	?	`ErrorFactory`	?
`idb`	?	`deleteDb` `openDb`	?
`@firebase/installations-exp`	?	`getToken`	?
`@firebase/app-exp`	?	`_registerComponent`	?
`@firebase/component`	?	`Component`	?

`onMessage`

Size

Type	Base (`1a8cb40`)	Head (`d1917c2`)	Diff
size	?	5.19 kB	? (?)
size_with_ext_deps	?	22.6 kB	? (?)

Dependencies

Type	Base (`1a8cb40`)	Head (`d1917c2`)	Diff
functions	?	Click to show 15 deps `externalizePayload` `extractAppConfig` `getEventType` `getMissingValueError` `isConsoleMessage` `isSWControllerSupported` `isSupported` `isWindowControllerSupported` `logToScion` `messageEventListener` `onMessage` `propagateDataPayload` `propagateFcmOptions` `propagateNotificationPayload` `registerMessaging`	?
classes	?	`MessagingService`	?
variables	?	Click to show 8 deps `CONSOLE_CAMPAIGN_ANALYTICS_ENABLED` `CONSOLE_CAMPAIGN_ID` `CONSOLE_CAMPAIGN_NAME` `CONSOLE_CAMPAIGN_TIME` `ERROR_FACTORY` `ERROR_MAP` `MessageType` `messagingFactory`	?

External Dependencies

Module	Base (`1a8cb40`)	Head (`d1917c2`)	Diff
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/app-exp`	?	`_registerComponent`	?
`@firebase/component`	?	`Component`	?

Test Logs

Base (1a8cb40a): https://github.com/firebase/firebase-js-sdk/actions/runs/429339883
Head (d1917c20): https://github.com/firebase/firebase-js-sdk/actions/runs/436821348

packages/firestore/src/model/mutation.ts

wilhuff · 2020-12-21T18:44:51Z

packages/firestore/src/model/mutation.ts

@@ -689,14 +675,6 @@ function localTransformResults(
      previousValue = maybeDoc.field(fieldTransform.field);
    }

-    if (previousValue === null && baseDoc instanceof Document) {


Why is this logic no longer needed? This seems pretty critical. Or is it handled elsewhere now?

My understanding is that this if-statement checks for the edge case where a PatchMutation clears the values of a nested map before the TransformMutation is applied. With the addition of updateTransforms, field transformation are encoded directly on the Patch or Set Mutation, rather than in a separate TransformMutation. This means that we won't bump into this edge case anymore since the update and fieldTransform are on the same mutation and thus applied at the same time.

I've also removed the now obsolete server timestamp test that tested this edge case.

Co-authored-by: Gil <[email protected]>

wilhuff

LGTM

Backport Android updateTransform changes

9ce95c7

thebrianchen added the api: firestore label Dec 18, 2020

thebrianchen self-assigned this Dec 18, 2020

thebrianchen requested a review from wilhuff December 21, 2020 18:19

thebrianchen assigned wilhuff and unassigned thebrianchen Dec 21, 2020

wilhuff reviewed Dec 21, 2020

View reviewed changes

wilhuff assigned thebrianchen and unassigned wilhuff Dec 21, 2020

Brian Chen and others added 2 commits December 21, 2020 10:47

Update packages/firestore/src/model/mutation.ts

ac590f7

Co-authored-by: Gil <[email protected]>

remove outdated test

95974e2

thebrianchen requested a review from wilhuff December 21, 2020 22:15

thebrianchen assigned wilhuff and unassigned thebrianchen Dec 21, 2020

lint: remove unused function

8321655

wilhuff approved these changes Jan 7, 2021

View reviewed changes

wilhuff assigned thebrianchen and unassigned wilhuff Jan 7, 2021

thebrianchen merged commit db7dae7 into master Jan 7, 2021

thebrianchen deleted the bc/fix-update-transforms branch January 7, 2021 04:16

thebrianchen mentioned this pull request Jan 14, 2021

Replace usage of transforms with update transforms firebase/firebase-ios-sdk#7276

Merged

firebase locked and limited conversation to collaborators Feb 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Backport Android updateTransform changes #4225

Backport Android updateTransform changes #4225

Uh oh!

thebrianchen commented Dec 18, 2020 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 18, 2020 •

edited

Loading

Uh oh!

github-actions bot commented Dec 18, 2020 •

edited

Loading

Uh oh!

google-oss-bot commented Dec 18, 2020 •

edited

Loading

`deleteToken`

Size

Dependencies

External Dependencies

`getMessaging`

Size

Dependencies

External Dependencies

`getToken`

Size

Dependencies

External Dependencies

`onMessage`

Size

Dependencies

External Dependencies

Uh oh!

Uh oh!

wilhuff Dec 21, 2020

Uh oh!

thebrianchen Dec 21, 2020 •

edited

Loading

Uh oh!

wilhuff left a comment

Uh oh!

Uh oh!

Backport Android updateTransform changes #4225

Backport Android updateTransform changes #4225

Uh oh!

Conversation

thebrianchen commented Dec 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Dec 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changeset File Check ⚠️

Uh oh!

google-oss-bot commented Dec 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report

Affected Products

@firebase/messaging-exp

deleteToken

Size

Dependencies

External Dependencies

getMessaging

Size

Dependencies

External Dependencies

getToken

Size

Dependencies

External Dependencies

onMessage

Size

Dependencies

External Dependencies

Test Logs

Uh oh!

Uh oh!

wilhuff Dec 21, 2020

Choose a reason for hiding this comment

Uh oh!

thebrianchen Dec 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wilhuff left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thebrianchen commented Dec 18, 2020 •

edited

Loading

changeset-bot bot commented Dec 18, 2020 •

edited

Loading

github-actions bot commented Dec 18, 2020 •

edited

Loading

google-oss-bot commented Dec 18, 2020 •

edited

Loading

`@firebase/messaging-exp`

`deleteToken`

`getMessaging`

`getToken`

`onMessage`

thebrianchen Dec 21, 2020 •

edited

Loading