Skip to content

Fix auth state change issues after refresh #4200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2020
Merged

Fix auth state change issues after refresh #4200

merged 1 commit into from
Dec 11, 2020

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Dec 11, 2020

No description provided.

@sam-gc sam-gc requested a review from hsubox76 December 11, 2020 21:31
@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2020

⚠️ No Changeset found

Latest commit: 48a669e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

@firebase/auth-exp

  • ActionCodeURL

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.5 kB 29.5 kB -13 B (-0.0%)
    size_with_ext_deps 40.0 kB 40.0 kB -13 B (-0.0%)

  • AuthCredential

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 28.7 kB 28.7 kB -13 B (-0.0%)
    size_with_ext_deps 39.2 kB 39.2 kB -13 B (-0.0%)

  • EmailAuthCredential

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 30.5 kB 30.5 kB -13 B (-0.0%)
    size_with_ext_deps 41.0 kB 41.0 kB -13 B (-0.0%)

  • EmailAuthProvider

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 31.8 kB 31.8 kB -13 B (-0.0%)
    size_with_ext_deps 42.4 kB 42.3 kB -13 B (-0.0%)

  • FacebookAuthProvider

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 32.3 kB 32.3 kB -13 B (-0.0%)
    size_with_ext_deps 42.8 kB 42.8 kB -13 B (-0.0%)

  • GithubAuthProvider

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 32.3 kB 32.3 kB -13 B (-0.0%)
    size_with_ext_deps 42.8 kB 42.8 kB -13 B (-0.0%)

  • GoogleAuthProvider

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 32.3 kB 32.3 kB -13 B (-0.0%)
    size_with_ext_deps 42.8 kB 42.8 kB -13 B (-0.0%)

  • OAuthCredential

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 30.5 kB 30.5 kB -13 B (-0.0%)
    size_with_ext_deps 41.0 kB 41.0 kB -13 B (-0.0%)

  • OAuthProvider

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 31.7 kB 31.7 kB -13 B (-0.0%)
    size_with_ext_deps 42.2 kB 42.2 kB -13 B (-0.0%)

  • PhoneAuthCredential

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 30.5 kB 30.5 kB -13 B (-0.0%)
    size_with_ext_deps 41.0 kB 41.0 kB -13 B (-0.0%)

  • PhoneAuthProvider

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 32.1 kB 32.1 kB -13 B (-0.0%)
    size_with_ext_deps 42.6 kB 42.6 kB -13 B (-0.0%)

  • PhoneMultiFactorGenerator

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.4 kB 29.4 kB -13 B (-0.0%)
    size_with_ext_deps 39.9 kB 39.9 kB -13 B (-0.0%)

  • RecaptchaVerifier

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 34.7 kB 34.7 kB -13 B (-0.0%)
    size_with_ext_deps 45.2 kB 45.2 kB -13 B (-0.0%)

  • TwitterAuthProvider

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 32.3 kB 32.3 kB -13 B (-0.0%)
    size_with_ext_deps 42.8 kB 42.8 kB -13 B (-0.0%)

  • applyActionCode

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 28.6 kB 28.6 kB -13 B (-0.0%)
    size_with_ext_deps 39.1 kB 39.1 kB -13 B (-0.0%)

  • browserLocalPersistence

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 31.4 kB 31.4 kB -13 B (-0.0%)
    size_with_ext_deps 42.0 kB 42.0 kB -13 B (-0.0%)

  • browserPopupRedirectResolver

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 45.8 kB 45.7 kB -13 B (-0.0%)
    size_with_ext_deps 56.4 kB 56.4 kB -13 B (-0.0%)

  • browserSessionPersistence

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.1 kB 29.1 kB -13 B (-0.0%)
    size_with_ext_deps 39.6 kB 39.6 kB -13 B (-0.0%)

  • checkActionCode

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.5 kB 29.5 kB -13 B (-0.0%)
    size_with_ext_deps 40.0 kB 40.0 kB -13 B (-0.0%)

  • confirmPasswordReset

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 28.6 kB 28.6 kB -13 B (-0.0%)
    size_with_ext_deps 39.1 kB 39.1 kB -13 B (-0.0%)

  • createUserWithEmailAndPassword

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.5 kB 29.5 kB -13 B (-0.0%)
    size_with_ext_deps 40.0 kB 40.0 kB -13 B (-0.0%)

  • debugErrorMap

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 39.0 kB 39.0 kB -13 B (-0.0%)
    size_with_ext_deps 49.5 kB 49.5 kB -13 B (-0.0%)

  • deleteUser

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 28.5 kB 28.5 kB -13 B (-0.0%)
    size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)

  • fetchSignInMethodsForEmail

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 28.8 kB 28.8 kB -13 B (-0.0%)
    size_with_ext_deps 39.3 kB 39.3 kB -13 B (-0.0%)

  • getAdditionalUserInfo

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.8 kB 29.8 kB -13 B (-0.0%)
    size_with_ext_deps 40.3 kB 40.3 kB -13 B (-0.0%)

  • getAuth

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 55.9 kB 55.9 kB -13 B (-0.0%)
    size_with_ext_deps 66.7 kB 66.6 kB -13 B (-0.0%)

  • getIdToken

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 28.5 kB 28.5 kB -13 B (-0.0%)
    size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)

  • getIdTokenResult

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 28.5 kB 28.5 kB -13 B (-0.0%)
    size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)

  • getMultiFactorResolver

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 31.2 kB 31.2 kB -13 B (-0.0%)
    size_with_ext_deps 41.7 kB 41.7 kB -13 B (-0.0%)

  • getRedirectResult

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 34.1 kB 34.1 kB -13 B (-0.0%)
    size_with_ext_deps 44.6 kB 44.6 kB -13 B (-0.0%)

  • inMemoryPersistence

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 28.5 kB 28.5 kB -13 B (-0.0%)
    size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)

  • indexedDBLocalPersistence

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 35.8 kB 35.8 kB -13 B (-0.0%)
    size_with_ext_deps 46.3 kB 46.3 kB -13 B (-0.0%)

  • initializeAuth

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 28.8 kB 28.8 kB -13 B (-0.0%)
    size_with_ext_deps 39.4 kB 39.3 kB -13 B (-0.0%)

  • isSignInWithEmailLink

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.6 kB 29.6 kB -13 B (-0.0%)
    size_with_ext_deps 40.1 kB 40.1 kB -13 B (-0.0%)

  • linkWithCredential

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.5 kB 29.5 kB -13 B (-0.0%)
    size_with_ext_deps 40.0 kB 40.0 kB -13 B (-0.0%)

  • linkWithPhoneNumber

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 33.0 kB 33.0 kB -13 B (-0.0%)
    size_with_ext_deps 43.5 kB 43.5 kB -13 B (-0.0%)

  • linkWithPopup

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 37.4 kB 37.4 kB -13 B (-0.0%)
    size_with_ext_deps 47.9 kB 47.9 kB -13 B (-0.0%)

  • linkWithRedirect

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 32.4 kB 32.4 kB -13 B (-0.0%)
    size_with_ext_deps 43.0 kB 42.9 kB -13 B (-0.0%)

  • multiFactor

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 30.6 kB 30.6 kB -13 B (-0.0%)
    size_with_ext_deps 41.1 kB 41.1 kB -13 B (-0.0%)

  • onAuthStateChanged

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 28.5 kB 28.5 kB -13 B (-0.0%)
    size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)

  • onIdTokenChanged

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 28.5 kB 28.5 kB -13 B (-0.0%)
    size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)

  • parseActionCodeURL

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.5 kB 29.5 kB -13 B (-0.0%)
    size_with_ext_deps 40.0 kB 40.0 kB -13 B (-0.0%)

  • prodErrorMap

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 28.5 kB 28.5 kB -13 B (-0.0%)
    size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)

  • reauthenticateWithCredential

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 30.1 kB 30.1 kB -13 B (-0.0%)
    size_with_ext_deps 40.6 kB 40.6 kB -13 B (-0.0%)

  • reauthenticateWithPhoneNumber

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 33.6 kB 33.6 kB -13 B (-0.0%)
    size_with_ext_deps 44.1 kB 44.1 kB -13 B (-0.0%)

  • reauthenticateWithPopup

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 37.4 kB 37.4 kB -13 B (-0.0%)
    size_with_ext_deps 47.9 kB 47.9 kB -13 B (-0.0%)

  • reauthenticateWithRedirect

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 32.2 kB 32.2 kB -13 B (-0.0%)
    size_with_ext_deps 42.7 kB 42.7 kB -13 B (-0.0%)

  • reload

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 28.5 kB 28.4 kB -13 B (-0.0%)
    size_with_ext_deps 39.0 kB 38.9 kB -13 B (-0.0%)

  • sendEmailVerification

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.4 kB 29.4 kB -13 B (-0.0%)
    size_with_ext_deps 39.9 kB 39.9 kB -13 B (-0.0%)

  • sendPasswordResetEmail

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.3 kB 29.3 kB -13 B (-0.0%)
    size_with_ext_deps 39.8 kB 39.8 kB -13 B (-0.0%)

  • sendSignInLinkToEmail

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.4 kB 29.4 kB -13 B (-0.0%)
    size_with_ext_deps 39.9 kB 39.9 kB -13 B (-0.0%)

  • setPersistence

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 28.5 kB 28.5 kB -13 B (-0.0%)
    size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)

  • signInAnonymously

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.6 kB 29.6 kB -13 B (-0.0%)
    size_with_ext_deps 40.1 kB 40.1 kB -13 B (-0.0%)

  • signInWithCredential

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.9 kB 29.9 kB -13 B (-0.0%)
    size_with_ext_deps 40.4 kB 40.4 kB -13 B (-0.0%)

  • signInWithCustomToken

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.5 kB 29.5 kB -13 B (-0.0%)
    size_with_ext_deps 40.0 kB 40.0 kB -13 B (-0.0%)

  • signInWithEmailAndPassword

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 33.3 kB 33.3 kB -13 B (-0.0%)
    size_with_ext_deps 43.8 kB 43.8 kB -13 B (-0.0%)

  • signInWithEmailLink

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 33.5 kB 33.5 kB -13 B (-0.0%)
    size_with_ext_deps 44.0 kB 44.0 kB -13 B (-0.0%)

  • signInWithPhoneNumber

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 33.4 kB 33.3 kB -13 B (-0.0%)
    size_with_ext_deps 43.9 kB 43.8 kB -13 B (-0.0%)

  • signInWithPopup

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 37.4 kB 37.4 kB -13 B (-0.0%)
    size_with_ext_deps 47.9 kB 47.9 kB -13 B (-0.0%)

  • signInWithRedirect

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 31.9 kB 31.9 kB -13 B (-0.0%)
    size_with_ext_deps 42.4 kB 42.4 kB -13 B (-0.0%)

  • signOut

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 28.5 kB 28.5 kB -13 B (-0.0%)
    size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)

  • unlink

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.1 kB 29.1 kB -13 B (-0.0%)
    size_with_ext_deps 39.6 kB 39.5 kB -13 B (-0.0%)

  • updateCurrentUser

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 28.5 kB 28.5 kB -13 B (-0.0%)
    size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)

  • updateEmail

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 28.8 kB 28.8 kB -13 B (-0.0%)
    size_with_ext_deps 39.3 kB 39.3 kB -13 B (-0.0%)

  • updatePassword

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 28.8 kB 28.8 kB -13 B (-0.0%)
    size_with_ext_deps 39.3 kB 39.3 kB -13 B (-0.0%)

  • updatePhoneNumber

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.2 kB 29.2 kB -13 B (-0.0%)
    size_with_ext_deps 39.7 kB 39.7 kB -13 B (-0.0%)

  • updateProfile

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.0 kB 29.0 kB -13 B (-0.0%)
    size_with_ext_deps 39.5 kB 39.5 kB -13 B (-0.0%)

  • useDeviceLanguage

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 28.5 kB 28.5 kB -13 B (-0.0%)
    size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)

  • verifyBeforeUpdateEmail

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.4 kB 29.4 kB -13 B (-0.0%)
    size_with_ext_deps 39.9 kB 39.9 kB -13 B (-0.0%)

  • verifyPasswordResetCode

    Size

    Type Base (08aa4b1) Head (90e9116) Diff
    size 29.6 kB 29.6 kB -13 B (-0.0%)
    size_with_ext_deps 40.1 kB 40.1 kB -13 B (-0.0%)

Test Logs

@sam-gc sam-gc merged commit 04f2e24 into master Dec 11, 2020
@sam-gc sam-gc deleted the samgho/fix-state-changes branch December 11, 2020 21:53
@firebase firebase locked and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sam-gc @google-oss-bot @hsubox76