Fix refFromUrl when used with emulator #4199

schmidt-sebastian · 2020-12-11T20:19:22Z

The unit test refFromURL returns an emulated ref with useEmulator fails for me locally. I think that we don't want to enforce the host check when the database URL is emulated.

Note that this test probably passes on CI since localhost gets used as the default host.

changeset-bot · 2020-12-11T20:19:25Z

🦋 Changeset detected

Latest commit: 509257b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@firebase/database	Patch
firebase	Patch
@firebase/rules-unit-testing	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

schmidt-sebastian · 2020-12-11T20:21:21Z

FYI It looks like this may be missing from Android - https://github.com/firebase/firebase-android-sdk/blob/master/firebase-database/src/main/java/com/google/firebase/database/FirebaseDatabase.java#L208

.changeset/clever-kangaroos-hug.md

Co-authored-by: Sam Stern <[email protected]>

…js-sdk into mrschmidt/databasefix

google-oss-bot · 2020-12-15T22:11:35Z

Size Analysis Report

Affected Products

`@firebase/auth-exp`

ActionCodeURL

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.5 kB 29.5 kB -13 B (-0.0%)

size_with_ext_deps 40.0 kB 40.0 kB -13 B (-0.0%)
AuthCredential

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 28.7 kB 28.7 kB -13 B (-0.0%)

size_with_ext_deps 39.2 kB 39.2 kB -13 B (-0.0%)
EmailAuthCredential

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 30.5 kB 30.5 kB -13 B (-0.0%)

size_with_ext_deps 41.0 kB 41.0 kB -13 B (-0.0%)
EmailAuthProvider

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 31.8 kB 31.8 kB -13 B (-0.0%)

size_with_ext_deps 42.4 kB 42.3 kB -13 B (-0.0%)
FacebookAuthProvider

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 32.3 kB 32.3 kB -13 B (-0.0%)

size_with_ext_deps 42.8 kB 42.8 kB -13 B (-0.0%)
GithubAuthProvider

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 32.3 kB 32.3 kB -13 B (-0.0%)

size_with_ext_deps 42.8 kB 42.8 kB -13 B (-0.0%)
GoogleAuthProvider

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 32.3 kB 32.3 kB -13 B (-0.0%)

size_with_ext_deps 42.8 kB 42.8 kB -13 B (-0.0%)
OAuthCredential

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 30.5 kB 30.5 kB -13 B (-0.0%)

size_with_ext_deps 41.0 kB 41.0 kB -13 B (-0.0%)
OAuthProvider

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 31.7 kB 31.7 kB -13 B (-0.0%)

size_with_ext_deps 42.2 kB 42.2 kB -13 B (-0.0%)
PhoneAuthCredential

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 30.5 kB 30.5 kB -13 B (-0.0%)

size_with_ext_deps 41.0 kB 41.0 kB -13 B (-0.0%)
PhoneAuthProvider

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 32.1 kB 32.1 kB -13 B (-0.0%)

size_with_ext_deps 42.6 kB 42.6 kB -13 B (-0.0%)
PhoneMultiFactorGenerator

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.4 kB 29.4 kB -13 B (-0.0%)

size_with_ext_deps 39.9 kB 39.9 kB -13 B (-0.0%)
RecaptchaVerifier

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 34.7 kB 34.7 kB -13 B (-0.0%)

size_with_ext_deps 45.2 kB 45.2 kB -13 B (-0.0%)
TwitterAuthProvider

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 32.3 kB 32.3 kB -13 B (-0.0%)

size_with_ext_deps 42.8 kB 42.8 kB -13 B (-0.0%)
applyActionCode

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 28.6 kB 28.6 kB -13 B (-0.0%)

size_with_ext_deps 39.1 kB 39.1 kB -13 B (-0.0%)
browserLocalPersistence

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 31.4 kB 31.4 kB -13 B (-0.0%)

size_with_ext_deps 42.0 kB 42.0 kB -13 B (-0.0%)
browserPopupRedirectResolver

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 45.8 kB 45.7 kB -13 B (-0.0%)

size_with_ext_deps 56.4 kB 56.4 kB -13 B (-0.0%)
browserSessionPersistence

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.1 kB 29.1 kB -13 B (-0.0%)

size_with_ext_deps 39.6 kB 39.6 kB -13 B (-0.0%)
checkActionCode

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.5 kB 29.5 kB -13 B (-0.0%)

size_with_ext_deps 40.0 kB 40.0 kB -13 B (-0.0%)
confirmPasswordReset

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 28.6 kB 28.6 kB -13 B (-0.0%)

size_with_ext_deps 39.1 kB 39.1 kB -13 B (-0.0%)
createUserWithEmailAndPassword

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.5 kB 29.5 kB -13 B (-0.0%)

size_with_ext_deps 40.0 kB 40.0 kB -13 B (-0.0%)
debugErrorMap

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 39.0 kB 39.0 kB -13 B (-0.0%)

size_with_ext_deps 49.5 kB 49.5 kB -13 B (-0.0%)
deleteUser

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 28.5 kB 28.5 kB -13 B (-0.0%)

size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)
fetchSignInMethodsForEmail

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 28.8 kB 28.8 kB -13 B (-0.0%)

size_with_ext_deps 39.3 kB 39.3 kB -13 B (-0.0%)
getAdditionalUserInfo

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.8 kB 29.8 kB -13 B (-0.0%)

size_with_ext_deps 40.3 kB 40.3 kB -13 B (-0.0%)
getAuth

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 55.9 kB 55.9 kB -13 B (-0.0%)

size_with_ext_deps 66.7 kB 66.6 kB -13 B (-0.0%)
getIdToken

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 28.5 kB 28.5 kB -13 B (-0.0%)

size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)
getIdTokenResult

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 28.5 kB 28.5 kB -13 B (-0.0%)

size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)
getMultiFactorResolver

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 31.2 kB 31.2 kB -13 B (-0.0%)

size_with_ext_deps 41.7 kB 41.7 kB -13 B (-0.0%)
getRedirectResult

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 34.1 kB 34.1 kB -13 B (-0.0%)

size_with_ext_deps 44.6 kB 44.6 kB -13 B (-0.0%)
inMemoryPersistence

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 28.5 kB 28.5 kB -13 B (-0.0%)

size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)
indexedDBLocalPersistence

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 35.8 kB 35.8 kB -13 B (-0.0%)

size_with_ext_deps 46.3 kB 46.3 kB -13 B (-0.0%)
initializeAuth

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 28.8 kB 28.8 kB -13 B (-0.0%)

size_with_ext_deps 39.4 kB 39.3 kB -13 B (-0.0%)
isSignInWithEmailLink

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.6 kB 29.6 kB -13 B (-0.0%)

size_with_ext_deps 40.1 kB 40.1 kB -13 B (-0.0%)
linkWithCredential

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.5 kB 29.5 kB -13 B (-0.0%)

size_with_ext_deps 40.0 kB 40.0 kB -13 B (-0.0%)
linkWithPhoneNumber

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 33.0 kB 33.0 kB -13 B (-0.0%)

size_with_ext_deps 43.5 kB 43.5 kB -13 B (-0.0%)
linkWithPopup

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 37.4 kB 37.4 kB -13 B (-0.0%)

size_with_ext_deps 47.9 kB 47.9 kB -13 B (-0.0%)
linkWithRedirect

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 32.4 kB 32.4 kB -13 B (-0.0%)

size_with_ext_deps 43.0 kB 42.9 kB -13 B (-0.0%)
multiFactor

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 30.6 kB 30.6 kB -13 B (-0.0%)

size_with_ext_deps 41.1 kB 41.1 kB -13 B (-0.0%)
onAuthStateChanged

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 28.5 kB 28.5 kB -13 B (-0.0%)

size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)
onIdTokenChanged

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 28.5 kB 28.5 kB -13 B (-0.0%)

size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)
parseActionCodeURL

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.5 kB 29.5 kB -13 B (-0.0%)

size_with_ext_deps 40.0 kB 40.0 kB -13 B (-0.0%)
prodErrorMap

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 28.5 kB 28.5 kB -13 B (-0.0%)

size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)
reauthenticateWithCredential

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 30.1 kB 30.1 kB -13 B (-0.0%)

size_with_ext_deps 40.6 kB 40.6 kB -13 B (-0.0%)
reauthenticateWithPhoneNumber

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 33.6 kB 33.6 kB -13 B (-0.0%)

size_with_ext_deps 44.1 kB 44.1 kB -13 B (-0.0%)
reauthenticateWithPopup

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 37.4 kB 37.4 kB -13 B (-0.0%)

size_with_ext_deps 47.9 kB 47.9 kB -13 B (-0.0%)
reauthenticateWithRedirect

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 32.2 kB 32.2 kB -13 B (-0.0%)

size_with_ext_deps 42.7 kB 42.7 kB -13 B (-0.0%)
reload

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 28.5 kB 28.4 kB -13 B (-0.0%)

size_with_ext_deps 39.0 kB 38.9 kB -13 B (-0.0%)
sendEmailVerification

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.4 kB 29.4 kB -13 B (-0.0%)

size_with_ext_deps 39.9 kB 39.9 kB -13 B (-0.0%)
sendPasswordResetEmail

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.3 kB 29.3 kB -13 B (-0.0%)

size_with_ext_deps 39.8 kB 39.8 kB -13 B (-0.0%)
sendSignInLinkToEmail

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.4 kB 29.4 kB -13 B (-0.0%)

size_with_ext_deps 39.9 kB 39.9 kB -13 B (-0.0%)
setPersistence

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 28.5 kB 28.5 kB -13 B (-0.0%)

size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)
signInAnonymously

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.6 kB 29.6 kB -13 B (-0.0%)

size_with_ext_deps 40.1 kB 40.1 kB -13 B (-0.0%)
signInWithCredential

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.9 kB 29.9 kB -13 B (-0.0%)

size_with_ext_deps 40.4 kB 40.4 kB -13 B (-0.0%)
signInWithCustomToken

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.5 kB 29.5 kB -13 B (-0.0%)

size_with_ext_deps 40.0 kB 40.0 kB -13 B (-0.0%)
signInWithEmailAndPassword

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 33.3 kB 33.3 kB -13 B (-0.0%)

size_with_ext_deps 43.8 kB 43.8 kB -13 B (-0.0%)
signInWithEmailLink

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 33.5 kB 33.5 kB -13 B (-0.0%)

size_with_ext_deps 44.0 kB 44.0 kB -13 B (-0.0%)
signInWithPhoneNumber

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 33.4 kB 33.3 kB -13 B (-0.0%)

size_with_ext_deps 43.9 kB 43.8 kB -13 B (-0.0%)
signInWithPopup

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 37.4 kB 37.4 kB -13 B (-0.0%)

size_with_ext_deps 47.9 kB 47.9 kB -13 B (-0.0%)
signInWithRedirect

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 31.9 kB 31.9 kB -13 B (-0.0%)

size_with_ext_deps 42.4 kB 42.4 kB -13 B (-0.0%)
signOut

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 28.5 kB 28.5 kB -13 B (-0.0%)

size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)
unlink

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.1 kB 29.1 kB -13 B (-0.0%)

size_with_ext_deps 39.6 kB 39.5 kB -13 B (-0.0%)
updateCurrentUser

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 28.5 kB 28.5 kB -13 B (-0.0%)

size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)
updateEmail

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 28.8 kB 28.8 kB -13 B (-0.0%)

size_with_ext_deps 39.3 kB 39.3 kB -13 B (-0.0%)
updatePassword

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 28.8 kB 28.8 kB -13 B (-0.0%)

size_with_ext_deps 39.3 kB 39.3 kB -13 B (-0.0%)
updatePhoneNumber

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.2 kB 29.2 kB -13 B (-0.0%)

size_with_ext_deps 39.7 kB 39.7 kB -13 B (-0.0%)
updateProfile

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.0 kB 29.0 kB -13 B (-0.0%)

size_with_ext_deps 39.5 kB 39.5 kB -13 B (-0.0%)
useDeviceLanguage

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 28.5 kB 28.5 kB -13 B (-0.0%)

size_with_ext_deps 39.0 kB 39.0 kB -13 B (-0.0%)
verifyBeforeUpdateEmail

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.4 kB 29.4 kB -13 B (-0.0%)

size_with_ext_deps 39.9 kB 39.9 kB -13 B (-0.0%)
verifyPasswordResetCode

Size

Type Base (08aa4b1) Head (b9c7a9d) Diff

size 29.6 kB 29.6 kB -13 B (-0.0%)

size_with_ext_deps 40.1 kB 40.1 kB -13 B (-0.0%)

Test Logs

Base (08aa4b19): https://github.com/firebase/firebase-js-sdk/actions/runs/416202109
Head (b9c7a9d3): https://github.com/firebase/firebase-js-sdk/actions/runs/424253260

schmidt-sebastian · 2021-01-08T17:57:35Z

@hsubox76 Do you know why I cannot merge?

hsubox76 · 2021-01-08T18:20:13Z

Changeset changes need to be approved by global approvers, changeset approvers, or firestore-js-team which is defined here:

firebase-js-sdk/.github/CODEOWNERS

Line 26 in 34b4e30

# Used for approving firestore changes.

I approved.

Fix refFromUrl when used with emulator

8a057df

schmidt-sebastian requested a review from jsdt as a code owner December 11, 2020 20:19

Create clever-kangaroos-hug.md

c3f100a

Update clever-kangaroos-hug.md

d3a8d6a

schmidt-sebastian requested a review from samtstern December 11, 2020 20:22

schmidt-sebastian assigned samtstern Dec 11, 2020

schmidt-sebastian added the api: firestore label Dec 11, 2020

samtstern reviewed Dec 14, 2020

View reviewed changes

.changeset/clever-kangaroos-hug.md Outdated Show resolved Hide resolved

samtstern approved these changes Dec 14, 2020

View reviewed changes

Update .changeset/clever-kangaroos-hug.md

34708b0

Co-authored-by: Sam Stern <[email protected]>

firebase deleted a comment from google-oss-bot Dec 15, 2020

schmidt-sebastian added 2 commits December 15, 2020 14:50

Fix more tests

17f65e4

Merge branch 'mrschmidt/databasefix' of github.com:firebase/firebase-…

509257b

…js-sdk into mrschmidt/databasefix

schmidt-sebastian assigned jsdt and unassigned samtstern Dec 16, 2020

jsdt approved these changes Jan 8, 2021

View reviewed changes

jsdt assigned schmidt-sebastian and unassigned jsdt Jan 8, 2021

schmidt-sebastian assigned hsubox76 and unassigned schmidt-sebastian Jan 8, 2021

hsubox76 approved these changes Jan 8, 2021

View reviewed changes

schmidt-sebastian merged commit 50abe6c into master Jan 8, 2021

google-oss-bot mentioned this pull request Jan 12, 2021

Version Packages #4282

Merged

firebase locked and limited conversation to collaborators Feb 8, 2021

Fix refFromUrl when used with emulator #4199

Fix refFromUrl when used with emulator #4199

Conversation

schmidt-sebastian commented Dec 11, 2020

changeset-bot bot commented Dec 11, 2020 • edited Loading

🦋 Changeset detected

schmidt-sebastian commented Dec 11, 2020

google-oss-bot commented Dec 15, 2020

Size Analysis Report

Affected Products

@firebase/auth-exp

ActionCodeURL

Size

AuthCredential

Size

EmailAuthCredential

Size

EmailAuthProvider

Size

FacebookAuthProvider

Size

GithubAuthProvider

Size

GoogleAuthProvider

Size

OAuthCredential

Size

OAuthProvider

Size

PhoneAuthCredential

Size

PhoneAuthProvider

Size

PhoneMultiFactorGenerator

Size

RecaptchaVerifier

Size

TwitterAuthProvider

Size

applyActionCode

Size

browserLocalPersistence

Size

browserPopupRedirectResolver

Size

browserSessionPersistence

Size

checkActionCode

Size

confirmPasswordReset

Size

createUserWithEmailAndPassword

Size

debugErrorMap

Size

deleteUser

Size

fetchSignInMethodsForEmail

Size

getAdditionalUserInfo

Size

getAuth

Size

getIdToken

Size

getIdTokenResult

Size

getMultiFactorResolver

Size

getRedirectResult

Size

inMemoryPersistence

Size

indexedDBLocalPersistence

Size

initializeAuth

Size

isSignInWithEmailLink

Size

linkWithCredential

changeset-bot bot commented Dec 11, 2020 •

edited

Loading

`@firebase/auth-exp`

`ActionCodeURL`

`AuthCredential`

`EmailAuthCredential`

`EmailAuthProvider`

`FacebookAuthProvider`

`GithubAuthProvider`

`GoogleAuthProvider`

`OAuthCredential`

`OAuthProvider`

`PhoneAuthCredential`

`PhoneAuthProvider`

`PhoneMultiFactorGenerator`

`RecaptchaVerifier`

`TwitterAuthProvider`

`applyActionCode`

`browserLocalPersistence`

`browserPopupRedirectResolver`

`browserSessionPersistence`

`checkActionCode`

`confirmPasswordReset`

`createUserWithEmailAndPassword`

`debugErrorMap`

`deleteUser`

`fetchSignInMethodsForEmail`

`getAdditionalUserInfo`

`getAuth`

`getIdToken`

`getIdTokenResult`

`getMultiFactorResolver`

`getRedirectResult`

`inMemoryPersistence`

`indexedDBLocalPersistence`

`initializeAuth`

`isSignInWithEmailLink`

`linkWithCredential`

`linkWithPhoneNumber`

`linkWithPopup`

`linkWithRedirect`

`multiFactor`

`onAuthStateChanged`

`onIdTokenChanged`

`parseActionCodeURL`

`prodErrorMap`

`reauthenticateWithCredential`

`reauthenticateWithPhoneNumber`

`reauthenticateWithPopup`

`reauthenticateWithRedirect`

`reload`

`sendEmailVerification`

`sendPasswordResetEmail`

`sendSignInLinkToEmail`

`setPersistence`

`signInAnonymously`

`signInWithCredential`

`signInWithCustomToken`

`signInWithEmailAndPassword`

`signInWithEmailLink`

`signInWithPhoneNumber`

`signInWithPopup`

`signInWithRedirect`

`signOut`

`unlink`

`updateCurrentUser`

`updateEmail`

`updatePassword`

`updatePhoneNumber`

`updateProfile`