Skip to content

SyncEngine move/renames #4196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2020
Merged

SyncEngine move/renames #4196

merged 3 commits into from
Dec 14, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

  • Splits up sync_engine and sync_engine_impl.ts
  • Prefixes all sync engine methods with syncEngine.

In two commits for easier review.

@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2020

⚠️ No Changeset found

Latest commit: 6a50397

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 11, 2020

Size Analysis Report

Affected Products

No changes between base commit (dface90) and head commit (c48ac1a).

Test Logs

@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Dec 12, 2020
@schmidt-sebastian schmidt-sebastian merged commit 9909a3b into master Dec 14, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/syncengine branch December 14, 2020 19:06
@firebase firebase locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants