Skip to content

Prefix all LocalStore functions with localStore #4191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 11, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

This addresses an outstanding cleanup from the firestore-exp work. In the later stages of the development, we decided to use consistent prefixes for all free-standing functions so that they we can continue to use the method names from other platforms. This first PR addresses LocalStore.

A class that already follows this pattern is FirestoreClient.

@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2020

⚠️ No Changeset found

Latest commit: 3321ae9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 10, 2020

Size Analysis Report

Affected Products

No changes between base commit (44b5251) and head commit (caed292).

Test Logs

@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Dec 10, 2020
@schmidt-sebastian schmidt-sebastian merged commit dface90 into master Dec 11, 2020
@firebase firebase locked and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants