Skip to content

Use esm2017 bundles in unit tests #4179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use esm2017 bundles in unit tests #4179

wants to merge 1 commit into from

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Dec 7, 2020

Use our esm2017 bundles in unit tests, but this requires setting the webpack TS transpile target to at least es2015 so there isn't a conflict between native classes and transpiled classes, see: https://stackoverflow.com/questions/51860043/javascript-es6-typeerror-class-constructor-client-cannot-be-invoked-without-ne

The esm2017 change is in #4168 and causes functions-exp tests to fail without the target change, when FunctionsError extends FirebaseError and calls super().

This will probably have to be changed if we begin rerunning cross-browser testing that includes IE.

Update:
Removed the mainFields change from #4168, we can discuss later. Looks like the issue occurs when functions-exp imports the util esm2017 bundle, it seems to not get transpiled by webpack or get transpiled wrong?

@changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2020

⚠️ No Changeset found

Latest commit: 491c891

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (8518b6b) and head commit (bbe9ecc).

Test Logs

@hsubox76 hsubox76 closed this Jan 19, 2021
@hsubox76 hsubox76 deleted the ch-test-es2017 branch January 21, 2021 20:28
@firebase firebase locked and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants