Use esm2017 bundles in unit tests #4179
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use our esm2017 bundles in unit tests, but this requires setting the webpack TS transpile target to at least
es2015
so there isn't a conflict between native classes and transpiled classes, see: https://stackoverflow.com/questions/51860043/javascript-es6-typeerror-class-constructor-client-cannot-be-invoked-without-neThe esm2017 change is in #4168 and causes functions-exp tests to fail without the target change, when FunctionsError extends FirebaseError and calls super().
This will probably have to be changed if we begin rerunning cross-browser testing that includes IE.
Update:
Removed the mainFields change from #4168, we can discuss later. Looks like the issue occurs when
functions-exp
imports theutil
esm2017 bundle, it seems to not get transpiled by webpack or get transpiled wrong?