Skip to content

Properly escape field paths #4148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Properly escape field paths #4148

merged 3 commits into from
Dec 2, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

JavaScript's replace() by default only replaces the first occurrence of a string, which breaks our field path escaping.

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2020

🦋 Changeset detected

Latest commit: b239cb3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned schmidt-sebastian and unassigned wilhuff Dec 1, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 2, 2020

Size Analysis Report

Affected Products

No changes between base commit (b87cfd1) and head commit (d18e9be).

Test Logs

@schmidt-sebastian schmidt-sebastian merged commit 1849b0d into master Dec 2, 2020
@google-oss-bot google-oss-bot mentioned this pull request Dec 2, 2020
@firebase firebase locked and limited conversation to collaborators Jan 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants