Skip to content

Compat class for FieldPath #4038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2020
Merged

Compat class for FieldPath #4038

merged 1 commit into from
Nov 9, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Nov 4, 2020 •
edited
Loading

This PR removes the FieldPath class in the legacy class in favor of a Compat class that delegates to firestore-exp. It changes all callsites to accept either the Compat class or the firestore-exp FieldPath.

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2020 •
edited
Loading

⚠️ No Changeset found

Latest commit: 10b8556

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@schmidt-sebastian schmidt-sebastian mentioned this pull request Nov 4, 2020
Merged
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 5, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (14d023d) Head (e637541) Diff
    browser 241 kB 241 kB -18 B (-0.0%)
    esm2017 190 kB 190 kB -131 B (-0.1%)
    main 476 kB 476 kB -103 B (-0.0%)
    module 241 kB 241 kB -18 B (-0.0%)
    react-native 190 kB 190 kB -131 B (-0.1%)

  • @firebase/firestore/exp

    Type Base (14d023d) Head (e637541) Diff
    browser 190 kB 190 kB -385 B (-0.2%)
    main 479 kB 478 kB -1.11 kB (-0.2%)
    module 190 kB 190 kB -385 B (-0.2%)
    react-native 190 kB 190 kB -385 B (-0.2%)

  • @firebase/firestore/lite

    Type Base (14d023d) Head (e637541) Diff
    browser 63.9 kB 63.5 kB -352 B (-0.6%)
    main 141 kB 140 kB -1.11 kB (-0.8%)
    module 63.9 kB 63.5 kB -352 B (-0.6%)
    react-native 64.1 kB 63.7 kB -352 B (-0.5%)

  • @firebase/firestore/memory

    Type Base (14d023d) Head (e637541) Diff
    browser 178 kB 178 kB -18 B (-0.0%)
    esm2017 139 kB 139 kB -131 B (-0.1%)
    main 345 kB 345 kB -103 B (-0.0%)
    module 178 kB 178 kB -18 B (-0.0%)
    react-native 140 kB 139 kB -131 B (-0.1%)

  • firebase

    Type Base (14d023d) Head (e637541) Diff
    firebase-firestore.js 283 kB 283 kB -2 B (-0.0%)
    firebase-firestore.memory.js 222 kB 222 kB +12 B (+0.0%)
    firebase.js 826 kB 826 kB -23 B (-0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 5, 2020 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (14d023d) and head commit (e637541).

Test Logs

@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/fieldpath-compat branch from c65fe3a to 2b4898c Compare November 5, 2020 05:55
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/fieldpath-compat branch from 2b4898c to 10b8556 Compare November 5, 2020 06:08
@schmidt-sebastian schmidt-sebastian assigned wu-hui and unassigned dconeybe Nov 6, 2020
@schmidt-sebastian
Copy link
Contributor Author

Assigning to Andy since Denver doesn't have time.

@schmidt-sebastian
Copy link
Contributor Author

Note: this is similar to #3819

@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Nov 9, 2020
@schmidt-sebastian schmidt-sebastian merged commit 6be9225 into master Nov 9, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/fieldpath-compat branch November 9, 2020 22:36
@firebase firebase locked and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

@dconeybe dconeybe Awaiting requested review from dconeybe

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmidt-sebastian @google-oss-bot @wu-hui @dconeybe