Skip to content

Add compat to test commands #3981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Add compat to test commands #3981

merged 1 commit into from
Oct 22, 2020

Conversation

hsubox76
Copy link
Contributor

@Feiyang1 Should @firebase/*-compat be added to "api-report" too?

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2020

⚠️ No Changeset found

Latest commit: 0a2d360

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Feiyang1
Copy link
Member

No, they should not. It won't work for them because they don't export the API.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (f4110cc) and head commit (4f98d8a).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (f4110cc) and head commit (4f98d8a).

Test Logs

@hsubox76 hsubox76 merged commit 64c8d04 into master Oct 22, 2020
@firebase firebase locked and limited conversation to collaborators Nov 22, 2020
@hsubox76 hsubox76 deleted the ch-test-release branch January 21, 2021 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants