Fix a typing error in database-types

[Feiyang1]

push() should return a ThenableReference

[changeset-bot]

🦋 Changeset detected

Latest commit: cc6f2bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@firebase/database-types	Patch
@firebase/database	Patch
firebase	Patch
@firebase/rules-unit-testing	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[schmidt-sebastian]

LGTM. I tried to update the implementation as well, but we would need to handle finally and toStringTag as well. This PR is a good first step.

[Feiyang1]

That reminds me that our public typing is wrong as well. I updated the thenable to only implement then and catch. Can you please take another look?
@schmidt-sebastian

[google-oss-bot]

Binary Size Report

Affected SDKs

• @firebase/firestore

  Type	Base (ca04eda)	Head (c11ae5a)	Diff
  browser	239 kB	238 kB	-658 B (-0.3%)
  esm2017	190 kB	190 kB	-641 B (-0.3%)
  main	471 kB	470 kB	-849 B (-0.2%)
  module	239 kB	238 kB	-658 B (-0.3%)
  react-native	190 kB	190 kB	-641 B (-0.3%)

• @firebase/firestore/exp

  Type	Base (ca04eda)	Head (c11ae5a)	Diff
  browser	188 kB	188 kB	-641 B (-0.3%)
  main	476 kB	475 kB	-849 B (-0.2%)
  module	188 kB	188 kB	-641 B (-0.3%)
  react-native	189 kB	188 kB	-641 B (-0.3%)

• @firebase/firestore/lite

  Type	Base (ca04eda)	Head (c11ae5a)	Diff
  browser	62.2 kB	61.6 kB	-573 B (-0.9%)
  main	137 kB	137 kB	-849 B (-0.6%)
  module	62.2 kB	61.6 kB	-573 B (-0.9%)
  react-native	62.4 kB	61.8 kB	-573 B (-0.9%)

• @firebase/firestore/memory

  Type	Base (ca04eda)	Head (c11ae5a)	Diff
  browser	177 kB	176 kB	-658 B (-0.4%)
  esm2017	140 kB	140 kB	-641 B (-0.5%)
  main	343 kB	342 kB	-849 B (-0.2%)
  module	177 kB	176 kB	-658 B (-0.4%)
  react-native	140 kB	140 kB	-641 B (-0.5%)

• @firebase/storage

  Type	Base (ca04eda)	Head (c11ae5a)	Diff
  esm2017	55.0 kB	49.2 kB	-5.76 kB (-10.5%)
  main	61.4 kB	55.4 kB	-5.96 kB (-9.7%)
  module	61.1 kB	55.1 kB	-5.96 kB (-9.8%)

• firebase

  Type	Base (ca04eda)	Head (c11ae5a)	Diff
  firebase-firestore.js	278 kB	277 kB	-666 B (-0.2%)
  firebase-firestore.memory.js	217 kB	217 kB	-666 B (-0.3%)
  firebase-storage.js	39.6 kB	36.0 kB	-3.52 kB (-8.9%)
  firebase.js	824 kB	820 kB	-4.20 kB (-0.5%)

Test Logs

• Base (ca04eda4): https://github.com/firebase/firebase-js-sdk/actions/runs/318360778
• Head (c11ae5a0): https://github.com/firebase/firebase-js-sdk/actions/runs/318640924

[google-oss-bot]

Size Analysis Report

Affected Products

No changes between base commit (ca04eda) and head commit (c11ae5a).

Test Logs

• Base (ca04eda4): https://github.com/firebase/firebase-js-sdk/actions/runs/318360778
• Head (c11ae5a0): https://github.com/firebase/firebase-js-sdk/actions/runs/318640924