Skip to content

Add documentation for @firebase/auth-exp #3952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 26, 2020
Merged

Add documentation for @firebase/auth-exp #3952

merged 4 commits into from
Oct 26, 2020

Conversation

avolkovi
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2020 •
edited
Loading

⚠️ No Changeset found

Latest commit: b72159d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 15, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (64c8d04) and head commit (a3f7c0e).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 15, 2020 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (344bd88) and head commit (f788f51).

Test Logs

@avolkovi avolkovi force-pushed the avolkovi/auth-docs-2 branch 5 times, most recently from 0648f80 to 62297c9 Compare October 15, 2020 21:13
@avolkovi avolkovi marked this pull request as ready for review October 15, 2020 21:14
@avolkovi
Copy link
Contributor Author

avolkovi commented Oct 15, 2020 •
edited
Loading

Recommend reviewing by starting at https://github.com/firebase/firebase-js-sdk/blob/62297c98cd806c01e78accde319a3ccd0e8a1749/docs-exp/auth.md https://github.com/firebase/firebase-js-sdk/blob/fffa14a7dd088ed4c6ec4293111f34663dd5f5dd/docs-exp/auth.md

@avolkovi avolkovi force-pushed the avolkovi/auth-docs-2 branch 3 times, most recently from fffa14a to 0d9acb5 Compare October 15, 2020 22:26
sam-gc
sam-gc requested changes Oct 15, 2020
View reviewed changes
@sam-gc
Copy link
Contributor

sam-gc commented Oct 15, 2020

Also add some examples for popup/redirect as well

@sam-gc
Copy link
Contributor

sam-gc commented Oct 15, 2020

Also need to fix code snippets with credentialFromResult for the oauth providers

egilmorez
egilmorez approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look -- it's a lot to go through :)

@avolkovi avolkovi force-pushed the avolkovi/auth-docs-2 branch from d47a87d to a356684 Compare October 22, 2020 19:20
@avolkovi avolkovi force-pushed the avolkovi/auth-docs-2 branch from a356684 to b72159d Compare October 22, 2020 20:41
@Feiyang1 Feiyang1 merged commit a9ba7ba into master Oct 26, 2020
@avolkovi avolkovi deleted the avolkovi/auth-docs-2 branch October 26, 2020 21:07
@firebase firebase locked and limited conversation to collaborators Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam-gc sam-gc sam-gc approved these changes

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@egilmorez egilmorez egilmorez approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76

@kevinthecheung kevinthecheung Awaiting requested review from kevinthecheung

Assignees

@Feiyang1 Feiyang1

@kevinthecheung kevinthecheung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@avolkovi @google-oss-bot @sam-gc @Feiyang1 @egilmorez @kevinthecheung