Add extra asserts around action code settings (auth-next) #3911

avolkovi · 2020-10-09T00:02:55Z

No description provided.

changeset-bot · 2020-10-09T00:02:58Z

⚠️ No Changeset found

Latest commit: 9a969c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2020-10-09T00:20:06Z

Binary Size Report

Affected SDKs

No changes between base commit (49378bf) and head commit (e504e7a).

Test Logs

Base (49378bf5): https://github.com/firebase/firebase-js-sdk/actions/runs/315943237
Head (e504e7a9): https://github.com/firebase/firebase-js-sdk/actions/runs/316018903

google-oss-bot · 2020-10-09T00:26:11Z

Size Analysis Report

Affected Products

`@firebase/auth-exp`

`sendEmailVerification`

Size

Type	Base (`49378bf`)	Head (`e504e7a`)	Diff
size	45.1 kB	45.4 kB	+334 B (+0.7%)
size_with_ext_deps	55.6 kB	55.9 kB	+338 B (+0.6%)

Dependencies

Type	Base (`49378bf`)	Head (`e504e7a`)	Diff
functions	Click to show 45 deps `_castAuth` `_emulatorUrl` `_getBrowserName` `_getClientVersion` `_getCurrentScheme` `_getFinalTarget` `_getInstance` `_getUserLanguage` `_isAndroid` `_isBlackBerry` `_isChromeIOS` `_isFirefox` `_isHttpOrHttps` `_isIEMobile` `_isOnline` `_isSafari` `_isWebOS` `_logError` `_logoutIfInvalidated` `_parseToken` `_performApiRequest` `_performFetchWithErrorHandling` `_persistenceKeyName` `_reloadWithoutSaving` `assert` `assertStringOrUndefined` `debugAssert` `debugFail` `deleteAccount` `extractProviderData` `fail` `getAccountInfo` `getIdTokenResult` `getVersionForPlatform` `isUserInvalidated` `makeTaggedError` `mergeProviderData` `registerAuth` `reload` `requestStsToken` `secondsStringToMilliseconds` `sendEmailVerification` `sendOobCode` `setActionCodeSettingsOnRequest` `utcTimestampToDateString`	Click to show 45 deps `_castAuth` `_emulatorUrl` `_getBrowserName` `_getClientVersion` `_getCurrentScheme` `_getFinalTarget` `_getInstance` `_getUserLanguage` `_isAndroid` `_isBlackBerry` `_isChromeIOS` `_isFirefox` `_isHttpOrHttps` `_isIEMobile` `_isOnline` `_isSafari` `_isWebOS` `_logError` `_logoutIfInvalidated` `_parseToken` `_performApiRequest` `_performFetchWithErrorHandling` `_persistenceKeyName` `_reloadWithoutSaving` `_setActionCodeSettingsOnRequest` `assert` `assertStringOrUndefined` `debugAssert` `debugFail` `deleteAccount` `extractProviderData` `fail` `getAccountInfo` `getIdTokenResult` `getVersionForPlatform` `isUserInvalidated` `makeTaggedError` `mergeProviderData` `registerAuth` `reload` `requestStsToken` `secondsStringToMilliseconds` `sendEmailVerification` `sendOobCode` `utcTimestampToDateString`	`+ _setActionCodeSettingsOnRequest` `- setActionCodeSettingsOnRequest`

`sendPasswordResetEmail`

Size

Type	Base (`49378bf`)	Head (`e504e7a`)	Diff
size	45.0 kB	45.3 kB	+329 B (+0.7%)
size_with_ext_deps	55.5 kB	55.8 kB	+333 B (+0.6%)

Dependencies

Type	Base (`49378bf`)	Head (`e504e7a`)	Diff
functions	Click to show 45 deps `_castAuth` `_emulatorUrl` `_getBrowserName` `_getClientVersion` `_getCurrentScheme` `_getFinalTarget` `_getInstance` `_getUserLanguage` `_isAndroid` `_isBlackBerry` `_isChromeIOS` `_isFirefox` `_isHttpOrHttps` `_isIEMobile` `_isOnline` `_isSafari` `_isWebOS` `_logError` `_logoutIfInvalidated` `_parseToken` `_performApiRequest` `_performFetchWithErrorHandling` `_persistenceKeyName` `_reloadWithoutSaving` `assert` `assertStringOrUndefined` `debugAssert` `debugFail` `deleteAccount` `extractProviderData` `fail` `getAccountInfo` `getIdTokenResult` `getVersionForPlatform` `isUserInvalidated` `makeTaggedError` `mergeProviderData` `registerAuth` `reload` `requestStsToken` `secondsStringToMilliseconds` `sendOobCode` `sendPasswordResetEmail` `setActionCodeSettingsOnRequest` `utcTimestampToDateString`	Click to show 45 deps `_castAuth` `_emulatorUrl` `_getBrowserName` `_getClientVersion` `_getCurrentScheme` `_getFinalTarget` `_getInstance` `_getUserLanguage` `_isAndroid` `_isBlackBerry` `_isChromeIOS` `_isFirefox` `_isHttpOrHttps` `_isIEMobile` `_isOnline` `_isSafari` `_isWebOS` `_logError` `_logoutIfInvalidated` `_parseToken` `_performApiRequest` `_performFetchWithErrorHandling` `_persistenceKeyName` `_reloadWithoutSaving` `_setActionCodeSettingsOnRequest` `assert` `assertStringOrUndefined` `debugAssert` `debugFail` `deleteAccount` `extractProviderData` `fail` `getAccountInfo` `getIdTokenResult` `getVersionForPlatform` `isUserInvalidated` `makeTaggedError` `mergeProviderData` `registerAuth` `reload` `requestStsToken` `secondsStringToMilliseconds` `sendOobCode` `sendPasswordResetEmail` `utcTimestampToDateString`	`+ _setActionCodeSettingsOnRequest` `- setActionCodeSettingsOnRequest`

`sendSignInLinkToEmail`

Size

Type	Base (`49378bf`)	Head (`e504e7a`)	Diff
size	45.0 kB	45.3 kB	+329 B (+0.7%)
size_with_ext_deps	55.5 kB	55.8 kB	+333 B (+0.6%)

Dependencies

Type	Base (`49378bf`)	Head (`e504e7a`)	Diff
functions	Click to show 45 deps `_castAuth` `_emulatorUrl` `_getBrowserName` `_getClientVersion` `_getCurrentScheme` `_getFinalTarget` `_getInstance` `_getUserLanguage` `_isAndroid` `_isBlackBerry` `_isChromeIOS` `_isFirefox` `_isHttpOrHttps` `_isIEMobile` `_isOnline` `_isSafari` `_isWebOS` `_logError` `_logoutIfInvalidated` `_parseToken` `_performApiRequest` `_performFetchWithErrorHandling` `_persistenceKeyName` `_reloadWithoutSaving` `assert` `assertStringOrUndefined` `debugAssert` `debugFail` `deleteAccount` `extractProviderData` `fail` `getAccountInfo` `getIdTokenResult` `getVersionForPlatform` `isUserInvalidated` `makeTaggedError` `mergeProviderData` `registerAuth` `reload` `requestStsToken` `secondsStringToMilliseconds` `sendOobCode` `sendSignInLinkToEmail` `setActionCodeSettingsOnRequest` `utcTimestampToDateString`	Click to show 45 deps `_castAuth` `_emulatorUrl` `_getBrowserName` `_getClientVersion` `_getCurrentScheme` `_getFinalTarget` `_getInstance` `_getUserLanguage` `_isAndroid` `_isBlackBerry` `_isChromeIOS` `_isFirefox` `_isHttpOrHttps` `_isIEMobile` `_isOnline` `_isSafari` `_isWebOS` `_logError` `_logoutIfInvalidated` `_parseToken` `_performApiRequest` `_performFetchWithErrorHandling` `_persistenceKeyName` `_reloadWithoutSaving` `_setActionCodeSettingsOnRequest` `assert` `assertStringOrUndefined` `debugAssert` `debugFail` `deleteAccount` `extractProviderData` `fail` `getAccountInfo` `getIdTokenResult` `getVersionForPlatform` `isUserInvalidated` `makeTaggedError` `mergeProviderData` `registerAuth` `reload` `requestStsToken` `secondsStringToMilliseconds` `sendOobCode` `sendSignInLinkToEmail` `utcTimestampToDateString`	`+ _setActionCodeSettingsOnRequest` `- setActionCodeSettingsOnRequest`

`verifyBeforeUpdateEmail`

Size

Type	Base (`49378bf`)	Head (`e504e7a`)	Diff
size	45.1 kB	45.4 kB	+334 B (+0.7%)
size_with_ext_deps	55.6 kB	55.9 kB	+338 B (+0.6%)

Dependencies

Type	Base (`49378bf`)	Head (`e504e7a`)	Diff
functions	Click to show 46 deps `_castAuth` `_emulatorUrl` `_getBrowserName` `_getClientVersion` `_getCurrentScheme` `_getFinalTarget` `_getInstance` `_getUserLanguage` `_isAndroid` `_isBlackBerry` `_isChromeIOS` `_isFirefox` `_isHttpOrHttps` `_isIEMobile` `_isOnline` `_isSafari` `_isWebOS` `_logError` `_logoutIfInvalidated` `_parseToken` `_performApiRequest` `_performFetchWithErrorHandling` `_persistenceKeyName` `_reloadWithoutSaving` `assert` `assertStringOrUndefined` `debugAssert` `debugFail` `deleteAccount` `extractProviderData` `fail` `getAccountInfo` `getIdTokenResult` `getVersionForPlatform` `isUserInvalidated` `makeTaggedError` `mergeProviderData` `registerAuth` `reload` `requestStsToken` `secondsStringToMilliseconds` `sendOobCode` `setActionCodeSettingsOnRequest` `utcTimestampToDateString` `verifyAndChangeEmail` `verifyBeforeUpdateEmail`	Click to show 46 deps `_castAuth` `_emulatorUrl` `_getBrowserName` `_getClientVersion` `_getCurrentScheme` `_getFinalTarget` `_getInstance` `_getUserLanguage` `_isAndroid` `_isBlackBerry` `_isChromeIOS` `_isFirefox` `_isHttpOrHttps` `_isIEMobile` `_isOnline` `_isSafari` `_isWebOS` `_logError` `_logoutIfInvalidated` `_parseToken` `_performApiRequest` `_performFetchWithErrorHandling` `_persistenceKeyName` `_reloadWithoutSaving` `_setActionCodeSettingsOnRequest` `assert` `assertStringOrUndefined` `debugAssert` `debugFail` `deleteAccount` `extractProviderData` `fail` `getAccountInfo` `getIdTokenResult` `getVersionForPlatform` `isUserInvalidated` `makeTaggedError` `mergeProviderData` `registerAuth` `reload` `requestStsToken` `secondsStringToMilliseconds` `sendOobCode` `utcTimestampToDateString` `verifyAndChangeEmail` `verifyBeforeUpdateEmail`	`+ _setActionCodeSettingsOnRequest` `- setActionCodeSettingsOnRequest`

Test Logs

Base (49378bf5): https://github.com/firebase/firebase-js-sdk/actions/runs/315943237
Head (e504e7a9): https://github.com/firebase/firebase-js-sdk/actions/runs/316018903

packages-exp/auth-exp/src/core/strategies/action_code_settings.ts

Feiyang1

Please fix the lint error

avolkovi requested a review from sam-gc October 9, 2020 00:02

avolkovi requested review from Feiyang1, hiranya911 and hsubox76 as code owners October 9, 2020 00:02

avolkovi assigned sam-gc and Feiyang1 Oct 9, 2020

sam-gc reviewed Oct 9, 2020

View reviewed changes

packages-exp/auth-exp/src/core/strategies/action_code_settings.ts Outdated Show resolved Hide resolved

packages-exp/auth-exp/src/core/strategies/action_code_settings.ts Outdated Show resolved Hide resolved

sam-gc approved these changes Oct 9, 2020

View reviewed changes

avolkovi unassigned sam-gc Oct 13, 2020

Add extra asserts around action code settings (auth-next)

20444f9

avolkovi force-pushed the avolkovi/action-code-settings branch from 068fac5 to d07605e Compare October 19, 2020 17:23

Feiyang1 approved these changes Oct 19, 2020

View reviewed changes

avolkovi unassigned Feiyang1 Oct 19, 2020

avolkovi force-pushed the avolkovi/action-code-settings branch from d07605e to 711cf28 Compare October 19, 2020 17:45

PR feedback

9a969c7

avolkovi force-pushed the avolkovi/action-code-settings branch from 711cf28 to 9a969c7 Compare October 19, 2020 17:48

avolkovi merged commit 0204abf into master Oct 19, 2020

avolkovi deleted the avolkovi/action-code-settings branch October 19, 2020 18:48

firebase locked and limited conversation to collaborators Nov 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add extra asserts around action code settings (auth-next) #3911

Add extra asserts around action code settings (auth-next) #3911

avolkovi commented Oct 9, 2020

changeset-bot bot commented Oct 9, 2020 •

edited

Loading

google-oss-bot commented Oct 9, 2020 •

edited

Loading

google-oss-bot commented Oct 9, 2020 •

edited

Loading

`sendEmailVerification`

Size

Dependencies

`sendPasswordResetEmail`

Size

Dependencies

`sendSignInLinkToEmail`

Size

Dependencies

`verifyBeforeUpdateEmail`

Size

Dependencies

Feiyang1 left a comment

Add extra asserts around action code settings (auth-next) #3911

Add extra asserts around action code settings (auth-next) #3911

Conversation

avolkovi commented Oct 9, 2020

changeset-bot bot commented Oct 9, 2020 • edited Loading

⚠️ No Changeset found

google-oss-bot commented Oct 9, 2020 • edited Loading

Binary Size Report

Affected SDKs

Test Logs

google-oss-bot commented Oct 9, 2020 • edited Loading

Size Analysis Report

Affected Products

@firebase/auth-exp

sendEmailVerification

Size

Dependencies

sendPasswordResetEmail

Size

Dependencies

sendSignInLinkToEmail

Size

Dependencies

verifyBeforeUpdateEmail

Size

Dependencies

Test Logs

Feiyang1 left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Oct 9, 2020 •

edited

Loading

google-oss-bot commented Oct 9, 2020 •

edited

Loading

google-oss-bot commented Oct 9, 2020 •

edited

Loading

`@firebase/auth-exp`

`sendEmailVerification`

`sendPasswordResetEmail`

`sendSignInLinkToEmail`

`verifyBeforeUpdateEmail`