Add IndexedDB action to error message #3871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 494f7ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs |
wilhuff
approved these changes
Sep 30, 2020
| @@ -262,6 +264,7 @@ describe('IndexedDbSchema: createOrUpgradeDb', () => { | |||
|
|
|||
| return withDb(2, db => { | |||
| return db.runTransaction( | |||
| TEST_ACTION, | |||
There was a problem hiding this comment.
Is it possible to use the current test name, description, or similar here? This would benefit test failures similarly to what you're proposing for end users.
There was a problem hiding this comment.
We have to convert the tests to use proper functions, since they will be associated with Mocha's this context, which then provides the test name. I updated this file and SimpleDbTest.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This propagates the action name that we already use in IndexedDbPersistence to SimpleDb, which should give us more insights when users provide IndexedDB stacktraces that do not have a cause associated.
Addresses #3852