Fix custom trace event dispatch before initialization for Performance Monitoring

[zijianjoy]

Developer reported that custom trace right after initializing perf object was not able to be recorded. That is because initialization didn't finish, thus was not able to flip the bit of SettingsService.loggingEnabled from false to true. Therefore custom trace was discarded.

Fix

Check SettingsService.loggingEnabled after initialization finishes, thus avoid dropping events before reading RemoteConfig value.

Internal tracking bug: b/169126072

[changeset-bot]

🦋 Changeset detected

Latest commit: 8f7a46a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@firebase/performance	Patch
firebase	Patch
@firebase/rules-unit-testing	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[google-oss-bot]

Binary Size Report

Affected SDKs

• @firebase/analytics

  Type	Base (a6af7c2)	Head (c480f14)	Diff
  esm2017	18.4 kB	18.6 kB	+224 B (+1.2%)
  main	23.3 kB	23.8 kB	+467 B (+2.0%)
  module	22.8 kB	23.3 kB	+455 B (+2.0%)

• @firebase/firestore

  Type	Base (a6af7c2)	Head (c480f14)	Diff
  browser	249 kB	249 kB	+77 B (+0.0%)
  esm2017	196 kB	196 kB	+78 B (+0.0%)
  main	483 kB	484 kB	+165 B (+0.0%)
  module	247 kB	247 kB	+77 B (+0.0%)
  react-native	196 kB	197 kB	+78 B (+0.0%)

• @firebase/firestore/exp

  Type	Base (a6af7c2)	Head (c480f14)	Diff
  browser	189 kB	189 kB	+78 B (+0.0%)
  main	477 kB	477 kB	+169 B (+0.0%)
  module	189 kB	189 kB	+78 B (+0.0%)
  react-native	189 kB	189 kB	+78 B (+0.0%)

• @firebase/firestore/lite

  Type	Base (a6af7c2)	Head (c480f14)	Diff
  main	140 kB	140 kB	+6 B (+0.0%)

• @firebase/performance

  Type	Base (a6af7c2)	Head (c480f14)	Diff
  browser	27.4 kB	27.5 kB	+57 B (+0.2%)
  esm2017	25.4 kB	25.4 kB	+59 B (+0.2%)
  main	27.4 kB	27.5 kB	+57 B (+0.2%)
  module	27.1 kB	27.2 kB	+57 B (+0.2%)

• firebase

  Type	Base (a6af7c2)	Head (c480f14)	Diff
  firebase-analytics.js	35.8 kB	35.9 kB	+70 B (+0.2%)
  firebase-firestore.js	287 kB	287 kB	+77 B (+0.0%)
  firebase-performance-standalone.es2017.js	71.3 kB	71.4 kB	+35 B (+0.0%)
  firebase-performance-standalone.js	48.0 kB	48.0 kB	+26 B (+0.1%)
  firebase-performance.js	38.4 kB	38.4 kB	+26 B (+0.1%)
  firebase.js	831 kB	831 kB	+175 B (+0.0%)

Test Logs

• Base (a6af7c27): https://github.com/firebase/firebase-js-sdk/actions/runs/272725135
• Head (c480f14f): https://github.com/firebase/firebase-js-sdk/actions/runs/281895302

[google-oss-bot]

Size Analysis Report

Affected Products

@firebase/performance-exp

• getPerformance

  Size

  Type	Base (a6af7c2)	Head (c480f14)	Diff
  size	16.8 kB	16.9 kB	+67 B (+0.4%)
  size_with_ext_deps	21.8 kB	33.9 kB	+12.0 kB (+55.0%)

• trace

  Size

  Type	Base (a6af7c2)	Head (c480f14)	Diff
  size	16.7 kB	16.8 kB	+67 B (+0.4%)
  size_with_ext_deps	21.7 kB	33.8 kB	+12.1 kB (+55.7%)

Test Logs

• Base (a6af7c27): https://github.com/firebase/firebase-js-sdk/actions/runs/272725135
• Head (c480f14f): https://github.com/firebase/firebase-js-sdk/actions/runs/281895302

[Feiyang1]

LGTM. Can you please add changeset? Is there a GitHub issue we can reference?

[github-actions]

Changeset File Check ⚠️

Warning: This PR modifies files in the following packages but they have not been included in the changeset file:

• @firebase/performance-exp

Make sure this was intentional.

[zijianjoy]

LGTM. Can you please add changeset? Is there a GitHub issue we can reference?

Thank you! I added a changeset, and the issue comes from internal support flow, Internal tracking bug: b/169126072.