Support waitForPendingWrites in secondary tabs #3821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: d4adc1e We got this. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
schmidt-sebastian
force-pushed
the
mrschmidt/waitforpendingwritesmultitab
branch
from
d22d415 to
6899540
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/waitforpendingwritesmultitab
branch
from
6899540 to
454e2f3
Compare
Binary Size ReportAffected SDKs
Test Logs |
wilhuff
approved these changes
Sep 21, 2020
.changeset/mean-queens-roll.md
Outdated
| "@firebase/firestore": patch | ||
| --- | ||
|
|
||
| Fixes an issue that prevents `waitForPendingWrites()` from resolving in background tabs when multi-tab is used. |
There was a problem hiding this comment.
Is it worth linking to the specific issue we're addressing?
There was a problem hiding this comment.
The changelog generator can automatically generate the issue link in the changelog by looking for issue links in the PR comment, so it's fine to not include it manually. No need to worry about 2 issue links - the generator will not generate one if it sees you manually included it.
Feiyang1
approved these changes
Sep 21, 2020
schmidt-sebastian
added a commit
to firebase/firebase-android-sdk
that referenced
this pull request
Sep 22, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user noticed that
waitForPendingWritesdoesn't work in secondary tabs. This is a one line fix + spec tests.Fixes #3816