Skip to content

Fixes an unicode encoding issue in firebase-auth.js #3813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Fixes an unicode encoding issue in firebase-auth.js #3813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ba868f
escape unicodes
Feiyang1 Sep 18, 2020
bb088ed
Create honest-doors-poke.md
Feiyang1 Sep 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/honest-doors-poke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"firebase": patch
---

Escape unicodes when generating CDN scripts, so they work correctly in environments that requires UTF-8, for example, in Chrome extension.
9 changes: 8 additions & 1 deletion packages/firebase/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,14 @@ const componentBuilds = pkg.components
{
input: `${component}/index.ts`,
output: createUmdOutputConfig(`firebase-${component}.js`),
plugins: [...plugins, uglify()],
plugins: [
...plugins,
uglify({
output: {
ascii_only: true // escape unicode chars
}
})
],
external: ['@firebase/app']
}
];
Expand Down