Skip to content

Initial copy of performance and performance-types to packages-exp #3778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 16, 2020

Conversation

jposuna
Copy link
Contributor

@jposuna jposuna commented Sep 15, 2020

There are barely any changes compared to the standard performance package. Only changed the relevant information in the package.json for both folders. I'll add changes incrementally in future PRs.

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2020

💥 No Changeset

Latest commit: 64359fb

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 15, 2020

Size Analysis Report

Affected Products

@firebase/performance-exp

  • registerPerformance

    Size

    Type Base (80e4219) Head (37b14af) Diff
    size ? 16.4 kB ? (?)
    size_with_ext_deps ? 44.4 kB ? (?)

    Dependencies

    Type Base (80e4219) Head (37b14af) Diff
    functions ?
    Click to show 46 depsaddToQueue
    changeInitializationStatus
    configValid
    convertMetricValueToInteger
    createNetworkRequestEntry
    createUserTimingTrace
    dispatchQueueEvents
    getApplicationInfo
    getAuthTokenPromise
    getConfig
    getDocumentReadyComplete
    getEffectiveConnectionType
    getIid
    getIidPromise
    getInitializationPromise
    getRemoteConfig
    getServiceWorkerStatus
    getStoredConfig
    getVisibilityState
    initializePerf
    isPerfInitialized
    isValidCustomAttributeName
    isValidCustomAttributeValue
    isValidMetricName
    logNetworkRequest
    logTrace
    mergeStrings
    postToFlEndpoint
    processConfig
    processQueue
    registerPerformance
    sendEventsToFl
    sendLog
    sendTraceLog
    serializeNetworkRequest
    serializeTrace
    serializer
    setupApi
    setupNetworkRequests
    setupOobResources
    setupOobTraces
    setupTransportService
    setupUserTimingTraces
    shouldLogAfterSampling
    storeConfig
    transportHandler
    ?
    classes ? Api
    PerformanceController
    SettingsService
    Trace
    ?
    variables ?
    Click to show 44 depsATTRIBUTE_FORMAT_REGEX
    CONFIG_EXPIRY_LOCAL_STORAGE_KEY
    CONFIG_LOCAL_STORAGE_KEY
    COULD_NOT_GET_CONFIG_MSG
    DEFAULT_CONFIGS
    DEFAULT_ENTRY_NAME
    DEFAULT_REMAINING_TRIES
    DEFAULT_SEND_INTERVAL_MS
    ERROR_DESCRIPTION_MAP
    ERROR_FACTORY
    FID_WAIT_TIME_MS
    FIRST_CONTENTFUL_PAINT_COUNTER_NAME
    FIRST_INPUT_DELAY_COUNTER_NAME
    FIRST_PAINT_COUNTER_NAME
    FIS_AUTH_PREFIX
    INITIAL_SEND_TIME_DELAY_MS
    MAX_ATTRIBUTE_NAME_LENGTH
    MAX_ATTRIBUTE_VALUE_LENGTH
    MAX_METRIC_NAME_LENGTH
    OOB_TRACE_PAGE_LOAD_PREFIX
    REMOTE_CONFIG_SDK_VERSION
    RESERVED_ATTRIBUTE_PREFIXES
    RESERVED_AUTO_PREFIX
    SDK_VERSION
    SERVICE
    SERVICE_NAME
    TRACE_MEASURE_PREFIX
    TRACE_START_MARK_PREFIX
    TRACE_STOP_MARK_PREFIX
    VisibilityState
    apiInstance
    consoleLogger
    iid
    initializationPromise
    initializationStatus
    isTransportSetup
    logger
    name
    oobMetrics
    queue
    remainingTries
    settingsServiceInstance
    version
    windowInstance
    ?

    External Dependencies

    Module Base (80e4219) Head (37b14af) Diff
    @firebase/logger ? LogLevel
    Logger
    ?
    @firebase/util ? ErrorFactory
    isIndexedDBAvailable
    validateIndexedDBOpenable
    ?
    @firebase/app ? default export ?
    @firebase/component ? Component ?

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 15, 2020

Binary Size Report

Affected SDKs

  • @firebase/performance-exp

    Type Base (80e4219) Head (37b14af) Diff
    browser ? 27.4 kB ? (?)
    esm2017 ? 25.4 kB ? (?)
    main ? 27.4 kB ? (?)
    module ? 27.1 kB ? (?)

Test Logs

@jposuna jposuna marked this pull request as ready for review September 15, 2020 01:07
@jposuna jposuna requested a review from alikn September 15, 2020 01:07
@jposuna jposuna requested a review from hsubox76 September 16, 2020 00:23
@jposuna jposuna merged commit 07cbd42 into master Sep 16, 2020
@firebase firebase locked and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants