Skip to content

Make != and NOT_IN publicly available #3772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 15, 2020
Merged

Make != and NOT_IN publicly available #3772

merged 3 commits into from
Sep 15, 2020

Conversation

thebrianchen
Copy link

@thebrianchen thebrianchen commented Sep 11, 2020 •
edited
Loading

In addition to making the operators public, this PR also adds NOT_IN to the isInequality() check and updates some validation error messages.

@thebrianchen thebrianchen self-assigned this Sep 11, 2020
@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2020 •
edited
Loading

🦋 Changeset is good to go

Latest commit: fb97216

We got this.

This PR includes changesets to release 10 packages
Name Type
firebase Minor
@firebase/firestore Minor
@firebase/firestore-types Minor
@firebase/rules-unit-testing Patch
rxfire Major
@firebase/testing Patch
firebase-namespace-integration-test Patch
firebase-messaging-integration-test Patch
firebase-exp Patch
firebase-firestore-integration-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2020 •
edited
Loading

Changeset File Check ✅

No modified packages are missing from the changeset file.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 11, 2020 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (b1854ab) and head commit (18f899d).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 11, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (b1854ab) Head (18f899d) Diff
    browser 249 kB 249 kB -309 B (-0.1%)
    esm2017 196 kB 196 kB -312 B (-0.2%)
    main 483 kB 483 kB -417 B (-0.1%)
    module 246 kB 246 kB -309 B (-0.1%)
    react-native 197 kB 196 kB -312 B (-0.2%)

  • @firebase/firestore/exp

    Type Base (b1854ab) Head (18f899d) Diff
    browser 190 kB 189 kB -293 B (-0.2%)
    main 478 kB 478 kB -634 B (-0.1%)
    module 190 kB 189 kB -293 B (-0.2%)
    react-native 190 kB 189 kB -293 B (-0.2%)

  • @firebase/firestore/lite

    Type Base (b1854ab) Head (18f899d) Diff
    browser 64.3 kB 64.0 kB -385 B (-0.6%)
    main 142 kB 141 kB -618 B (-0.4%)
    module 64.3 kB 64.0 kB -385 B (-0.6%)
    react-native 64.6 kB 64.2 kB -389 B (-0.6%)

  • @firebase/firestore/memory

    Type Base (b1854ab) Head (18f899d) Diff
    browser 187 kB 186 kB -309 B (-0.2%)
    esm2017 147 kB 147 kB -312 B (-0.2%)
    main 357 kB 356 kB -417 B (-0.1%)
    module 185 kB 184 kB -309 B (-0.2%)
    react-native 147 kB 147 kB -312 B (-0.2%)

  • firebase

    Type Base (b1854ab) Head (18f899d) Diff
    firebase-firestore.js 287 kB 287 kB -319 B (-0.1%)
    firebase-firestore.memory.js 226 kB 226 kB -319 B (-0.1%)
    firebase.js 830 kB 830 kB -319 B (-0.0%)

Test Logs

@thebrianchen thebrianchen assigned wilhuff and unassigned thebrianchen Sep 14, 2020
hsubox76
hsubox76 reviewed Sep 14, 2020
View reviewed changes
.changeset/shiny-forks-pull.md
@@ -0,0 +1,6 @@
---
'@firebase/firestore': minor
'@firebase/firestore-types': minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add firebase to minor bump the main package?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

wilhuff
wilhuff approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after resolution of @hsubox76's comment.

@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff Sep 14, 2020
@thebrianchen thebrianchen merged commit f900417 into master Sep 15, 2020
@thebrianchen thebrianchen deleted the bc/ne-public branch September 15, 2020 15:20
thebrianchen pushed a commit that referenced this pull request Sep 15, 2020
Revert "Make != and NOT_IN publicly available (#3772)"
9f80809 
This reverts commit f900417.
@thebrianchen thebrianchen mentioned this pull request Sep 15, 2020
Closed
@google-oss-bot google-oss-bot mentioned this pull request Sep 15, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 left review comments

@wilhuff wilhuff wilhuff approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thebrianchen @google-oss-bot @wilhuff @hsubox76