Skip to content

Update typescript-eslint monorepo to v4 (major) #3767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2020
Merged

Update typescript-eslint monorepo to v4 (major) #3767

merged 2 commits into from
Sep 22, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 11, 2020 •
edited
Loading

This PR contains the following updates:

Package Type Update Change
@typescript-eslint/eslint-plugin devDependencies major 3.10.1 -> 4.2.0
@typescript-eslint/eslint-plugin-tslint devDependencies major 3.10.1 -> 4.2.0
@typescript-eslint/parser devDependencies major 3.10.1 -> 4.2.0

Release Notes

typescript-eslint/typescript-eslint

v4.2.0

Compare Source

Bug Fixes
  • eslint-plugin: [naming-convention] ignore properties inside object patterns (#​2566) (53a3cbc)
  • eslint-plugin: [prefer-ts-expect-error] support block comments (#​2541) (c6f72fb)
  • scope-manager: correct analysis of inferred types in conditional types (#​2537) (4f660fd)
Features

4.1.1 (2020-09-14)

Bug Fixes
  • eslint-plugin: [naming-convention] allow an array of selectors with types and modifiers (#​2415) (7ca54c3)
  • eslint-plugin: [no-implied-eval] handle the Function type (#​2435) (e1401dc)
  • eslint-plugin: [no-unused-vars] better handling for declared modules (#​2553) (02d72d4), closes #​2523
  • eslint-plugin: [no-use-before-define] false positive for function type arguments (#​2554) (189162d), closes #​2527
  • eslint-plugin: [prefer-function-type] handle this return (#​2437) (7c6fcee)
  • eslint-plugin: [return-await] don't error for in-try-catch if the return is in a catch without a finally (#​2356) (efdd521)
  • types: artificial fix needed to trigger release (b577daf)
  • types: artificial fix needed to trigger release (fc62ba8)

v4.1.1

Compare Source

Bug Fixes
  • eslint-plugin: [naming-convention] allow an array of selectors with types and modifiers (#​2415) (7ca54c3)
  • eslint-plugin: [no-implied-eval] handle the Function type (#​2435) (e1401dc)
  • eslint-plugin: [no-unused-vars] better handling for declared modules (#​2553) (02d72d4), closes #​2523
  • eslint-plugin: [no-use-before-define] false positive for function type arguments (#​2554) (189162d), closes #​2527
  • eslint-plugin: [prefer-function-type] handle this return (#​2437) (7c6fcee)
  • eslint-plugin: [return-await] don't error for in-try-catch if the return is in a catch without a finally (#​2356) (efdd521)
  • types: artificial fix needed to trigger release (b577daf)
  • types: artificial fix needed to trigger release (fc62ba8)

v4.1.0

Compare Source

Bug Fixes
  • eslint-plugin: [explicit-module-boundary-types] cyclical reference infinite recursion crash (#​2482) (8693653)
  • eslint-plugin: [no-unused-vars] correct detection of unused vars in a declared module with export = (#​2505) (3d07a99)
  • eslint-plugin: [no-unused-vars] properly handle ambient declaration exports (#​2496) (4d3ce5f)
  • eslint-plugin: [no-use-before-define] false positive with jsx pragma reference (#​2503) (5afeeab), closes #​2502
  • eslint-plugin: [typedef] false positive for rest parameter with array destructuring (#​2441) (2ada5af)
  • eslint-plugin: handle missing message IDs in eslint v5/v6 (#​2461) (ffdfade)
  • scope-manager: add const as a global type variable (#​2499) (eb3f6e3)
  • scope-manager: correctly handle inferred types in nested type scopes (#​2497) (95f6bf4)
  • scope-manager: don't create references for intrinsic JSX elements (#​2504) (cdb9807)
  • scope-manager: fallback to lib 'esnext' or 'es5' when ecma version is unsupported (#​2474) (20a7dcc)
  • scope-manager: support rest function type parameters (#​2491) (9d8b4c4), closes #​2449
  • scope-manager: support tagged template string generic type parameters (#​2492) (a2686c0)
  • scope-manager: support type predicates (#​2493) (a40f54c), closes #​2462
  • scope-manager: treat type imports as both values and types (#​2494) (916e95a), closes #​2453
Features

4.0.1 (2020-08-31)

Bug Fixes

v4.0.1

Compare Source

Bug Fixes

v4.0.0

Compare Source

Please see the release notes for v4.0.0

Bug Fixes
  • eslint-plugin: [no-shadow] fix false-positive on enum declaration (#​2374) (9de669f)
  • eslint-plugin: [no-unused-vars] handle TSCallSignature (#​2336) (c70f54f)
  • correct decorator traversal for AssignmentPattern (#​2375) (d738fa4)
  • scope-manager: correct analysis of abstract class properties (#​2420) (cd84549)
  • typescript-estree: correct ChainExpression interaction with parentheses and non-nulls (#​2380) (762bc99)
Features
  • consume new scope analysis package (#​2039) (3be125d)
  • support ESTree optional chaining representation (#​2308) (e9d2ab6)
  • eslint-plugin: [ban-ts-comment] change default for ts-expect-error to allow-with-description (#​2351) (a3f163a), closes #​2146
  • eslint-plugin: [no-unnecessary-condition][strict-boolean-expressions] add option to make the rules error on files without strictNullChecks turned on (#​2345) (9273441)
  • eslint-plugin: [typedef] remove all defaults (#​2352) (a9cd6fb)
  • eslint-plugin: add consistent-type-imports rule (#​2367) (58b1c2d)
  • typescript-estree: switch to globby (#​2418) (3a7ec9b), closes #​2398
BREAKING CHANGES

  • typescript-estree: - removes the ability to supply a RegExp to projectFolderIgnoreList, and changes the meaning of the string value from a regex to a glob.

    • Removed decorators property from several Nodes that could never semantically have them (FunctionDeclaration, TSEnumDeclaration, and TSInterfaceDeclaration)

  • Removed AST_NODE_TYPES.Import. This is a minor breaking change as the node type that used this was removed ages ago.

  • eslint-plugin: Default rule options is a breaking change.

3.10.1 (2020-08-25)

Bug Fixes
  • eslint-plugin: [no-unnecessary-condition] correct regression with unary negations (#​2422) (d1f0887), closes #​2421

Renovate configuration

📅 Schedule: "before 3am on Friday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2020 •
edited
Loading

💥 No Changeset

Latest commit: 7c2edb4

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 11, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (b231495) and head commit (e53dbc2).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 11, 2020 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (0eb18ca) and head commit (b37fb3f).

Test Logs

jposuna added a commit that referenced this pull request Sep 16, 2020
@jposuna
Merging changes from #3767
f29acf3
erikeldridge
erikeldridge approved these changes Sep 16, 2020
View reviewed changes
Copy link

@erikeldridge erikeldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @hsubox76

packages/remote-config/index.ts Outdated
@@ -38,6 +38,7 @@ import {
// Note these debug options are not part of a documented, supported API and can change at any time.
// Consolidates debug options for easier discovery.
// Uses transient variables on window to avoid lingering state causing panic.
// eslint-disable-next-line @typescript-eslint/no-unused-vars
Copy link

@erikeldridge erikeldridge Sep 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking out loud: this var is used, so it's strange lint would think otherwise. I wonder if there's another, preferred way to declare vars on window🤔

@hsubox76
Copy link
Contributor

I just saw this issue where it says this will be fixed in the next version:
typescript-eslint/typescript-eslint#2523 (comment)

Perhaps we should wait for the next version to upgrade.

@renovate renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from 1fbacad to 5e9ab5e Compare September 22, 2020 18:28
@Feiyang1 Feiyang1 merged commit c20f631 into master Sep 22, 2020
@Feiyang1 Feiyang1 deleted the renovate/major-typescript-eslint-monorepo branch September 22, 2020 23:10
@firebase firebase locked and limited conversation to collaborators Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikeldridge erikeldridge erikeldridge approved these changes

@alikn alikn alikn approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@zwu52 zwu52 zwu52 approved these changes

@Feiyang1 Feiyang1 Awaiting requested review from Feiyang1

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@Feiyang1 Feiyang1

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@google-oss-bot @hsubox76 @erikeldridge @alikn @zwu52 @Feiyang1 @renovate-bot