Call toFirestore() only once #3755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: eea74f4 We got this. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs |
Comment on lines
2383
to
2399
| validateExactNumberOfArgs('CollectionReference.add', arguments, 1); | ||
| const convertedValue = this._converter | ||
| ? this._converter.toFirestore(value) | ||
| : value; | ||
| validateArgType('CollectionReference.add', 'object', 1, convertedValue); | ||
| const docRef = this.doc(); | ||
| return docRef.set(value).then(() => docRef); | ||
| return ((docRef as unknown) as DocumentReference) | ||
| .set(value, undefined, 'CollectionReference.add') | ||
| .then(() => docRef); |
There was a problem hiding this comment.
Couldn't you just leave the original code as is and do:
return docRef.withConverter(defaultConverter).set(value).then(() => docRef)
?
thebrianchen
force-pushed
the
bc/conv-fix-add
branch
from
6f2b338 to
fd3f5f5
Compare
added 2 commits
September 10, 2020 12:45
.changeset/tame-donuts-relate.md
Outdated
| '@firebase/firestore': patch | ||
| --- | ||
|
|
||
| Fixed a bug that where CollectionReference.add() called FirestoreDataConverter.toFirestore() twice intead of once (#3742). |
There was a problem hiding this comment.
Please fix grammar.
| return snapshot.data(options)!; | ||
| } | ||
| }; | ||
| return docRef |
There was a problem hiding this comment.
Can you just call the DocumentReference constructor here? That way you can pass "null" and don't need to specify a converter.
schmidt-sebastian
approved these changes
Sep 11, 2020
Co-authored-by: Sebastian Schmidt <[email protected]>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3742.