Skip to content

Increase timeout for flaky test #3750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2020
Merged

Increase timeout for flaky test #3750

merged 3 commits into from
Sep 9, 2020

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Sep 9, 2020

Test is consistently exceeding timeout of 60s. Extending before timeout to 120s.

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2020

💥 No Changeset

Latest commit: 9dc49db

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 9, 2020

Binary Size Report

Affected SDKs

No changes between base commit (a8ff3db) and head commit (6389307).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 9, 2020

Size Analysis Report

Affected Products

No changes between base commit (a8ff3db) and head commit (6389307).

Test Logs

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can also just give an increased timeout for this test case, if that's more appropriate.

describe(...).timeout(120000);

@hsubox76 hsubox76 changed the title Temporarily exclude flaky test Increase timeout for flaky test Sep 9, 2020
@hsubox76 hsubox76 merged commit 0119d66 into master Sep 9, 2020
@hsubox76 hsubox76 deleted the ch-flaky branch September 15, 2020 16:44
@firebase firebase locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants