Skip to content

Remove extraneous tab char in Firestore SDK #3728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 2, 2020
Merged

Remove extraneous tab char in Firestore SDK #3728

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7ca0862
Firestore Externs: @type -> @typedef
richieforeman Sep 1, 2020
9b0271c
Add @override to Recaptcha Verify method in Auth Externs
richieforeman Sep 1, 2020
bb34d4c
Add proper closure `@license` annotation to generated internal rollup…
richieforeman Sep 1, 2020
beb56cb
Merge remote-tracking branch 'upstream/master' into rf/license
richieforeman Sep 1, 2020
56e3bbd
Google LLC + SPDX License ID
richieforeman Sep 1, 2020
f319c0d
Merge remote-tracking branch 'upstream/master'
richieforeman Sep 1, 2020
fab2d6d
Fix tab char in Firestore SDK
richieforeman Sep 2, 2020
50a2cd1
Merge remote-tracking branch 'upstream/master'
richieforeman Sep 2, 2020
6dd0e1e
Merge branch 'master' into rf/fix-tabs
richieforeman Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/firestore/src/remote/rest_connection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export abstract class RestConnection implements Connection {
// Content-Type: text/plain will avoid preflight requests which might
// mess with CORS and redirects by proxies. If we add custom headers
// we will need to change this code to potentially use the $httpOverwrite
// parameter supported by ESF to avoid triggering preflight requests.
// parameter supported by ESF to avoid triggering preflight requests.
headers['Content-Type'] = 'text/plain';

if (token) {
Expand Down