Adding experimentalAutoDetectLongPolling #3724

rafikhan · 2020-09-01T23:20:39Z

Adding support for experimentalAutoDetectLongPolling. This PR includes validation to ensure mutual exclusive use with experimentalForceLongPolling flag and a unit test to ensure that behavior.

In this PR the default value is true so that the code path gets hit during test runs; however, we don't want this in release builds yet. Need feedback on how to configure this correctly.

…nrafi/webchannelupgrade

…base-js-sdk into khanrafi/webchannelupgrade

google-oss-bot · 2020-09-01T23:38:41Z

Size Analysis Report

Affected Products

`@firebase/app-exp`

SDK_VERSION

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 2.63 kB 2.64 kB +8 B (+0.3%)

size_with_ext_deps 4.05 kB 4.06 kB +8 B (+0.2%)
_DEFAULT_ENTRY_NAME

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 2.63 kB 2.64 kB +8 B (+0.3%)

size_with_ext_deps 4.05 kB 4.06 kB +8 B (+0.2%)
_addComponent

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 2.61 kB 2.62 kB +8 B (+0.3%)

size_with_ext_deps 4.02 kB 4.03 kB +8 B (+0.2%)
_addOrOverwriteComponent

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 2.67 kB 2.68 kB +8 B (+0.3%)

size_with_ext_deps 4.09 kB 4.10 kB +8 B (+0.2%)
_apps

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 2.60 kB 2.61 kB +8 B (+0.3%)

size_with_ext_deps 4.02 kB 4.02 kB +8 B (+0.2%)
_clearComponents

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 2.63 kB 2.64 kB +8 B (+0.3%)

size_with_ext_deps 4.05 kB 4.06 kB +8 B (+0.2%)
_components

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 2.61 kB 2.61 kB +8 B (+0.3%)

size_with_ext_deps 4.02 kB 4.03 kB +8 B (+0.2%)
_getProvider

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 2.66 kB 2.66 kB +8 B (+0.3%)

size_with_ext_deps 4.07 kB 4.08 kB +8 B (+0.2%)
_registerComponent

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 2.61 kB 2.62 kB +8 B (+0.3%)

size_with_ext_deps 4.03 kB 4.04 kB +8 B (+0.2%)
_removeServiceInstance

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 2.73 kB 2.74 kB +8 B (+0.3%)

size_with_ext_deps 4.15 kB 4.15 kB +8 B (+0.2%)
deleteApp

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 2.75 kB 2.76 kB +10 B (+0.4%)

size_with_ext_deps 4.16 kB 4.17 kB +10 B (+0.2%)
getApp

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 2.71 kB 2.71 kB +8 B (+0.3%)

size_with_ext_deps 5.39 kB 5.40 kB +10 B (+0.2%)
getApps

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 2.64 kB 2.65 kB +8 B (+0.3%)

size_with_ext_deps 4.06 kB 4.07 kB +8 B (+0.2%)
initializeApp

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 3.69 kB 3.70 kB +10 B (+0.3%)

size_with_ext_deps 9.05 kB 9.08 kB +24 B (+0.3%)
onLog

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 2.74 kB 2.74 kB +8 B (+0.3%)

size_with_ext_deps 5.95 kB 5.96 kB +14 B (+0.2%)
registerVersion

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 2.61 kB 2.62 kB +8 B (+0.3%)

size_with_ext_deps 4.03 kB 4.03 kB +8 B (+0.2%)
setLogLevel

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 2.64 kB 2.65 kB +8 B (+0.3%)

size_with_ext_deps 4.11 kB 4.12 kB +10 B (+0.2%)

`@firebase/auth-exp`

ActionCodeURL

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.7 kB 44.8 kB +42 B (+0.1%)

size_with_ext_deps 55.4 kB 55.4 kB +70 B (+0.1%)
AuthCredential

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.0 kB 44.1 kB +42 B (+0.1%)

size_with_ext_deps 54.6 kB 54.7 kB +70 B (+0.1%)
EmailAuthCredential

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 45.8 kB 45.8 kB +42 B (+0.1%)

size_with_ext_deps 56.4 kB 56.5 kB +70 B (+0.1%)
EmailAuthProvider

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 47.1 kB 47.2 kB +42 B (+0.1%)

size_with_ext_deps 57.8 kB 57.8 kB +70 B (+0.1%)
FacebookAuthProvider

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 47.1 kB 47.2 kB +42 B (+0.1%)

size_with_ext_deps 57.8 kB 57.8 kB +70 B (+0.1%)
GithubAuthProvider

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 47.1 kB 47.2 kB +42 B (+0.1%)

size_with_ext_deps 57.8 kB 57.8 kB +70 B (+0.1%)
GoogleAuthProvider

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 47.1 kB 47.2 kB +42 B (+0.1%)

size_with_ext_deps 57.8 kB 57.8 kB +70 B (+0.1%)
OAuthCredential

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 45.8 kB 45.9 kB +42 B (+0.1%)

size_with_ext_deps 56.4 kB 56.5 kB +70 B (+0.1%)
OAuthProvider

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 46.5 kB 46.6 kB +42 B (+0.1%)

size_with_ext_deps 57.1 kB 57.2 kB +70 B (+0.1%)
PhoneAuthCredential

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 45.7 kB 45.8 kB +42 B (+0.1%)

size_with_ext_deps 56.4 kB 56.4 kB +70 B (+0.1%)
PhoneAuthProvider

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 47.5 kB 47.5 kB +42 B (+0.1%)

size_with_ext_deps 58.1 kB 58.2 kB +70 B (+0.1%)
PhoneMultiFactorGenerator

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.7 kB 44.7 kB +42 B (+0.1%)

size_with_ext_deps 55.3 kB 55.4 kB +70 B (+0.1%)
RecaptchaVerifier

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 50.2 kB 50.3 kB +66 B (+0.1%)

size_with_ext_deps 60.8 kB 60.9 kB +94 B (+0.2%)
TwitterAuthProvider

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 47.1 kB 47.2 kB +42 B (+0.1%)

size_with_ext_deps 57.8 kB 57.9 kB +70 B (+0.1%)
applyActionCode

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 43.9 kB 43.9 kB +42 B (+0.1%)

size_with_ext_deps 54.5 kB 54.6 kB +70 B (+0.1%)
browserLocalPersistence

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 46.7 kB 46.7 kB +48 B (+0.1%)

size_with_ext_deps 57.4 kB 57.4 kB +76 B (+0.1%)
browserPopupRedirectResolver

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 55.6 kB 55.7 kB +70 B (+0.1%)

size_with_ext_deps 66.4 kB 66.5 kB +98 B (+0.1%)
browserSessionPersistence

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.4 kB 44.4 kB +42 B (+0.1%)

size_with_ext_deps 55.0 kB 55.1 kB +70 B (+0.1%)
checkActionCode

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.9 kB 44.9 kB +42 B (+0.1%)

size_with_ext_deps 55.5 kB 55.6 kB +70 B (+0.1%)
confirmPasswordReset

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 43.9 kB 43.9 kB +42 B (+0.1%)

size_with_ext_deps 54.5 kB 54.6 kB +70 B (+0.1%)
createUserWithEmailAndPassword

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.8 kB 44.8 kB +42 B (+0.1%)

size_with_ext_deps 55.4 kB 55.5 kB +70 B (+0.1%)
deleteUser

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 43.8 kB 43.8 kB +42 B (+0.1%)

size_with_ext_deps 54.4 kB 54.5 kB +70 B (+0.1%)
fetchSignInMethodsForEmail

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.1 kB 44.1 kB +42 B (+0.1%)

size_with_ext_deps 54.7 kB 54.8 kB +70 B (+0.1%)
getAdditionalUserInfo

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 45.0 kB 45.0 kB +42 B (+0.1%)

size_with_ext_deps 55.6 kB 55.7 kB +70 B (+0.1%)
getAuth

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 61.4 kB 61.5 kB +96 B (+0.2%)

size_with_ext_deps 72.9 kB 73.0 kB +124 B (+0.2%)
getIdToken

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 43.8 kB 43.8 kB +42 B (+0.1%)

size_with_ext_deps 54.4 kB 54.5 kB +70 B (+0.1%)
getIdTokenResult

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 43.8 kB 43.8 kB +42 B (+0.1%)

size_with_ext_deps 54.4 kB 54.4 kB +70 B (+0.1%)
getMultiFactorResolver

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 46.6 kB 46.7 kB +46 B (+0.1%)

size_with_ext_deps 57.3 kB 57.3 kB +74 B (+0.1%)
getRedirectResult

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 49.2 kB 49.3 kB +46 B (+0.1%)

size_with_ext_deps 59.9 kB 59.9 kB +74 B (+0.1%)
inMemoryPersistence

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 43.8 kB 43.8 kB +42 B (+0.1%)

size_with_ext_deps 54.4 kB 54.4 kB +70 B (+0.1%)
indexedDBLocalPersistence

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 46.8 kB 46.9 kB +62 B (+0.1%)

size_with_ext_deps 57.4 kB 57.5 kB +90 B (+0.2%)
initializeAuth

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.1 kB 44.1 kB +42 B (+0.1%)

size_with_ext_deps 55.3 kB 55.4 kB +70 B (+0.1%)
isSignInWithEmailLink

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.8 kB 44.9 kB +42 B (+0.1%)

size_with_ext_deps 55.5 kB 55.5 kB +70 B (+0.1%)
linkWithCredential

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.8 kB 44.8 kB +46 B (+0.1%)

size_with_ext_deps 55.4 kB 55.5 kB +74 B (+0.1%)
linkWithPhoneNumber

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 48.3 kB 48.4 kB +48 B (+0.1%)

size_with_ext_deps 59.0 kB 59.0 kB +76 B (+0.1%)
linkWithPopup

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 52.3 kB 52.3 kB +50 B (+0.1%)

size_with_ext_deps 62.9 kB 63.0 kB +78 B (+0.1%)
linkWithRedirect

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 47.3 kB 47.4 kB +46 B (+0.1%)

size_with_ext_deps 58.0 kB 58.0 kB +74 B (+0.1%)
multiFactor

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 45.8 kB 45.9 kB +48 B (+0.1%)

size_with_ext_deps 56.5 kB 56.5 kB +76 B (+0.1%)
onAuthStateChanged

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 43.8 kB 43.9 kB +42 B (+0.1%)

size_with_ext_deps 54.4 kB 54.5 kB +70 B (+0.1%)
onIdTokenChanged

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 43.8 kB 43.8 kB +42 B (+0.1%)

size_with_ext_deps 54.4 kB 54.5 kB +70 B (+0.1%)
parseActionCodeURL

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.8 kB 44.8 kB +42 B (+0.1%)

size_with_ext_deps 55.4 kB 55.5 kB +70 B (+0.1%)
reauthenticateWithCredential

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 45.4 kB 45.5 kB +44 B (+0.1%)

size_with_ext_deps 56.0 kB 56.1 kB +72 B (+0.1%)
reauthenticateWithPhoneNumber

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 48.9 kB 48.9 kB +46 B (+0.1%)

size_with_ext_deps 59.5 kB 59.6 kB +74 B (+0.1%)
reauthenticateWithPopup

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 52.3 kB 52.3 kB +50 B (+0.1%)

size_with_ext_deps 62.9 kB 63.0 kB +78 B (+0.1%)
reauthenticateWithRedirect

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 47.1 kB 47.1 kB +42 B (+0.1%)

size_with_ext_deps 57.7 kB 57.8 kB +70 B (+0.1%)
reload

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 43.7 kB 43.8 kB +42 B (+0.1%)

size_with_ext_deps 54.4 kB 54.4 kB +70 B (+0.1%)
sendEmailVerification

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.4 kB 44.4 kB +42 B (+0.1%)

size_with_ext_deps 55.0 kB 55.0 kB +70 B (+0.1%)
sendPasswordResetEmail

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.3 kB 44.3 kB +42 B (+0.1%)

size_with_ext_deps 54.9 kB 55.0 kB +70 B (+0.1%)
sendSignInLinkToEmail

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.3 kB 44.3 kB +42 B (+0.1%)

size_with_ext_deps 54.9 kB 55.0 kB +70 B (+0.1%)
setPersistence

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 43.8 kB 43.8 kB +42 B (+0.1%)

size_with_ext_deps 54.4 kB 54.5 kB +70 B (+0.1%)
signInAnonymously

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.9 kB 44.9 kB +42 B (+0.1%)

size_with_ext_deps 55.5 kB 55.6 kB +70 B (+0.1%)
signInWithCredential

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 45.1 kB 45.2 kB +44 B (+0.1%)

size_with_ext_deps 55.7 kB 55.8 kB +72 B (+0.1%)
signInWithCustomToken

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.8 kB 44.8 kB +42 B (+0.1%)

size_with_ext_deps 55.4 kB 55.5 kB +70 B (+0.1%)
signInWithEmailAndPassword

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 48.6 kB 48.6 kB +44 B (+0.1%)

size_with_ext_deps 59.2 kB 59.3 kB +72 B (+0.1%)
signInWithEmailLink

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 48.8 kB 48.8 kB +44 B (+0.1%)

size_with_ext_deps 59.4 kB 59.5 kB +72 B (+0.1%)
signInWithPhoneNumber

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 48.6 kB 48.6 kB +46 B (+0.1%)

size_with_ext_deps 59.2 kB 59.3 kB +74 B (+0.1%)
signInWithPopup

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 52.2 kB 52.3 kB +50 B (+0.1%)

size_with_ext_deps 62.9 kB 63.0 kB +78 B (+0.1%)
signInWithRedirect

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 46.8 kB 46.8 kB +42 B (+0.1%)

size_with_ext_deps 57.4 kB 57.5 kB +70 B (+0.1%)
signOut

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 43.8 kB 43.8 kB +42 B (+0.1%)

size_with_ext_deps 54.4 kB 54.5 kB +70 B (+0.1%)
unlink

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.4 kB 44.4 kB +48 B (+0.1%)

size_with_ext_deps 55.0 kB 55.1 kB +76 B (+0.1%)
updateCurrentUser

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 43.8 kB 43.8 kB +42 B (+0.1%)

size_with_ext_deps 54.4 kB 54.5 kB +70 B (+0.1%)
updateEmail

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.1 kB 44.1 kB +42 B (+0.1%)

size_with_ext_deps 54.7 kB 54.7 kB +70 B (+0.1%)
updatePassword

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.1 kB 44.1 kB +42 B (+0.1%)

size_with_ext_deps 54.7 kB 54.7 kB +70 B (+0.1%)
updatePhoneNumber

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.5 kB 44.5 kB +42 B (+0.1%)

size_with_ext_deps 55.1 kB 55.2 kB +70 B (+0.1%)
updateProfile

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.2 kB 44.3 kB +44 B (+0.1%)

size_with_ext_deps 54.9 kB 54.9 kB +72 B (+0.1%)
useDeviceLanguage

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 43.8 kB 43.8 kB +42 B (+0.1%)

size_with_ext_deps 54.4 kB 54.5 kB +70 B (+0.1%)
verifyBeforeUpdateEmail

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.4 kB 44.4 kB +42 B (+0.1%)

size_with_ext_deps 55.0 kB 55.1 kB +70 B (+0.1%)
verifyPasswordResetCode

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 44.9 kB 45.0 kB +42 B (+0.1%)

size_with_ext_deps 55.6 kB 55.6 kB +70 B (+0.1%)

`@firebase/functions-exp`

getFunctions

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 1.99 kB 2.00 kB +10 B (+0.5%)

size_with_ext_deps 5.87 kB 5.89 kB +18 B (+0.3%)
httpsCallable

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 5.34 kB 5.36 kB +22 B (+0.4%)

size_with_ext_deps 9.93 kB 9.96 kB +32 B (+0.3%)
useFunctionsEmulator

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 1.95 kB 1.96 kB +10 B (+0.5%)

size_with_ext_deps 5.80 kB 5.82 kB +18 B (+0.3%)

`@firebase/installations-exp`

deleteInstallations

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 8.90 kB 8.92 kB +20 B (+0.2%)

size_with_ext_deps 17.3 kB 17.4 kB +30 B (+0.2%)
getId

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 8.34 kB 8.36 kB +16 B (+0.2%)

size_with_ext_deps 16.8 kB 16.8 kB +26 B (+0.2%)
getInstallations

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 8.43 kB 8.44 kB +16 B (+0.2%)

size_with_ext_deps 16.9 kB 16.9 kB +26 B (+0.2%)
getToken

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 8.35 kB 8.36 kB +16 B (+0.2%)

size_with_ext_deps 16.8 kB 16.8 kB +26 B (+0.2%)
onIdChange

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 8.60 kB 8.62 kB +16 B (+0.2%)

size_with_ext_deps 17.0 kB 17.1 kB +26 B (+0.2%)

`@firebase/performance-exp`

getPerformance

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 17.2 kB 17.3 kB +72 B (+0.4%)

size_with_ext_deps 34.2 kB 34.3 kB +100 B (+0.3%)
trace

Size

Type Base (f5d122a) Head (f6e4264) Diff

size 17.1 kB 17.2 kB +72 B (+0.4%)

size_with_ext_deps 34.1 kB 34.2 kB +100 B (+0.3%)

Test Logs

Base (f5d122a9): https://github.com/firebase/firebase-js-sdk/actions/runs/292269079
Head (f6e42646): https://github.com/firebase/firebase-js-sdk/actions/runs/296378869

schmidt-sebastian

This core logic looks good.

Couple more homework items:

This should have an integration test that uses this flag.
There should be a changelog entry.
Please undo all unrelated formatting changes.

schmidt-sebastian · 2020-09-08T19:10:03Z

packages/firestore/src/api/database.ts

@@ -146,6 +147,7 @@ const DEFAULT_HOST = 'firestore.googleapis.com';
 const DEFAULT_SSL = true;
 const DEFAULT_TIMESTAMPS_IN_SNAPSHOTS = true;
 const DEFAULT_FORCE_LONG_POLLING = false;
+const DEFAULT_FORCE_AUTO_DETECT_LONG_POLLING = true;


Please set this to false and use https://github.com/firebase/firebase-js-sdk/blob/master/packages/firestore/test/integration/util/helpers.ts#L160 to pass custom settings.

Should I set this for both the emulator and prod settings in https://github.com/firebase/firebase-js-sdk/blob/master/packages/firestore/test/integration/util/settings.ts#L35 or should I be passing this in differently?

This is the only place you need to set it to false. What you have now applies to all settings, unless it is overridden by the user.

packages/firestore/src/util/input_validation.ts

packages/firestore/test/unit/specs/spec_test_runner.ts

Co-authored-by: Sebastian Schmidt <[email protected]>

changeset-bot · 2020-09-08T20:21:11Z

🦋 Changeset detected

Latest commit: c972e4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
@firebase/firestore-types	Minor
@firebase/firestore	Minor
@firebase/webchannel-wrapper	Minor
firebase	Minor
@firebase/rules-unit-testing	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2020-09-08T20:41:53Z

Binary Size Report

Affected SDKs

@firebase/analytics

Type Base (f5d122a) Head (f6e4264) Diff

esm2017 18.6 kB 18.6 kB +32 B (+0.2%)
@firebase/app

Type Base (f5d122a) Head (f6e4264) Diff

esm2017 9.46 kB 9.48 kB +20 B (+0.2%)

lite-esm2017 7.75 kB 7.77 kB +20 B (+0.3%)
@firebase/component

Type Base (f5d122a) Head (f6e4264) Diff

esm2017 3.98 kB 3.99 kB +8 B (+0.2%)
@firebase/database

Type Base (f5d122a) Head (f6e4264) Diff

esm2017 236 kB 237 kB +298 B (+0.1%)

`@firebase/firestore`

Type	Base (`f5d122a`)	Head (`f6e4264`)	Diff
browser	249 kB	250 kB	+641 B (+0.3%)
esm2017	197 kB	198 kB	+1.78 kB (+0.9%)
main	484 kB	485 kB	+969 B (+0.2%)
module	247 kB	247 kB	+641 B (+0.3%)
react-native	197 kB	198 kB	+1.78 kB (+0.9%)

`@firebase/firestore/exp`

Type	Base (`f5d122a`)	Head (`f6e4264`)	Diff
browser	189 kB	190 kB	+1.22 kB (+0.6%)
main	477 kB	477 kB	+81 B (+0.0%)
module	189 kB	190 kB	+1.22 kB (+0.6%)
react-native	189 kB	190 kB	+1.22 kB (+0.6%)

`@firebase/firestore/lite`

Type	Base (`f5d122a`)	Head (`f6e4264`)	Diff
browser	63.4 kB	63.6 kB	+171 B (+0.3%)
main	140 kB	140 kB	+76 B (+0.1%)
module	63.4 kB	63.6 kB	+171 B (+0.3%)
react-native	63.6 kB	63.8 kB	+171 B (+0.3%)

`@firebase/firestore/memory`

Type	Base (`f5d122a`)	Head (`f6e4264`)	Diff
browser	187 kB	187 kB	+641 B (+0.3%)
esm2017	147 kB	149 kB	+1.30 kB (+0.9%)
main	357 kB	358 kB	+969 B (+0.3%)
module	185 kB	185 kB	+641 B (+0.3%)
react-native	147 kB	149 kB	+1.30 kB (+0.9%)

@firebase/functions

Type Base (f5d122a) Head (f6e4264) Diff

esm2017 7.60 kB 7.62 kB +22 B (+0.3%)
@firebase/installations

Type Base (f5d122a) Head (f6e4264) Diff

esm2017 16.5 kB 16.6 kB +22 B (+0.1%)
@firebase/logger

Type Base (f5d122a) Head (f6e4264) Diff

esm2017 3.25 kB 3.25 kB +6 B (+0.2%)
@firebase/messaging

Type Base (f5d122a) Head (f6e4264) Diff

esm2017 25.9 kB 26.0 kB +20 B (+0.1%)
@firebase/performance

Type Base (f5d122a) Head (f6e4264) Diff

esm2017 25.8 kB 25.8 kB +66 B (+0.3%)
@firebase/remote-config

Type Base (f5d122a) Head (f6e4264) Diff

esm2017 17.4 kB 17.4 kB +24 B (+0.1%)
@firebase/storage

Type Base (f5d122a) Head (f6e4264) Diff

esm2017 54.9 kB 55.0 kB +78 B (+0.1%)
@firebase/util

Type Base (f5d122a) Head (f6e4264) Diff

esm2017 18.8 kB 18.8 kB +32 B (+0.2%)
@firebase/webchannel-wrapper

Type Base (f5d122a) Head (f6e4264) Diff

esm2017 39.4 kB 39.4 kB +2 B (+0.0%)

`firebase`

Type	Base (`f5d122a`)	Head (`f6e4264`)	Diff
firebase-firestore.js	286 kB	287 kB	+634 B (+0.2%)
firebase-firestore.memory.js	226 kB	226 kB	+634 B (+0.3%)
firebase.js	829 kB	829 kB	+634 B (+0.1%)

Test Logs

Base (f5d122a9): https://github.com/firebase/firebase-js-sdk/actions/runs/292269079
Head (f6e42646): https://github.com/firebase/firebase-js-sdk/actions/runs/296378869

packages/firebase/index.d.ts

Co-authored-by: Sebastian Schmidt <[email protected]>

schmidt-sebastian

Very nice! Landing 2 days before the quarter cutoff too :)

Can you follow the link that "changeset-bot" posted and add a short changelog?

packages/firestore/src/core/database_info.ts

packages/firestore/test/integration/api/database.test.ts

Co-authored-by: Sebastian Schmidt <[email protected]>

rafikhan · 2020-09-29T22:05:00Z

@schmidt-sebastian - Thanks for the reminder on changesets. I've added the file but am not sure if this is a patch release vs minor.

.changeset/yellow-turkeys-lay.md

Co-authored-by: Sebastian Schmidt <[email protected]>

github-actions · 2020-09-30T17:16:46Z

Changeset File Check ✅

No modified packages are missing from the changeset file.

.changeset/yellow-turkeys-lay.md

hsubox76 · 2020-10-06T17:57:42Z

Added @egilmorez as reviewer for documentation change to packages/firebase/index.d.ts

egilmorez

One nit, otherwise everything in index.d.ts looks fine, thanks!

packages/firebase/index.d.ts

Adding back-ticks for literal

Bumping firebase minor version

…nrafi/webchannelupgrade

rafikhan added 16 commits July 8, 2020 14:04

Upgrade to latest version of closure

33d69f3

Adding changeset

35d4713

Updating changeset message

d24a58f

Fixing stylization in changeset copy

6084312

Merge branch 'master' into khanrafi/webchannelupgrade

a2a8817

Merge branch 'master' into khanrafi/webchannelupgrade

433c8ba

WIP

4f544d8

Merge branch 'master' into khanrafi/webchannelupgrade

e778894

Merge branch 'master' of github.com:firebase/firebase-js-sdk into kha…

cffed37

…nrafi/webchannelupgrade

Updating to match new patterns

bb5fe2c

Making member names match conventions on others

59c8900

Making the linter happy

dbffc65

Fixing bug caught by unit tests and misc polish

bee717c

Turning auto detection on by default

7356673

Turning auto detection on by default

14887c4

Merge branch 'khanrafi/webchannelupgrade' of github.com:firebase/fire…

66ed0bf

…base-js-sdk into khanrafi/webchannelupgrade

rafikhan requested a review from schmidt-sebastian September 1, 2020 23:20

rafikhan requested a review from zwu52 as a code owner September 1, 2020 23:20

schmidt-sebastian reviewed Sep 8, 2020

View reviewed changes

schmidt-sebastian assigned rafikhan Sep 8, 2020

Update packages/firestore/src/util/input_validation.ts

fb6a370

Co-authored-by: Sebastian Schmidt <[email protected]>

rafikhan requested review from a team as code owners September 8, 2020 20:21

schmidt-sebastian reviewed Sep 8, 2020

View reviewed changes

packages/firebase/index.d.ts Outdated Show resolved Hide resolved

rafikhan and others added 3 commits September 9, 2020 09:57

Update packages/firebase/index.d.ts

458c75a

Co-authored-by: Sebastian Schmidt <[email protected]>

Changing default to false

ecd8469

Fixing grammar

3c34f6d

schmidt-sebastian approved these changes Sep 29, 2020

View reviewed changes

packages/firestore/src/core/database_info.ts Outdated Show resolved Hide resolved

packages/firestore/test/integration/api/database.test.ts Outdated Show resolved Hide resolved

schmidt-sebastian assigned rafikhan and unassigned schmidt-sebastian Sep 29, 2020

rafikhan and others added 3 commits September 29, 2020 14:53

Update packages/firestore/src/core/database_info.ts

9f756ad

Co-authored-by: Sebastian Schmidt <[email protected]>

Update packages/firestore/test/integration/api/database.test.ts

94095b7

Co-authored-by: Sebastian Schmidt <[email protected]>

Create yellow-turkeys-lay.md

500b3d9

rafikhan assigned schmidt-sebastian and unassigned rafikhan Sep 29, 2020

schmidt-sebastian reviewed Sep 30, 2020

View reviewed changes

.changeset/yellow-turkeys-lay.md Outdated Show resolved Hide resolved

schmidt-sebastian approved these changes Sep 30, 2020

View reviewed changes

.changeset/yellow-turkeys-lay.md Outdated Show resolved Hide resolved

schmidt-sebastian assigned rafikhan and unassigned schmidt-sebastian Sep 30, 2020

rafikhan and others added 2 commits September 30, 2020 10:07

Update .changeset/yellow-turkeys-lay.md

2eeffd2

Co-authored-by: Sebastian Schmidt <[email protected]>

Update .changeset/yellow-turkeys-lay.md

490c0ef

Co-authored-by: Sebastian Schmidt <[email protected]>

hsubox76 reviewed Oct 6, 2020

View reviewed changes

.changeset/yellow-turkeys-lay.md Show resolved Hide resolved

hsubox76 requested a review from egilmorez October 6, 2020 17:57

egilmorez approved these changes Oct 6, 2020

View reviewed changes

packages/firebase/index.d.ts Outdated Show resolved Hide resolved

zwu52 approved these changes Oct 6, 2020

View reviewed changes

rafikhan added 2 commits October 6, 2020 12:14

Update index.d.ts

ed94332

Adding back-ticks for literal

Update yellow-turkeys-lay.md

1b10fb5

Bumping firebase minor version

hsubox76 approved these changes Oct 6, 2020

View reviewed changes

rafikhan added 2 commits October 7, 2020 08:50

Merge branch 'master' of github.com:firebase/firebase-js-sdk into kha…

64fa5fb

…nrafi/webchannelupgrade

Updating unit test to contain proper error string

c972e4c

rafikhan merged commit 4f997bc into master Oct 8, 2020

google-oss-bot mentioned this pull request Oct 13, 2020

Version Packages #3936

Merged

firebase locked and limited conversation to collaborators Nov 8, 2020

rafikhan deleted the khanrafi/webchannelupgrade branch November 11, 2020 21:44

Adding experimentalAutoDetectLongPolling #3724

Adding experimentalAutoDetectLongPolling #3724

Conversation

rafikhan commented Sep 1, 2020

google-oss-bot commented Sep 1, 2020 • edited Loading

Size Analysis Report

Affected Products

@firebase/app-exp

SDK_VERSION

Size

_DEFAULT_ENTRY_NAME

Size

_addComponent

Size

_addOrOverwriteComponent

Size

_apps

Size

_clearComponents

Size

_components

Size

_getProvider

Size

_registerComponent

Size

_removeServiceInstance

Size

deleteApp

Size

getApp

Size

getApps

Size

initializeApp

Size

onLog

Size

registerVersion

Size

setLogLevel

Size

@firebase/auth-exp

ActionCodeURL

Size

AuthCredential

Size

EmailAuthCredential

Size

EmailAuthProvider

Size

FacebookAuthProvider

Size

GithubAuthProvider

Size

GoogleAuthProvider

Size

OAuthCredential

Size

OAuthProvider

Size

PhoneAuthCredential

Size

PhoneAuthProvider

Size

PhoneMultiFactorGenerator

Size

RecaptchaVerifier

Size

TwitterAuthProvider

Size

applyActionCode

Size

browserLocalPersistence

Size

browserPopupRedirectResolver

Size

browserSessionPersistence

Size

checkActionCode

google-oss-bot commented Sep 1, 2020 •

edited

Loading

`@firebase/app-exp`

`SDK_VERSION`

`_DEFAULT_ENTRY_NAME`

`_addComponent`

`_addOrOverwriteComponent`

`_apps`

`_clearComponents`

`_components`

`_getProvider`

`_registerComponent`

`_removeServiceInstance`

`deleteApp`

`getApp`

`getApps`

`initializeApp`

`onLog`

`registerVersion`

`setLogLevel`

`@firebase/auth-exp`

`ActionCodeURL`

`AuthCredential`

`EmailAuthCredential`

`EmailAuthProvider`

`FacebookAuthProvider`

`GithubAuthProvider`

`GoogleAuthProvider`

`OAuthCredential`

`OAuthProvider`

`PhoneAuthCredential`

`PhoneAuthProvider`

`PhoneMultiFactorGenerator`

`RecaptchaVerifier`

`TwitterAuthProvider`

`applyActionCode`

`browserLocalPersistence`

`browserPopupRedirectResolver`

`browserSessionPersistence`

`checkActionCode`

`confirmPasswordReset`

`createUserWithEmailAndPassword`

`deleteUser`

`fetchSignInMethodsForEmail`

`getAdditionalUserInfo`

`getAuth`

`getIdToken`

`getIdTokenResult`

`getMultiFactorResolver`

`getRedirectResult`

`inMemoryPersistence`

`indexedDBLocalPersistence`

`initializeAuth`

`isSignInWithEmailLink`

`linkWithCredential`

`linkWithPhoneNumber`

`linkWithPopup`

`linkWithRedirect`

`multiFactor`

`onAuthStateChanged`

`onIdTokenChanged`

`parseActionCodeURL`

`reauthenticateWithCredential`

`reauthenticateWithPhoneNumber`

`reauthenticateWithPopup`

`reauthenticateWithRedirect`

`reload`

`sendEmailVerification`

`sendPasswordResetEmail`

`sendSignInLinkToEmail`

`setPersistence`

`signInAnonymously`