Skip to content

Tree-Shake RemoteStore #3705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2020
Merged

Tree-Shake RemoteStore #3705

merged 2 commits into from
Sep 8, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

This is purely mechanical change with no logic changes.

Goal is to make diff of #3568 smaller.

@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2020 •
edited
Loading

💥 No Changeset

Latest commit: 101f28c

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 28, 2020 •
edited
Loading

Size Analysis Report

Affected Products

@firebase/installations-exp

  • deleteInstallations

    Size

    Type Base (caed9c0) Head (59c201b) Diff
    size ? 8.90 kB ? (?)
    size_with_ext_deps ? 17.3 kB ? (?)

    Dependencies

    Type Base (caed9c0) Head (59c201b) Diff
    functions ?
    Click to show 52 depsbroadcastFidChange
    bufferToBase64UrlSafe
    callFidChangeCallbacks
    clearTimedOutRequest
    closeBroadcastChannel
    completeInstallationRegistration
    createInstallationRequest
    deleteInstallationRequest
    deleteInstallations
    encode
    extractAppConfig
    extractAuthTokenInfoFromResponse
    fetchAuthTokenFromServer
    fidChanged
    generateAuthTokenRequest
    generateFid
    getAuthorizationHeader
    getBroadcastChannel
    getDbPromise
    getDeleteEndpoint
    getErrorFromResponse
    getExpiresInFromResponseExpiresIn
    getGenerateAuthTokenEndpoint
    getHeaders
    getHeadersWithAuth
    getId
    getInstallationEntry
    getInstallationsEndpoint
    getKey
    getMissingValueError
    getToken
    hasAuthTokenRequestTimedOut
    hasInstallationRequestTimedOut
    isAuthTokenExpired
    isAuthTokenValid
    isEntryRegistered
    isServerError
    makeAuthTokenRequestInProgressEntry
    refreshAuthToken
    registerInstallation
    registerInstallations
    remove
    retryIfServerError
    set
    sleep
    triggerRegistrationIfNecessary
    update
    updateAuthTokenRequest
    updateInstallationRequest
    updateOrCreateInstallationEntry
    waitUntilAuthTokenRequest
    waitUntilFidRegistration
    		 ?
    variables ?
    Click to show 23 depsDATABASE_NAME
    DATABASE_VERSION
    ERROR_DESCRIPTION_MAP
    ERROR_FACTORY
    INSTALLATIONS_API_URL
    INSTALLATIONS_NAME
    INSTALLATIONS_NAME_INTERNAL
    INTERNAL_AUTH_VERSION
    INVALID_FID
    OBJECT_STORE_NAME
    PACKAGE_VERSION
    PENDING_TIMEOUT_MS
    SERVICE
    SERVICE_NAME
    TOKEN_EXPIRATION_BUFFER
    VALID_FID_PATTERN
    broadcastChannel
    dbPromise
    fidChangeCallbacks
    internalFactory
    name
    publicFactory
    version
    		 ?

    External Dependencies

    Module Base (caed9c0) Head (59c201b) Diff
    @firebase/util ? ErrorFactory
    FirebaseError    		 ?
    idb ? openDb ?
    @firebase/app-exp ? _getProvider
    _registerComponent
    registerVersion    		 ?
    @firebase/component ? Component ?

  • getId

    Size

    Type Base (caed9c0) Head (59c201b) Diff
    size ? 8.34 kB ? (?)
    size_with_ext_deps ? 16.8 kB ? (?)

    Dependencies

    Type Base (caed9c0) Head (59c201b) Diff
    functions ?
    Click to show 49 depsbroadcastFidChange
    bufferToBase64UrlSafe
    callFidChangeCallbacks
    clearTimedOutRequest
    closeBroadcastChannel
    completeInstallationRegistration
    createInstallationRequest
    encode
    extractAppConfig
    extractAuthTokenInfoFromResponse
    fetchAuthTokenFromServer
    fidChanged
    generateAuthTokenRequest
    generateFid
    getAuthorizationHeader
    getBroadcastChannel
    getDbPromise
    getErrorFromResponse
    getExpiresInFromResponseExpiresIn
    getGenerateAuthTokenEndpoint
    getHeaders
    getHeadersWithAuth
    getId
    getInstallationEntry
    getInstallationsEndpoint
    getKey
    getMissingValueError
    getToken
    hasAuthTokenRequestTimedOut
    hasInstallationRequestTimedOut
    isAuthTokenExpired
    isAuthTokenValid
    isEntryRegistered
    isServerError
    makeAuthTokenRequestInProgressEntry
    refreshAuthToken
    registerInstallation
    registerInstallations
    remove
    retryIfServerError
    set
    sleep
    triggerRegistrationIfNecessary
    update
    updateAuthTokenRequest
    updateInstallationRequest
    updateOrCreateInstallationEntry
    waitUntilAuthTokenRequest
    waitUntilFidRegistration
    		 ?
    variables ?
    Click to show 23 depsDATABASE_NAME
    DATABASE_VERSION
    ERROR_DESCRIPTION_MAP
    ERROR_FACTORY
    INSTALLATIONS_API_URL
    INSTALLATIONS_NAME
    INSTALLATIONS_NAME_INTERNAL
    INTERNAL_AUTH_VERSION
    INVALID_FID
    OBJECT_STORE_NAME
    PACKAGE_VERSION
    PENDING_TIMEOUT_MS
    SERVICE
    SERVICE_NAME
    TOKEN_EXPIRATION_BUFFER
    VALID_FID_PATTERN
    broadcastChannel
    dbPromise
    fidChangeCallbacks
    internalFactory
    name
    publicFactory
    version
    		 ?

    External Dependencies

    Module Base (caed9c0) Head (59c201b) Diff
    @firebase/util ? ErrorFactory
    FirebaseError    		 ?
    idb ? openDb ?
    @firebase/app-exp ? _getProvider
    _registerComponent
    registerVersion    		 ?
    @firebase/component ? Component ?

  • getInstallations

    Size

    Type Base (caed9c0) Head (59c201b) Diff
    size ? 8.43 kB ? (?)
    size_with_ext_deps ? 16.9 kB ? (?)

    Dependencies

    Type Base (caed9c0) Head (59c201b) Diff
    functions ?
    Click to show 50 depsbroadcastFidChange
    bufferToBase64UrlSafe
    callFidChangeCallbacks
    clearTimedOutRequest
    closeBroadcastChannel
    completeInstallationRegistration
    createInstallationRequest
    encode
    extractAppConfig
    extractAuthTokenInfoFromResponse
    fetchAuthTokenFromServer
    fidChanged
    generateAuthTokenRequest
    generateFid
    getAuthorizationHeader
    getBroadcastChannel
    getDbPromise
    getErrorFromResponse
    getExpiresInFromResponseExpiresIn
    getGenerateAuthTokenEndpoint
    getHeaders
    getHeadersWithAuth
    getId
    getInstallationEntry
    getInstallations
    getInstallationsEndpoint
    getKey
    getMissingValueError
    getToken
    hasAuthTokenRequestTimedOut
    hasInstallationRequestTimedOut
    isAuthTokenExpired
    isAuthTokenValid
    isEntryRegistered
    isServerError
    makeAuthTokenRequestInProgressEntry
    refreshAuthToken
    registerInstallation
    registerInstallations
    remove
    retryIfServerError
    set
    sleep
    triggerRegistrationIfNecessary
    update
    updateAuthTokenRequest
    updateInstallationRequest
    updateOrCreateInstallationEntry
    waitUntilAuthTokenRequest
    waitUntilFidRegistration
    		 ?
    variables ?
    Click to show 23 depsDATABASE_NAME
    DATABASE_VERSION
    ERROR_DESCRIPTION_MAP
    ERROR_FACTORY
    INSTALLATIONS_API_URL
    INSTALLATIONS_NAME
    INSTALLATIONS_NAME_INTERNAL
    INTERNAL_AUTH_VERSION
    INVALID_FID
    OBJECT_STORE_NAME
    PACKAGE_VERSION
    PENDING_TIMEOUT_MS
    SERVICE
    SERVICE_NAME
    TOKEN_EXPIRATION_BUFFER
    VALID_FID_PATTERN
    broadcastChannel
    dbPromise
    fidChangeCallbacks
    internalFactory
    name
    publicFactory
    version
    		 ?

    External Dependencies

    Module Base (caed9c0) Head (59c201b) Diff
    @firebase/util ? ErrorFactory
    FirebaseError    		 ?
    idb ? openDb ?
    @firebase/app-exp ? _getProvider
    _registerComponent
    registerVersion    		 ?
    @firebase/component ? Component ?

  • getToken

    Size

    Type Base (caed9c0) Head (59c201b) Diff
    size ? 8.35 kB ? (?)
    size_with_ext_deps ? 16.8 kB ? (?)

    Dependencies

    Type Base (caed9c0) Head (59c201b) Diff
    functions ?
    Click to show 49 depsbroadcastFidChange
    bufferToBase64UrlSafe
    callFidChangeCallbacks
    clearTimedOutRequest
    closeBroadcastChannel
    completeInstallationRegistration
    createInstallationRequest
    encode
    extractAppConfig
    extractAuthTokenInfoFromResponse
    fetchAuthTokenFromServer
    fidChanged
    generateAuthTokenRequest
    generateFid
    getAuthorizationHeader
    getBroadcastChannel
    getDbPromise
    getErrorFromResponse
    getExpiresInFromResponseExpiresIn
    getGenerateAuthTokenEndpoint
    getHeaders
    getHeadersWithAuth
    getId
    getInstallationEntry
    getInstallationsEndpoint
    getKey
    getMissingValueError
    getToken
    hasAuthTokenRequestTimedOut
    hasInstallationRequestTimedOut
    isAuthTokenExpired
    isAuthTokenValid
    isEntryRegistered
    isServerError
    makeAuthTokenRequestInProgressEntry
    refreshAuthToken
    registerInstallation
    registerInstallations
    remove
    retryIfServerError
    set
    sleep
    triggerRegistrationIfNecessary
    update
    updateAuthTokenRequest
    updateInstallationRequest
    updateOrCreateInstallationEntry
    waitUntilAuthTokenRequest
    waitUntilFidRegistration
    		 ?
    variables ?
    Click to show 23 depsDATABASE_NAME
    DATABASE_VERSION
    ERROR_DESCRIPTION_MAP
    ERROR_FACTORY
    INSTALLATIONS_API_URL
    INSTALLATIONS_NAME
    INSTALLATIONS_NAME_INTERNAL
    INTERNAL_AUTH_VERSION
    INVALID_FID
    OBJECT_STORE_NAME
    PACKAGE_VERSION
    PENDING_TIMEOUT_MS
    SERVICE
    SERVICE_NAME
    TOKEN_EXPIRATION_BUFFER
    VALID_FID_PATTERN
    broadcastChannel
    dbPromise
    fidChangeCallbacks
    internalFactory
    name
    publicFactory
    version
    		 ?

    External Dependencies

    Module Base (caed9c0) Head (59c201b) Diff
    @firebase/util ? ErrorFactory
    FirebaseError    		 ?
    idb ? openDb ?
    @firebase/app-exp ? _getProvider
    _registerComponent
    registerVersion    		 ?
    @firebase/component ? Component ?

  • onIdChange

    Size

    Type Base (caed9c0) Head (59c201b) Diff
    size ? 8.60 kB ? (?)
    size_with_ext_deps ? 17.0 kB ? (?)

    Dependencies

    Type Base (caed9c0) Head (59c201b) Diff
    functions ?
    Click to show 52 depsaddCallback
    broadcastFidChange
    bufferToBase64UrlSafe
    callFidChangeCallbacks
    clearTimedOutRequest
    closeBroadcastChannel
    completeInstallationRegistration
    createInstallationRequest
    encode
    extractAppConfig
    extractAuthTokenInfoFromResponse
    fetchAuthTokenFromServer
    fidChanged
    generateAuthTokenRequest
    generateFid
    getAuthorizationHeader
    getBroadcastChannel
    getDbPromise
    getErrorFromResponse
    getExpiresInFromResponseExpiresIn
    getGenerateAuthTokenEndpoint
    getHeaders
    getHeadersWithAuth
    getId
    getInstallationEntry
    getInstallationsEndpoint
    getKey
    getMissingValueError
    getToken
    hasAuthTokenRequestTimedOut
    hasInstallationRequestTimedOut
    isAuthTokenExpired
    isAuthTokenValid
    isEntryRegistered
    isServerError
    makeAuthTokenRequestInProgressEntry
    onIdChange
    refreshAuthToken
    registerInstallation
    registerInstallations
    remove
    removeCallback
    retryIfServerError
    set
    sleep
    triggerRegistrationIfNecessary
    update
    updateAuthTokenRequest
    updateInstallationRequest
    updateOrCreateInstallationEntry
    waitUntilAuthTokenRequest
    waitUntilFidRegistration
    		 ?
    variables ?
    Click to show 23 depsDATABASE_NAME
    DATABASE_VERSION
    ERROR_DESCRIPTION_MAP
    ERROR_FACTORY
    INSTALLATIONS_API_URL
    INSTALLATIONS_NAME
    INSTALLATIONS_NAME_INTERNAL
    INTERNAL_AUTH_VERSION
    INVALID_FID
    OBJECT_STORE_NAME
    PACKAGE_VERSION
    PENDING_TIMEOUT_MS
    SERVICE
    SERVICE_NAME
    TOKEN_EXPIRATION_BUFFER
    VALID_FID_PATTERN
    broadcastChannel
    dbPromise
    fidChangeCallbacks
    internalFactory
    name
    publicFactory
    version
    		 ?

    External Dependencies

    Module Base (caed9c0) Head (59c201b) Diff
    @firebase/util ? ErrorFactory
    FirebaseError    		 ?
    idb ? openDb ?
    @firebase/app-exp ? _getProvider
    _registerComponent
    registerVersion    		 ?
    @firebase/component ? Component ?

Test Logs

wu-hui
wu-hui reviewed Sep 2, 2020
View reviewed changes
packages/firestore/src/core/component_provider.ts Outdated
@@ -37,7 +37,13 @@ import {
newSyncEngine,
SyncEngine
} from './sync_engine';
import { RemoteStore } from '../remote/remote_store';
import {
fillWritePipeline,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove if this lint error is correct.

wu-hui
wu-hui approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lint error about a un-used import.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/analytics

    Type Base (caed9c0) Head (59c201b) Diff
    esm2017 ? 9.89 kB ? (?)
    main ? 11.2 kB ? (?)
    module ? 10.8 kB ? (?)

  • @firebase/app

    Type Base (caed9c0) Head (59c201b) Diff
    browser ? 11.1 kB ? (?)
    esm2017 ? 9.46 kB ? (?)
    lite ? 9.11 kB ? (?)
    lite-esm2017 ? 7.75 kB ? (?)
    main ? 10.2 kB ? (?)
    module ? 11.0 kB ? (?)
    react-native ? 9.87 kB ? (?)

  • @firebase/auth

    Type Base (caed9c0) Head (59c201b) Diff
    browser ? 177 kB ? (?)
    main ? 177 kB ? (?)
    module ? 177 kB ? (?)

  • @firebase/component

    Type Base (caed9c0) Head (59c201b) Diff
    browser ? 5.30 kB ? (?)
    esm2017 ? 3.98 kB ? (?)
    main ? 5.30 kB ? (?)
    module ? 5.18 kB ? (?)

  • @firebase/database

    Type Base (caed9c0) Head (59c201b) Diff
    browser ? 269 kB ? (?)
    esm2017 ? 236 kB ? (?)
    main ? 270 kB ? (?)
    module ? 268 kB ? (?)

  • @firebase/firestore

    Type Base (caed9c0) Head (59c201b) Diff
    browser ? 248 kB ? (?)
    esm2017 ? 196 kB ? (?)
    main ? 482 kB ? (?)
    module ? 246 kB ? (?)
    react-native ? 196 kB ? (?)

  • @firebase/firestore/exp

    Type Base (caed9c0) Head (59c201b) Diff
    browser ? 189 kB ? (?)
    main ? 474 kB ? (?)
    module ? 189 kB ? (?)
    react-native ? 189 kB ? (?)

  • @firebase/firestore/lite

    Type Base (caed9c0) Head (59c201b) Diff
    browser ? 64.3 kB ? (?)
    main ? 142 kB ? (?)
    module ? 64.3 kB ? (?)
    react-native ? 64.6 kB ? (?)

  • @firebase/firestore/memory

    Type Base (caed9c0) Head (59c201b) Diff
    browser ? 186 kB ? (?)
    esm2017 ? 147 kB ? (?)
    main ? 356 kB ? (?)
    module ? 184 kB ? (?)
    react-native ? 147 kB ? (?)

  • @firebase/functions

    Type Base (caed9c0) Head (59c201b) Diff
    browser ? 9.73 kB ? (?)
    esm2017 ? 7.31 kB ? (?)
    main ? 9.77 kB ? (?)
    module ? 9.46 kB ? (?)

  • @firebase/installations

    Type Base (caed9c0) Head (59c201b) Diff
    esm2017 ? 16.5 kB ? (?)
    main ? 22.1 kB ? (?)
    module ? 21.5 kB ? (?)

  • @firebase/logger

    Type Base (caed9c0) Head (59c201b) Diff
    esm2017 ? 3.25 kB ? (?)
    main ? 5.14 kB ? (?)
    module ? 4.83 kB ? (?)

  • @firebase/messaging

    Type Base (caed9c0) Head (59c201b) Diff
    esm2017 ? 25.9 kB ? (?)
    main ? 34.7 kB ? (?)
    module ? 34.2 kB ? (?)

  • @firebase/performance

    Type Base (caed9c0) Head (59c201b) Diff
    browser ? 27.4 kB ? (?)
    esm2017 ? 25.4 kB ? (?)
    main ? 27.4 kB ? (?)
    module ? 27.1 kB ? (?)

  • @firebase/polyfill

    Type Base (caed9c0) Head (59c201b) Diff
    main ? 775 B ? (?)
    module ? 705 B ? (?)

  • @firebase/remote-config

    Type Base (caed9c0) Head (59c201b) Diff
    browser ? 23.2 kB ? (?)
    esm2017 ? 17.7 kB ? (?)
    main ? 23.2 kB ? (?)
    module ? 22.7 kB ? (?)

  • @firebase/rules-unit-testing

    Type Base (caed9c0) Head (59c201b) Diff
    main ? 7.28 kB ? (?)

  • @firebase/storage

    Type Base (caed9c0) Head (59c201b) Diff
    esm2017 ? 54.9 kB ? (?)
    main ? 61.4 kB ? (?)
    module ? 61.1 kB ? (?)

  • @firebase/testing

    Type Base (caed9c0) Head (59c201b) Diff
    main ? 6.35 kB ? (?)

  • @firebase/util

    Type Base (caed9c0) Head (59c201b) Diff
    browser ? 20.5 kB ? (?)
    esm2017 ? 18.3 kB ? (?)
    main ? 20.5 kB ? (?)
    module ? 19.5 kB ? (?)

  • @firebase/webchannel-wrapper

    Type Base (caed9c0) Head (59c201b) Diff
    esm2017 ? 39.4 kB ? (?)
    main ? 41.0 kB ? (?)
    module ? 40.6 kB ? (?)

  • firebase

    Click to show 15 binary size changes.
    Type Base (caed9c0) Head (59c201b) Diff
    firebase-analytics.js ? 28.3 kB ? (?)
    firebase-app.js ? 20.1 kB ? (?)
    firebase-auth.js ? 174 kB ? (?)
    firebase-database.js ? 186 kB ? (?)
    firebase-firestore.js ? 286 kB ? (?)
    firebase-firestore.memory.js ? 226 kB ? (?)
    firebase-functions.js ? 9.93 kB ? (?)
    firebase-installations.js ? 19.2 kB ? (?)
    firebase-messaging.js ? 41.0 kB ? (?)
    firebase-performance-standalone.es2017.js ? 71.3 kB ? (?)
    firebase-performance-standalone.js ? 48.0 kB ? (?)
    firebase-performance.js ? 38.4 kB ? (?)
    firebase-remote-config.js ? 37.1 kB ? (?)
    firebase-storage.js ? 39.9 kB ? (?)
    firebase.js ? 821 kB ? (?)

Test Logs

@schmidt-sebastian schmidt-sebastian merged commit cc16b4a into master Sep 8, 2020
@firebase firebase locked and limited conversation to collaborators Oct 9, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/treeshakeremotestore branch November 9, 2020 22:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@wu-hui wu-hui

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @wu-hui