-
Notifications
You must be signed in to change notification settings - Fork 926
Rename Blob to Bytes #3677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Blob to Bytes #3677
Conversation
💥 No ChangesetLatest commit: de845b6 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! I really tried to find nits, but I couldn't
this._byteString = byteString; | ||
} | ||
|
||
export class Blob extends Bytes { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional: It might be helpful to add some context in comments about why the main SDK's Blob
is extending the Bytes
class in the Lite SDK. It's clear to me what's happening when I look at the PR description, but without it, I would be confused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (but missed this before merging - coming in the next PR).
As part of go/firestore-next-amendment-amendment, we decided to rename Blob to Bytes to avoid name clashes with the JavaScript Blob type.
Couple notes: