Skip to content

Update dependency typescript to v4 #3669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Update dependency typescript to v4 #3669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e19835e
Update dependency typescript to v4
renovate-bot Aug 25, 2020
3020f96
fix typescript errors
Feiyang1 Aug 25, 2020
33cc181
Merge branch 'master' into renovate/typescript-4.x
Feiyang1 Aug 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integration/firebase/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
"karma-typescript": "5.1.0",
"mocha": "7.2.0",
"npm-run-all": "4.1.5",
"typescript": "3.9.7"
"typescript": "4.0.2"
}
}
2 changes: 1 addition & 1 deletion integration/firestore/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"karma-spec-reporter": "0.0.32",
"mocha": "7.2.0",
"ts-loader": "8.0.3",
"typescript": "3.9.7",
"typescript": "4.0.2",
"webpack": "4.44.1",
"webpack-stream": "5.2.1"
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@
"ts-node": "8.10.2",
"tslint": "6.1.3",
"typedoc": "0.16.11",
"typescript": "3.9.7",
"typescript": "4.0.2",
"watch": "1.0.2",
"webpack": "4.44.1",
"yargs": "15.4.1"
Expand Down
2 changes: 1 addition & 1 deletion packages-exp/app-exp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"rollup-plugin-json": "4.0.0",
"rollup-plugin-replace": "2.2.0",
"rollup-plugin-typescript2": "0.27.2",
"typescript": "3.9.7"
"typescript": "4.0.2"
},
"repository": {
"directory": "packages-exp/app-exp",
Expand Down
2 changes: 1 addition & 1 deletion packages-exp/app-types-exp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@
"url": "https://github.com/firebase/firebase-js-sdk/issues"
},
"devDependencies": {
"typescript": "3.9.7"
"typescript": "4.0.2"
}
}
2 changes: 1 addition & 1 deletion packages-exp/firebase-exp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"gulp": "4.0.2",
"gulp-sourcemaps": "2.6.5",
"gulp-concat": "2.6.1",
"typescript": "3.9.7"
"typescript": "4.0.2"
},
"components": [
"app",
Expand Down
2 changes: 1 addition & 1 deletion packages-exp/functions-exp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@firebase/app-exp": "0.0.800",
"rollup": "2.26.5",
"rollup-plugin-typescript2": "0.27.2",
"typescript": "3.9.7"
"typescript": "4.0.2"
},
"repository": {
"directory": "packages/functions",
Expand Down
2 changes: 1 addition & 1 deletion packages-exp/functions-types-exp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@
"url": "https://github.com/firebase/firebase-js-sdk/issues"
},
"devDependencies": {
"typescript": "3.9.7"
"typescript": "4.0.2"
}
}
2 changes: 1 addition & 1 deletion packages/analytics-interop-types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@
"url": "https://github.com/firebase/firebase-js-sdk/issues"
},
"devDependencies": {
"typescript": "3.9.7"
"typescript": "4.0.2"
}
}
2 changes: 1 addition & 1 deletion packages/analytics-types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@
"url": "https://github.com/firebase/firebase-js-sdk/issues"
},
"devDependencies": {
"typescript": "3.9.7"
"typescript": "4.0.2"
}
}
2 changes: 1 addition & 1 deletion packages/analytics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"rollup-plugin-node-resolve": "5.2.0",
"rollup-plugin-typescript2": "0.27.2",
"rollup-plugin-uglify": "6.0.4",
"typescript": "3.9.7"
"typescript": "4.0.2"
},
"repository": {
"directory": "packages/analytics",
Expand Down
2 changes: 1 addition & 1 deletion packages/app-types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@
"url": "https://github.com/firebase/firebase-js-sdk/issues"
},
"devDependencies": {
"typescript": "3.9.7"
"typescript": "4.0.2"
}
}
2 changes: 1 addition & 1 deletion packages/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"rollup-plugin-json": "4.0.0",
"rollup-plugin-replace": "2.2.0",
"rollup-plugin-typescript2": "0.27.2",
"typescript": "3.9.7"
"typescript": "4.0.2"
},
"repository": {
"directory": "packages/app",
Expand Down
2 changes: 1 addition & 1 deletion packages/auth-interop-types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"url": "https://github.com/firebase/firebase-js-sdk/issues"
},
"devDependencies": {
"typescript": "3.9.7"
"typescript": "4.0.2"
}
}
2 changes: 1 addition & 1 deletion packages/auth-types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"url": "https://github.com/firebase/firebase-js-sdk/issues"
},
"devDependencies": {
"typescript": "3.9.7"
"typescript": "4.0.2"
}
}
2 changes: 1 addition & 1 deletion packages/component/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"devDependencies": {
"rollup": "2.26.5",
"rollup-plugin-typescript2": "0.27.2",
"typescript": "3.9.7"
"typescript": "4.0.2"
},
"repository": {
"directory": "packages/component",
Expand Down
2 changes: 1 addition & 1 deletion packages/database-types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
"url": "https://github.com/firebase/firebase-js-sdk/issues"
},
"devDependencies": {
"typescript": "3.9.7"
"typescript": "4.0.2"
}
}
2 changes: 1 addition & 1 deletion packages/database/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@firebase/app-types": "0.6.1",
"rollup": "2.26.5",
"rollup-plugin-typescript2": "0.27.2",
"typescript": "3.9.7"
"typescript": "4.0.2"
},
"repository": {
"directory": "packages/database",
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"rollup-plugin-terser": "6.1.0",
"rollup-plugin-typescript2": "0.27.2",
"rollup-plugin-uglify": "6.0.4",
"typescript": "3.9.7"
"typescript": "4.0.2"
},
"typings": "index.d.ts",
"components": [
Expand Down
2 changes: 1 addition & 1 deletion packages/firestore-types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
"url": "https://github.com/firebase/firebase-js-sdk/issues"
},
"devDependencies": {
"typescript": "3.9.7"
"typescript": "4.0.2"
}
}
2 changes: 1 addition & 1 deletion packages/firestore/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
"rollup-plugin-terser": "6.1.0",
"rollup-plugin-typescript2": "0.27.2",
"ts-node": "8.10.2",
"typescript": "3.9.7"
"typescript": "4.0.2"
},
"repository": {
"directory": "packages/firestore",
Expand Down
22 changes: 22 additions & 0 deletions packages/firestore/test/integration/api/query.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,8 +706,11 @@ apiDescribe('Queries', (persistence: boolean) => {

await withTestCollection(persistence, testDocs, async coll => {
let expected = { ...testDocs };
// @ts-expect-error
delete expected.a;
// @ts-expect-error
delete expected.h;
// @ts-expect-error
delete expected.i;
const snapshot = await coll.where('zip', notEqualOp, 98101).get();
expect(toDataArray(snapshot)).to.have.deep.members(
Expand All @@ -719,8 +722,11 @@ apiDescribe('Queries', (persistence: boolean) => {
.where('zip', notEqualOp, { code: 500 })
.get();
expected = { ...testDocs };
// @ts-expect-error
delete expected.f;
// @ts-expect-error
delete expected.h;
// @ts-expect-error
delete expected.i;
expect(toDataArray(snapshot2)).to.have.deep.members(
Object.values(expected)
Expand All @@ -729,7 +735,9 @@ apiDescribe('Queries', (persistence: boolean) => {
// With null.
const snapshot3 = await coll.where('zip', notEqualOp, null).get();
expected = { ...testDocs };
// @ts-expect-error
delete expected.h;
// @ts-expect-error
delete expected.i;
expect(toDataArray(snapshot3)).to.have.deep.members(
Object.values(expected)
Expand All @@ -738,8 +746,11 @@ apiDescribe('Queries', (persistence: boolean) => {
// With NaN.
const snapshot4 = await coll.where('zip', notEqualOp, Number.NaN).get();
expected = { ...testDocs };
// @ts-expect-error
delete expected.h;
// @ts-expect-error
delete expected.i;
// @ts-expect-error
delete expected.j;
expect(toDataArray(snapshot4)).to.have.deep.members(
Object.values(expected)
Expand Down Expand Up @@ -859,9 +870,13 @@ apiDescribe('Queries', (persistence: boolean) => {

await withTestCollection(persistence, testDocs, async coll => {
let expected = { ...testDocs };
// @ts-expect-error
delete expected.a;
// @ts-expect-error
delete expected.c;
// @ts-expect-error
delete expected.g;
// @ts-expect-error
delete expected.h;
const snapshot = await coll
.where('zip', notInOp, [98101, 98103, [98101, 98102]])
Expand All @@ -873,7 +888,9 @@ apiDescribe('Queries', (persistence: boolean) => {
.where('zip', notInOp, [{ code: 500 }])
.get();
expected = { ...testDocs };
// @ts-expect-error
delete expected.f;
// @ts-expect-error
delete expected.h;
expect(toDataArray(snapshot2)).to.deep.equal(Object.values(expected));

Expand All @@ -884,7 +901,9 @@ apiDescribe('Queries', (persistence: boolean) => {
// With NaN.
const snapshot4 = await coll.where('zip', notInOp, [Number.NaN]).get();
expected = { ...testDocs };
// @ts-expect-error
delete expected.h;
// @ts-expect-error
delete expected.j;
expect(toDataArray(snapshot4)).to.deep.equal(Object.values(expected));

Expand All @@ -893,8 +912,11 @@ apiDescribe('Queries', (persistence: boolean) => {
.where('zip', notInOp, [Number.NaN, 98101])
.get();
expected = { ...testDocs };
// @ts-expect-error
delete expected.a;
// @ts-expect-error
delete expected.h;
// @ts-expect-error
delete expected.j;
expect(toDataArray(snapshot5)).to.deep.equal(Object.values(expected));
});
Expand Down
2 changes: 1 addition & 1 deletion packages/functions-types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@
"url": "https://github.com/firebase/firebase-js-sdk/issues"
},
"devDependencies": {
"typescript": "3.9.7"
"typescript": "4.0.2"
}
}
2 changes: 1 addition & 1 deletion packages/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"@firebase/messaging": "0.7.0",
"rollup": "2.26.5",
"rollup-plugin-typescript2": "0.27.2",
"typescript": "3.9.7"
"typescript": "4.0.2"
},
"repository": {
"directory": "packages/functions",
Expand Down
2 changes: 1 addition & 1 deletion packages/installations-types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
"url": "https://github.com/firebase/firebase-js-sdk/issues"
},
"devDependencies": {
"typescript": "3.9.7"
"typescript": "4.0.2"
}
}
2 changes: 1 addition & 1 deletion packages/installations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"rollup-plugin-node-resolve": "5.2.0",
"rollup-plugin-typescript2": "0.27.2",
"rollup-plugin-uglify": "6.0.4",
"typescript": "3.9.7"
"typescript": "4.0.2"
},
"peerDependencies": {
"@firebase/app": "0.x",
Expand Down
2 changes: 2 additions & 0 deletions packages/installations/src/helpers/extract-app-config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,12 @@ describe('extractAppConfig', () => {
expect(() => extractAppConfig(undefined as any)).to.throw(FirebaseError);

let firebaseApp = getFakeApp();
// @ts-expect-error
delete firebaseApp.name;
expect(() => extractAppConfig(firebaseApp)).to.throw(FirebaseError);

firebaseApp = getFakeApp();
// @ts-expect-error
delete firebaseApp.options;
expect(() => extractAppConfig(firebaseApp)).to.throw(FirebaseError);

Expand Down
2 changes: 1 addition & 1 deletion packages/logger/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"devDependencies": {
"rollup": "2.26.5",
"rollup-plugin-typescript2": "0.27.2",
"typescript": "3.9.7"
"typescript": "4.0.2"
},
"repository": {
"directory": "packages/logger",
Expand Down
2 changes: 1 addition & 1 deletion packages/messaging-types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
"url": "https://github.com/firebase/firebase-js-sdk/issues"
},
"devDependencies": {
"typescript": "3.9.7"
"typescript": "4.0.2"
}
}
2 changes: 1 addition & 1 deletion packages/messaging/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"rollup": "2.26.5",
"rollup-plugin-typescript2": "0.27.2",
"ts-essentials": "7.0.0",
"typescript": "3.9.7"
"typescript": "4.0.2"
},
"repository": {
"directory": "packages/messaging",
Expand Down
2 changes: 2 additions & 0 deletions packages/messaging/src/helpers/extract-app-config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,14 @@ describe('extractAppConfig', () => {
).to.throw('Missing App configuration value: "App Configuration Object"');

let firebaseApp = getFakeApp();
// @ts-expect-error
delete firebaseApp.options;
expect(() => extractAppConfig(firebaseApp)).to.throw(
'Missing App configuration value: "App Configuration Object"'
);

firebaseApp = getFakeApp();
// @ts-expect-error
delete firebaseApp.name;
expect(() => extractAppConfig(firebaseApp)).to.throw(
'Missing App configuration value: "App Name"'
Expand Down
2 changes: 1 addition & 1 deletion packages/performance-types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"index.d.ts"
],
"devDependencies": {
"typescript": "3.9.7"
"typescript": "4.0.2"
},
"repository": {
"directory": "packages/performance-types",
Expand Down
2 changes: 1 addition & 1 deletion packages/performance/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"rollup": "2.26.5",
"rollup-plugin-json": "4.0.0",
"rollup-plugin-typescript2": "0.27.2",
"typescript": "3.9.7"
"typescript": "4.0.2"
},
"repository": {
"directory": "packages/performance",
Expand Down
2 changes: 1 addition & 1 deletion packages/remote-config-types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@
"url": "https://github.com/firebase/firebase-js-sdk/issues"
},
"devDependencies": {
"typescript": "3.9.7"
"typescript": "4.0.2"
}
}
2 changes: 1 addition & 1 deletion packages/remote-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@firebase/app": "0.6.10",
"rollup": "2.26.5",
"rollup-plugin-typescript2": "0.27.2",
"typescript": "3.9.7"
"typescript": "4.0.2"
},
"repository": {
"directory": "packages/remote-config",
Expand Down
Loading