Create @firebase/app-compat and firebase/compat #3622

Feiyang1 · 2020-08-12T20:41:46Z

No description provided.

changeset-bot · 2020-08-12T20:41:49Z

💥 No Changeset

Latest commit: cf06709

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2020-08-12T20:57:35Z

Binary Size Report

Affected SDKs

No changes between base commit (5d4d182) and head commit (cffa42a).

Test Logs

Base (5d4d1823): https://github.com/firebase/firebase-js-sdk/actions/runs/206345945
Head (cffa42a7): https://github.com/firebase/firebase-js-sdk/actions/runs/206534615

This reverts commit 97585c1.

packages-exp/app-compat/.npmignore

packages-exp/app-compat/karma.conf.js

packages-exp/app-compat/src/firebaseNamespaceCore.ts

packages-exp/app-compat/src/lite/firebaseAppLite.ts

packages-exp/app-compat/test/firebaseCompat.test.ts

packages-exp/firebase-exp/compat/index.cdn.ts

hsubox76

CI build failures look like @firebase/util version in package.json needs to be updated.

google-oss-bot · 2020-08-25T23:45:34Z

Size Analysis Report

Affected Products

`@firebase/app-exp`

`SDK_VERSION`

Size

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
size	2.58 kB	2.63 kB	+54 B (+2.1%)
size_with_ext_deps	3.99 kB	4.05 kB	+54 B (+1.4%)

Dependencies

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
variables	Click to show 21 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `SDK_VERSION` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version` `version$1`	Click to show 22 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `SDK_VERSION` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version` `version$1`	`+ name$d`

`_DEFAULT_ENTRY_NAME`

Size

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
size	?	2.63 kB	? (?)
size_with_ext_deps	?	4.05 kB	? (?)

Dependencies

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
functions	?	`_addComponent` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 21 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_DEFAULT_ENTRY_NAME` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	?

External Dependencies

Module	Base (`0d06863`)	Head (`640cbe9`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`_addComponent`

Size

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
size	2.55 kB	2.61 kB	+54 B (+2.1%)
size_with_ext_deps	3.97 kB	4.02 kB	+54 B (+1.4%)

Dependencies

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
variables	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	`+ name$d`

`_addOrOverwriteComponent`

Size

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
size	2.62 kB	2.67 kB	+54 B (+2.1%)
size_with_ext_deps	4.04 kB	4.09 kB	+54 B (+1.3%)

Dependencies

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
variables	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	`+ name$d`

`_apps`

Size

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
size	2.55 kB	2.60 kB	+54 B (+2.1%)
size_with_ext_deps	3.96 kB	4.02 kB	+54 B (+1.4%)

Dependencies

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
variables	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	`+ name$d`

`_clearComponents`

Size

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
size	2.58 kB	2.63 kB	+54 B (+2.1%)
size_with_ext_deps	4.00 kB	4.05 kB	+54 B (+1.4%)

Dependencies

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
variables	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	`+ name$d`

`_components`

Size

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
size	2.55 kB	2.61 kB	+54 B (+2.1%)
size_with_ext_deps	3.97 kB	4.02 kB	+54 B (+1.4%)

Dependencies

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
variables	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	`+ name$d`

`_getProvider`

Size

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
size	2.60 kB	2.66 kB	+54 B (+2.1%)
size_with_ext_deps	4.02 kB	4.07 kB	+54 B (+1.3%)

Dependencies

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
variables	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	`+ name$d`

`_registerComponent`

Size

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
size	2.56 kB	2.61 kB	+54 B (+2.1%)
size_with_ext_deps	3.97 kB	4.03 kB	+54 B (+1.4%)

Dependencies

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
variables	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	`+ name$d`

`_removeServiceInstance`

Size

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
size	2.68 kB	2.73 kB	+54 B (+2.0%)
size_with_ext_deps	4.09 kB	4.15 kB	+54 B (+1.3%)

Dependencies

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
variables	Click to show 20 deps `DEFAULT_ENTRY_NAME` `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	Click to show 21 deps `DEFAULT_ENTRY_NAME` `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	`+ name$d`

`deleteApp`

Size

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
size	2.69 kB	2.75 kB	+54 B (+2.0%)
size_with_ext_deps	4.11 kB	4.16 kB	+54 B (+1.3%)

Dependencies

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
variables	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	`+ name$d`

`getApp`

Size

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
size	2.65 kB	2.71 kB	+54 B (+2.0%)
size_with_ext_deps	5.34 kB	5.39 kB	+54 B (+1.0%)

Dependencies

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
variables	Click to show 20 deps `DEFAULT_ENTRY_NAME` `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	Click to show 21 deps `DEFAULT_ENTRY_NAME` `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	`+ name$d`

`getApps`

Size

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
size	2.59 kB	2.64 kB	+54 B (+2.1%)
size_with_ext_deps	4.01 kB	4.06 kB	+54 B (+1.3%)

Dependencies

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
variables	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	`+ name$d`

`initializeApp`

Size

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
size	3.64 kB	3.69 kB	+54 B (+1.5%)
size_with_ext_deps	8.94 kB	9.05 kB	+109 B (+1.2%)

Dependencies

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
variables	Click to show 20 deps `DEFAULT_ENTRY_NAME` `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	Click to show 21 deps `DEFAULT_ENTRY_NAME` `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	`+ name$d`

`onLog`

Size

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
size	2.68 kB	2.74 kB	+54 B (+2.0%)
size_with_ext_deps	5.89 kB	5.95 kB	+54 B (+0.9%)

Dependencies

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
variables	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	`+ name$d`

`registerVersion`

Size

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
size	2.56 kB	2.61 kB	+54 B (+2.1%)
size_with_ext_deps	3.97 kB	4.03 kB	+54 B (+1.4%)

Dependencies

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
variables	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	`+ name$d`

`setLogLevel`

Size

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
size	2.59 kB	2.64 kB	+54 B (+2.1%)
size_with_ext_deps	4.06 kB	4.11 kB	+54 B (+1.3%)

Dependencies

Type	Base (`0d06863`)	Head (`640cbe9`)	Diff
variables	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	`+ name$d`

`@firebase/functions-exp`

getFunctions

Size

Type Base (0d06863) Head (640cbe9) Diff

size 1.83 kB 1.83 kB +1 B (+0.1%)

size_with_ext_deps 5.66 kB 5.71 kB +55 B (+1.0%)
httpsCallable

Size

Type Base (0d06863) Head (640cbe9) Diff

size 5.20 kB 5.20 kB +1 B (+0.0%)

size_with_ext_deps 9.73 kB 9.79 kB +57 B (+0.6%)
useFunctionsEmulator

Size

Type Base (0d06863) Head (640cbe9) Diff

size 1.80 kB 1.80 kB +1 B (+0.1%)

size_with_ext_deps 5.59 kB 5.65 kB +55 B (+1.0%)

Test Logs

Base (0d068639): https://github.com/firebase/firebase-js-sdk/actions/runs/224444488
Head (640cbe9e): https://github.com/firebase/firebase-js-sdk/actions/runs/226150729

hsubox76 · 2020-08-26T19:06:15Z

packages/firestore/exp/src/api/components.ts

@@ -23,7 +23,7 @@ import {
  OfflineComponentProvider,
  OnlineComponentProvider
 } from '../../../src/core/component_provider';
-import {handleUserChange, LocalStore} from '../../../src/local/local_store';
+import { handleUserChange, LocalStore } from '../../../src/local/local_store';


Looks like this PR includes some prettier fixes not caught during firestore or rules-unit-testing commits somehow, do you want to include them here or in a separate PR?

Feiyang1 added 3 commits August 6, 2020 15:29

init package

aa84b26

app-compat impl

b2bf4f3

get tests pass

758300d

Feiyang1 requested review from hiranya911 and hsubox76 as code owners August 12, 2020 20:41

update some metadata

a23564f

Feiyang1 added 5 commits August 12, 2020 18:38

add firebase compat

7459712

release test

97585c1

build compat packages

0a1f9fe

fix npm scripts

f3fb5c7

Revert "release test"

2855391

This reverts commit 97585c1.

Feiyang1 assigned avolkovi and hsubox76 Aug 13, 2020

Merge branch 'master' into fei-compats

bcfccba

Feiyang1 changed the title ~~Create @firebase/app-compat~~ Create @firebase/app-compat and firebase/compat Aug 13, 2020

hsubox76 reviewed Aug 13, 2020

View reviewed changes

Feiyang1 added 3 commits August 13, 2020 15:57

remove npmignore and outdated license headers

a0dc5f3

add onLog and setLogLevel to app-compat

1b18018

rename test file

638455e

hsubox76 reviewed Aug 14, 2020

View reviewed changes

Merge branch 'master' into fei-compats

73a8b80

Feiyang1 requested review from avolkovi, sam-gc, scottcrossen and yuchenshi as code owners August 25, 2020 21:38

Feiyang1 added 3 commits August 25, 2020 16:28

update deps

0bae59d

Merge branch 'master' into fei-compats

7f8af0f

update

85ea281

revert

97dd08c

hsubox76 approved these changes Aug 26, 2020

View reviewed changes

add test:ci script

cf06709

Feiyang1 merged commit 1a82549 into master Aug 27, 2020

Feiyang1 deleted the fei-compats branch August 27, 2020 16:44

firebase locked and limited conversation to collaborators Sep 27, 2020

Create @firebase/app-compat and firebase/compat #3622

Create @firebase/app-compat and firebase/compat #3622

Conversation

Feiyang1 commented Aug 12, 2020

changeset-bot bot commented Aug 12, 2020 • edited Loading

💥 No Changeset

google-oss-bot commented Aug 12, 2020 • edited Loading

Binary Size Report

Affected SDKs

Test Logs

hsubox76 left a comment

Choose a reason for hiding this comment

google-oss-bot commented Aug 25, 2020 • edited Loading

Size Analysis Report

Affected Products

@firebase/app-exp

SDK_VERSION

Size

Dependencies

_DEFAULT_ENTRY_NAME

Size

Dependencies

External Dependencies

_addComponent

Size

Dependencies

_addOrOverwriteComponent

Size

Dependencies

_apps

Size

Dependencies

_clearComponents

Size

Dependencies

_components

Size

Dependencies

_getProvider

Size

Dependencies

_registerComponent

Size

Dependencies

_removeServiceInstance

Size

Dependencies

deleteApp

Size

Dependencies

getApp

Size

Dependencies

getApps

Size

Dependencies

initializeApp

Size

Dependencies

onLog

Size

Dependencies

registerVersion

Size

Dependencies

setLogLevel

Size

Dependencies

@firebase/functions-exp

getFunctions

Size

httpsCallable

Size

useFunctionsEmulator

Size

Test Logs

hsubox76 Aug 26, 2020

Choose a reason for hiding this comment

changeset-bot bot commented Aug 12, 2020 •

edited

Loading

google-oss-bot commented Aug 12, 2020 •

edited

Loading

google-oss-bot commented Aug 25, 2020 •

edited

Loading

`@firebase/app-exp`

`SDK_VERSION`

`_DEFAULT_ENTRY_NAME`

`_addComponent`

`_addOrOverwriteComponent`

`_apps`

`_clearComponents`

`_components`

`_getProvider`

`_registerComponent`

`_removeServiceInstance`

`deleteApp`

`getApp`

`getApps`

`initializeApp`

`onLog`

`registerVersion`

`setLogLevel`

`@firebase/functions-exp`

`getFunctions`

`httpsCallable`

`useFunctionsEmulator`