size analysis project - phase 2 #3610

XuechunHou · 2020-08-11T20:26:44Z

Build on top of phase 1.
Integrated with Github Action

changeset-bot · 2020-08-11T20:26:47Z

💥 No Changeset

Latest commit: 336fb17

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2020-08-11T20:40:21Z

Binary Size Report

Affected SDKs

No changes between base commit (8d3aca7) and head commit (515ea8b).

Test Logs

Base (8d3aca79): https://github.com/firebase/firebase-js-sdk/actions/runs/217175650
Head (515ea8b8): https://github.com/firebase/firebase-js-sdk/actions/runs/218547759

…into ida-size-analysis-phase-2

google-oss-bot · 2020-08-11T23:56:50Z

Size Analysis Report

Affected Products

`@firebase/app-exp`

`LogLevel`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	2.57 kB	? (?)
size_with_ext_deps	?	3.96 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	`_addComponent` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	?
enums	?	`LogLevel`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`SDK_VERSION`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	2.58 kB	? (?)
size_with_ext_deps	?	3.99 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	`_addComponent` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 21 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `SDK_VERSION` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version` `version$1`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`_addComponent`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	2.55 kB	? (?)
size_with_ext_deps	?	3.97 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	`_addComponent` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`_addOrOverwriteComponent`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	2.62 kB	? (?)
size_with_ext_deps	?	4.04 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	Click to show 6 deps `_addComponent` `_addOrOverwriteComponent` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`_apps`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	2.55 kB	? (?)
size_with_ext_deps	?	3.96 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	`_addComponent` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`_clearComponents`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	2.58 kB	? (?)
size_with_ext_deps	?	4.00 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	Click to show 6 deps `_addComponent` `_clearComponents` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`_components`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	2.55 kB	? (?)
size_with_ext_deps	?	3.97 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	`_addComponent` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`_getProvider`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	2.60 kB	? (?)
size_with_ext_deps	?	4.02 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	Click to show 6 deps `_addComponent` `_getProvider` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`_registerComponent`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	2.56 kB	? (?)
size_with_ext_deps	?	3.97 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	`_addComponent` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`_removeServiceInstance`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	2.68 kB	? (?)
size_with_ext_deps	?	4.09 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	Click to show 7 deps `_addComponent` `_getProvider` `_registerComponent` `_removeServiceInstance` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 20 deps `DEFAULT_ENTRY_NAME` `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`deleteApp`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	2.69 kB	? (?)
size_with_ext_deps	?	4.11 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	Click to show 6 deps `_addComponent` `_registerComponent` `deleteApp` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`getApp`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	2.65 kB	? (?)
size_with_ext_deps	?	5.34 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	Click to show 6 deps `_addComponent` `_registerComponent` `getApp` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 20 deps `DEFAULT_ENTRY_NAME` `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`getApps`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	2.59 kB	? (?)
size_with_ext_deps	?	4.01 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	Click to show 6 deps `_addComponent` `_registerComponent` `getApps` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`initializeApp`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	3.64 kB	? (?)
size_with_ext_deps	?	8.94 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	Click to show 6 deps `_addComponent` `_registerComponent` `initializeApp` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`FirebaseAppImpl` `PlatformLoggerService`	?
variables	?	Click to show 20 deps `DEFAULT_ENTRY_NAME` `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component` `ComponentContainer`	?

`onLog`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	2.68 kB	? (?)
size_with_ext_deps	?	5.89 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	Click to show 6 deps `_addComponent` `_registerComponent` `isVersionServiceProvider` `onLog` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/logger`	?	`Logger` `setUserLogHandler`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`registerVersion`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	2.56 kB	? (?)
size_with_ext_deps	?	3.97 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	`_addComponent` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`setLogLevel`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	2.59 kB	? (?)
size_with_ext_deps	?	4.06 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	Click to show 6 deps `_addComponent` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion` `setLogLevel`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 19 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `version`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/logger`	?	`Logger` `setLogLevel`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`@firebase/functions-exp`

`getFunctions`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	1.81 kB	? (?)
size_with_ext_deps	?	5.64 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	`getFunctions` `registerFunctions`	?
classes	?	`ContextProvider` `FunctionsService`	?
variables	?	`DEFAULT_REGION` `FUNCTIONS_TYPE` `factory` `name` `version`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/app-exp`	?	`_getProvider` `_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`httpsCallable`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	5.18 kB	? (?)
size_with_ext_deps	?	9.72 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	Click to show 10 deps `_errorForResponse` `call` `codeForHTTPStatus` `decode` `encode` `failAfter` `httpsCallable` `mapValues` `postJSON` `registerFunctions`	?
classes	?	`ContextProvider` `FunctionsError` `FunctionsService`	?
variables	?	Click to show 8 deps `DEFAULT_REGION` `FUNCTIONS_TYPE` `LONG_TYPE` `UNSIGNED_LONG_TYPE` `errorCodeMap` `factory` `name` `version`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/util`	?	`FirebaseError`	?
`@firebase/app-exp`	?	`_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`useFunctionsEmulator`

Size

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
size	?	1.78 kB	? (?)
size_with_ext_deps	?	5.57 kB	? (?)

Dependencies

Type	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
functions	?	`registerFunctions` `useFunctionsEmulator`	?
classes	?	`ContextProvider` `FunctionsService`	?
variables	?	`DEFAULT_REGION` `FUNCTIONS_TYPE` `factory` `name` `version`	?

External Dependencies

Module	Base (`8d3aca7`)	Head (`515ea8b`)	Diff
`@firebase/app-exp`	?	`_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

Test Logs

Head (515ea8b8): https://github.com/firebase/firebase-js-sdk/actions/runs/218547759

.github/workflows/health-metrics-test.yml

repo-scripts/size-analysis/analysis-helper.ts

scripts/tsconfig.json

scripts/report_modular_export_binary_size.ts

Feiyang1 · 2020-08-13T21:29:53Z

scripts/report_modular_export_binary_size.ts

+    return requestBody;
+  } catch (error) {
+    console.log(error);
+    return requestBody;


I think we want to abort the process instead of sending an empty report if error happens. @yifanyang Any thoughts ?

Also, can we log the full report even when there is no error? It will be easier for developers to reason about any size/dependencies diffs directly on GHA. Otherwise, they will have to clone the commit to local and run the size job by themselves.

so throw an error instead ?

If we don't intend to do anything else than re-throwing the error, then can we remove the try-catch block completely?

yifanyang · 2020-08-14T18:51:49Z

scripts/report_modular_export_binary_size.ts

+  }
+}
+
+function constructRequestPath(): string {


The code about constructing and sending the request seems almost the same to the one in report_binary_size. Anything we can do to reduce the duplication?

+1. We can create a folder (e.g. size_report/) and move this file and report_binary_size.js to it. We probably want to migrate report_binary_size.js to Typescript first, then we can extract the common logic to a 3rd file that is shared by the 2 report scripts.

…into ida-size-analysis-phase-2

yifanyang · 2020-08-18T23:15:42Z

scripts/size_report/report_modular_export_binary_size.ts

+  for (const report of reports) {
+    requestBody.modules.push(report);
+  }


Is it equivalent to requestBody.modules = reports? Or maybe just:

const requestBody: ModularExportBinarySizeRequestBody = { log: `https://github.com/${process.env.GITHUB_REPOSITORY}/actions/runs/${runId}`, modules: reports, };

yifanyang · 2020-08-18T23:15:59Z

scripts/size_report/size_report_helper.ts

-    let allModulesLocation: string[] = await mapWorkspaceToPackages([
-      `${projectRoot}/packages-exp/*`
-    ]);
+export const METRICS_SERVICE_URL = process.env.METRICS_SERVICE_URL!;


Do we need to export METRICS_SERVICE_URL? Or constructRequestOptions, constructRequestPath?

Feiyang1 · 2020-08-19T00:57:50Z

scripts/size_report/report_binary_size.ts

+    sdk: sdk,
+    type: type,
+    value: value


This is not necessary. Please revert to the shorthand syntax.

Feiyang1 · 2020-08-19T01:00:34Z

scripts/size_report/size_report_helper.ts

+  };
+}
+
+export function upload(report: RequestBody, requestEndpoint: string): void {


Can you make requestEndpoint an enum, so it harder to make typos?

…into ida-size-analysis-phase-2

Feiyang1 · 2020-08-19T23:48:20Z

repo-scripts/size-analysis/package.json

+    "@firebase/app": "0.6.10",
+    "@firebase/util": "0.3.1",


These are used in tests only, right? If so, they should be in devDependencies.

deepCopy from util is used in analysis-helper.ts. but i will move app to devDependencies

Feiyang1 · 2020-08-19T23:48:36Z

repo-scripts/size-analysis/package.json

    "rollup-plugin-replace": "2.2.0",
    "rollup-plugin-typescript2": "0.27.1",
-    "rollup-plugin-commonjs": "10.1.0",
-    "rollup-plugin-node-resolve": "5.2.0"
+    "tmp": "^0.2.1",


use fixed version

…into ida-size-analysis-phase-2

size analysis project phase 2

ce986be

XuechunHou requested review from Feiyang1 and hsubox76 August 11, 2020 20:26

XuechunHou requested a review from hiranya911 as a code owner August 11, 2020 20:26

XuechunHou assigned Feiyang1, hsubox76 and XuechunHou Aug 11, 2020

XuechunHou added 2 commits August 11, 2020 17:37

Merge branch 'master' of https://github.com/firebase/firebase-js-sdk …

b6978bb

…into ida-size-analysis-phase-2

point to prod version

0ff6cf8

Feiyang1 reviewed Aug 13, 2020

View reviewed changes

yifanyang reviewed Aug 14, 2020

View reviewed changes

XuechunHou added 6 commits August 14, 2020 14:58

addressed PR comments

e163176

Merge branch 'master' of https://github.com/firebase/firebase-js-sdk …

6a5f561

…into ida-size-analysis-phase-2

addressed PR comments

b37386b

removed try catch block

596db39

Merge branch 'master' of https://github.com/firebase/firebase-js-sdk …

b497585

…into ida-size-analysis-phase-2

consolidate common methods

0ae6ab4

yifanyang reviewed Aug 18, 2020

View reviewed changes

Feiyang1 suggested changes Aug 19, 2020

View reviewed changes

XuechunHou added 3 commits August 19, 2020 11:11

Merge branch 'master' of https://github.com/firebase/firebase-js-sdk …

2433390

…into ida-size-analysis-phase-2

addressed PR comments

d35e98e

changed method signature

a296735

Feiyang1 approved these changes Aug 19, 2020

View reviewed changes

XuechunHou added 2 commits August 19, 2020 16:52

Merge branch 'master' of https://github.com/firebase/firebase-js-sdk …

cd3875a

…into ida-size-analysis-phase-2

fixed lint errors

5b1a0bc

Feiyang1 reviewed Aug 19, 2020

View reviewed changes

fixed lint errors

78e15a4

yifanyang approved these changes Aug 20, 2020

View reviewed changes

Merge branch 'master' of https://github.com/firebase/firebase-js-sdk …

336fb17

…into ida-size-analysis-phase-2

XuechunHou merged commit 1508a0e into master Aug 21, 2020

XuechunHou deleted the ida-size-analysis-phase-2 branch August 21, 2020 16:52

firebase locked and limited conversation to collaborators Sep 21, 2020

size analysis project - phase 2 #3610

size analysis project - phase 2 #3610

Conversation

XuechunHou commented Aug 11, 2020

changeset-bot bot commented Aug 11, 2020 • edited Loading

💥 No Changeset

google-oss-bot commented Aug 11, 2020 • edited Loading

Binary Size Report

Affected SDKs

Test Logs

google-oss-bot commented Aug 11, 2020 • edited Loading

Size Analysis Report

Affected Products

@firebase/app-exp

LogLevel

Size

Dependencies

External Dependencies

SDK_VERSION

Size

Dependencies

External Dependencies

_addComponent

Size

Dependencies

External Dependencies

_addOrOverwriteComponent

Size

Dependencies

External Dependencies

_apps

Size

Dependencies

External Dependencies

_clearComponents

Size

Dependencies

External Dependencies

_components

Size

Dependencies

External Dependencies

_getProvider

Size

Dependencies

External Dependencies

_registerComponent

Size

Dependencies

External Dependencies

_removeServiceInstance

Size

Dependencies

External Dependencies

deleteApp

Size

Dependencies

External Dependencies

getApp

Size

Dependencies

External Dependencies

getApps

Size

Dependencies

External Dependencies

initializeApp

Size

Dependencies

External Dependencies

onLog

Size

Dependencies

External Dependencies

registerVersion

Size

Dependencies

External Dependencies

setLogLevel

Size

changeset-bot bot commented Aug 11, 2020 •

edited

Loading

google-oss-bot commented Aug 11, 2020 •

edited

Loading

google-oss-bot commented Aug 11, 2020 •

edited

Loading

`@firebase/app-exp`

`LogLevel`

`SDK_VERSION`

`_addComponent`

`_addOrOverwriteComponent`

`_apps`

`_clearComponents`

`_components`

`_getProvider`

`_registerComponent`

`_removeServiceInstance`

`deleteApp`

`getApp`

`getApps`

`initializeApp`

`onLog`

`registerVersion`

`setLogLevel`

`@firebase/functions-exp`

`getFunctions`

`httpsCallable`

`useFunctionsEmulator`

Feiyang1 Aug 18, 2020 •

edited

Loading