Skip to content

Extended Usage of isIndexedDBAvailable to Service Worker #3585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 10, 2020

Conversation

XuechunHou
Copy link
Contributor

change from 'indexedDB' in window to 'indexedDB' in self

@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2020

🦋 Changeset is good to go

Latest commit: fee8630

We got this.

This PR includes changesets to release 23 packages
Name Type
firebase Patch
@firebase/util Patch
@firebase/testing Patch
firebase-browserify-test Patch
firebase-package-typings-test Patch
firebase-messaging-selenium-test Patch
firebase-typescript-test Patch
firebase-webpack-test Patch
@firebase/analytics Patch
@firebase/app Patch
@firebase/component Patch
@firebase/database Patch
@firebase/firestore Patch
@firebase/installations Patch
@firebase/messaging Patch
@firebase/performance Patch
@firebase/remote-config Patch
@firebase/storage Patch
@firebase/app-exp Patch
@firebase/functions-exp Patch
@firebase/functions Patch
firebase-exp Patch
firebase-firestore-integration-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 7, 2020

Binary Size Report

Affected SDKs

  • @firebase/database

    Type Base (41ed6f2) Head (b6a436e) Diff
    browser 269 kB 269 kB +1 B (+0.0%)
    esm2017 236 kB 236 kB +1 B (+0.0%)
    main 270 kB 270 kB +1 B (+0.0%)
    module 268 kB 268 kB +1 B (+0.0%)
  • @firebase/firestore/exp

    Type Base (41ed6f2) Head (b6a436e) Diff
    browser 188 kB 189 kB +271 B (+0.1%)
    main 467 kB 468 kB +473 B (+0.1%)
    module 188 kB 189 kB +271 B (+0.1%)
    react-native 188 kB 189 kB +272 B (+0.1%)
  • @firebase/firestore/lite

    Type Base (41ed6f2) Head (b6a436e) Diff
    browser 64.3 kB 64.6 kB +276 B (+0.4%)
    main 142 kB 143 kB +463 B (+0.3%)
    module 64.3 kB 64.6 kB +276 B (+0.4%)
    react-native 64.4 kB 64.7 kB +280 B (+0.4%)
  • @firebase/util

    Type Base (41ed6f2) Head (b6a436e) Diff
    browser 20.5 kB 20.5 kB -28 B (-0.1%)
    esm2017 18.3 kB 18.3 kB -28 B (-0.2%)
    main 20.5 kB 20.5 kB -28 B (-0.1%)
    module 19.5 kB 19.5 kB -28 B (-0.1%)
  • firebase

    Type Base (41ed6f2) Head (b6a436e) Diff
    firebase-analytics.js 28.3 kB 28.3 kB -2 B (-0.0%)
    firebase-database.js 187 kB 187 kB +1 B (+0.0%)
    firebase.js 821 kB 821 kB -1 B (-0.0%)

Test Logs

@@ -0,0 +1,6 @@
---
"@firebase/firebase": minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't catch this in the previous PR but the package name is firebase, there's no @firebase/firebase. Also I think these should be patch because there's no API change.

@XuechunHou XuechunHou merged commit d4ca3da into master Aug 10, 2020
@XuechunHou XuechunHou deleted the utils-IsIndexedDBAvailable branch August 10, 2020 23:32
@google-oss-bot google-oss-bot mentioned this pull request Aug 11, 2020
@firebase firebase locked and limited conversation to collaborators Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants